dashboard: when a new job is added, don't scroll the stopped log window being hovered over #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… hovered over This fixes: "when you hover over a log window, it stops scrolling as intended, but each time a new job is added at the top of the dashboard, the log window scrolls to the bottom. I'm pretty sure this wasn't the case before [...]." Diagnosis: `JobsRenderer._createLogContainer` calls `this.applyFilter()`; `applyFilter` was scrolling all the log windows (with the intention of scrolling log windows made newly visible by the filter), but neglected to check whether they were `log-window-stopped`.
|
Merging after testing: Chrome 119 on Windows: before fix, confirmed that Firefox 119 on Windows: confirmed no more scrolling after the fix. Performance considerations: there might be a better way to do this without querying |
ivan
changed the title
ivan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes:
"when you hover over a log window, it stops scrolling as intended, but each time a new job is added at the top of the dashboard, the log window scrolls to the bottom. I'm pretty sure this wasn't the case before [...]."
Reported by @JustAnotherArchivist
Diagnosis:
JobsRenderer._createLogContainercallsthis.applyFilter();applyFilterwas scrolling all the log windows (with the intention of scrolling log windows made newly visible by the filter), but neglected to check whether they werelog-window-stopped.