dashboard: fix out-of-viewport log windows not being scrolled down in Chrome #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng scrolled to the bottom after expanding them in Chrome
… not being scrolled to the bottom after expanding them in Chrome" This reverts commit c99d488. This regressed performance in Chrome when having all the log windows expanded and looking at the top of the page: memory footprint went from 214MB -> 442MB and CPU time went from 1m18s to 1m52s.
|
Merging after testing: Chrome: confirmed that CPU and memory haven't regressed when 1) log windows are all collapsed, or 2) log windows are all expanded Chrome: confirmed that log windows get scrolled down after expanding them all and scrolling to the end of the dashboard where there are inactive jobs Chrome: confirmed that log windows get scrolled down after clicking to expand an individual inactive job Firefox: confirmed that it still loads and runs iOS Safari: confirmed that it still loads and runs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the comment in the diff