/[Apache-SVN]/subversion/trunk/subversion/libsvn_subr/cmdline.c
ViewVC logotype

Log of /subversion/trunk/subversion/libsvn_subr/cmdline.c

Parent Directory Parent Directory | Revision Log Revision Log


Links to HEAD: (view) (download) (annotate)
Sticky Revision:

Revision 1875230 - (view) (download) (annotate) - [select for diffs]
Modified Mon Mar 16 04:11:36 2020 UTC (4 years, 4 months ago) by jamessan
File length: 60408 byte(s)
Diff to previous 1874093 (colored)
Followup to r1874093, add Windows-specific argument escaping

Rather than directly using apr_pescape_shell(), use apr_escape_shell() to give
an indication whether escaping is needed.  If APR reports no escaping is
needed, simply surround the argument in double-quotes to handle any embedded
whitespace.

When escaping is needed, on Unix we continue to use APR's escaping +
post-processing for whitespace.  On Windows, perform the escaping ourselves per
these rules:

  1. Surround the string with double-quotes
  2. Escape any double-quotes or backslashes preceding a double-quote
  3. Escape any metacharacters, including double-quotes, with ^

* subversion/libsvn_subr/cmdline.c
  (escape_path): Refactored as above


Revision 1874093 - (view) (download) (annotate) - [select for diffs]
Modified Mon Feb 17 02:13:34 2020 UTC (4 years, 5 months ago) by jamessan
File length: 58057 byte(s)
Diff to previous 1874057 (colored)
Followup to r1874057, escape whitespace instead of quoting filename

As danielsh pointed out, only specific characters can be escaped by a backslash
in quoted shell strings.  Rather than surrounding the escaped path with double
quotes, post-process the quoted path and manually escape any whitespace that is
present.

* subversion/libsvn_subr/cmdline.c
  (escape_path): New function, wrapper around apr_pescape_shell(), which
   handles escaping of whitespace.
  (svn_cmdline__edit_file_externally, svn_cmdline__edit_string_externally):
   Call the new function instead of apr_pescape_shell()
* subversion/tests/cmdline/update_tests.py
  (update_accept_conflicts): Include ';' in renamed path ("p; i"), to ensure
   non-whitespace escaping is handled correctly.


Revision 1874057 - (view) (download) (annotate) - [select for diffs]
Modified Sat Feb 15 16:24:53 2020 UTC (4 years, 5 months ago) by jamessan
File length: 57241 byte(s)
Diff to previous 1821224 (colored)
Escape filenames when invoking $SVN_EDITOR

Per https://subversion.apache.org/faq.html#svn-editor, $SVN_EDITOR is invoked
through the shell instead of directly executed.  The user is expected to
properly escape/quote $SVN_EDITOR, but svn was putting the filename directly
into the command without any escaping.  This therefore breaks attempts to,
e.g., run the editor from the merge conflict dialog when a path has special
characters.

Update locations where we invoke the editor to quote the filename as well as
escape shell special characters using apr_pescape_shell().  The quotes are
needed in addition to the escaping, since apr_pescape_shell() does not escape
whitespace.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline__edit_file_externally, svn_cmdline__edit_string_externally):
   Quote and escape, via apr_pescape_shell(), the filename in the command line.
* subversion/tests/cmdline/update_test.py
  (update_accept_conflicts): Rename "A/D/G/pi" to "A/D/G/p i" before performing
   the merge, so the test exercises the changes above.


Revision 1821224 - (view) (download) (annotate) - [select for diffs]
Modified Tue Jan 16 09:36:13 2018 UTC (6 years, 6 months ago) by julianfoad
File length: 56830 byte(s)
Diff to previous 1755991 (colored)
Rename and move the new-for-1.10 function 'svn_io_stdin_readline()' to
'svn_cmdline__stdin_readline()'.

It is just a wrapper around existing API functions and lacks some checking and
options so was deemed not suitable to go into the public API in its current
form.

* subversion/include/private/svn_cmdline_private.h,
  subversion/libsvn_subr/cmdline.c
  (svn_cmdline__stdin_readline): Rename and move to here...

* subversion/include/svn_io.h
* subversion/libsvn_subr/io.c
  (svn_io_stdin_readline): ... from here.

* subversion/svnbench/svnbench.c,
  subversion/svnmucc/svnmucc.c,
  subversion/svnrdump/svnrdump.c,
  subversion/svn/svn.c,
  tools/client-side/svnconflict/svnconflict.c,
  tools/client-side/svn-mergeinfo-normalizer/svn-mergeinfo-normalizer.c,
  tools/dev/svnmover/svnmover.c
  (sub_main): Track the rename.


Revision 1755991 - (view) (download) (annotate) - [select for diffs]
Modified Thu Aug 11 14:14:14 2016 UTC (7 years, 11 months ago) by ivan
File length: 56356 byte(s)
Diff to previous 1749883 (colored)
Avoid code duplication by using existing function.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline__be_interactive): Use svn_cmdline__stdin_is_a_terminal().


Revision 1749883 - (view) (download) (annotate) - [select for diffs]
Modified Thu Jun 23 13:13:01 2016 UTC (8 years, 1 month ago) by ivan
File length: 56418 byte(s)
Diff to previous 1729673 (colored)
Small refactoring.

* subversion/libsvn_subr/cmdline.c
  (most_similar): Initialize MAX_SIMILAR to NULL at the beginning and return
   it directly instead of checking if MAX_SCORE is non-zero.


Revision 1729673 - (view) (download) (annotate) - [select for diffs]
Modified Wed Feb 10 17:25:55 2016 UTC (8 years, 5 months ago) by philip
File length: 56454 byte(s)
Diff to previous 1729463 (colored)
Move a bit more of the signal handling code from the programs to the library.

* subversion/include/private/svn_cmdline_private.h
  (svn_cmdline__get_cancellation_signal): Remove.
  (svn_cmdline__cancellation_exit): New.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline__get_cancellation_signal): Remove.
  (svn_cmdline__cancellation_exit): New.

* subversion/svn/svn.c
* subversion/svnadmin/svnadmin.c
* subversion/svnbench/svnbench.c
* subversion/svnfsfs/svnfsfs.c
* subversion/svnlook/svnlook.c
* subversion/svnrdump/svnrdump.c
* subversion/svnsync/svnsync.c
  (main): Call new function.


Revision 1729463 - (view) (download) (annotate) - [select for diffs]
Modified Tue Feb 9 21:43:03 2016 UTC (8 years, 5 months ago) by philip
File length: 56341 byte(s)
Diff to previous 1714640 (colored)
Move signal handling and cancellation code to libsvn_subr to avoid
duplication in multiple programs.

* subversion/include/private/svn_cmdline_private.h
  (svn_cmdline__setup_cancellation_handler,
   svn_cmdline__disable_cancellation_handler,
   svn_cmdline__get_cancellation_signal): New.

* subversion/libsvn_subr/cmdline.c
  (signal_handler, check_cancel,
   svn_cmdline__setup_cancellation_handler,
   svn_cmdline__disable_cancellation_handler,
   svn_cmdline__get_cancellation_signal): New, code from svn.c and svnadmin.c.

* subversion/svn/cl.h
  (svn_cl__check_cancel): Change type to pointer.

* subversion/svn/svn.c
  (svn_cl__check_cancel): Change type to pointer.
  (signal_handler): Remove.
  (sub_main, main): Call new functions.

* subversion/svnadmin/svnadmin.c
  (check_cancel): Change type to pointer.
  (signal_handler, setup_cancellation_signalsl): Remove.
  (repos_notify_handler, subcommand_recover, subcommand_upgrade,
   sub_main, main): Call new functions.

* subversion/svnbench/cl.h
  (svn_cl__check_cancel): Change type to pointer.

* subversion/svnbench/svnbench.c
  (svn_cl__check_cancel): Change type to pointer.
  (signal_handler): Remove.
  (sub_main, main): Call new functions.

* subversion/svnfsfs/svnfsfs.h
  (check_cancel): Change type to pointer.

* subversion/svnfsfs/svnfsfs.c
  (check_cancel): Change type to pointer.
  (signal_handler, setup_cancellation_signals): Remove.
  (sub_main, main): Call new functions.

* subversion/svnlook/svnlook.c
  (check_cancel): Change type to pointer.
  (signal_handler): Remove.
  (sub_main, main): Call new functions.

* subversion/svnrdump/svnrdump.c
  (check_cancel): Change type to pointer.
  (signal_handler): Remove.
  (sub_main, main): Call new functions.

* subversion/svnsync/svnsync.c
  (check_cancel): Change type to pointer.
  (signal_handler): Remove.
  (sub_main, main): Call new functions.


Revision 1714640 - (view) (download) (annotate) - [select for diffs]
Modified Mon Nov 16 17:46:37 2015 UTC (8 years, 8 months ago) by julianfoad
File length: 54278 byte(s)
Diff to previous 1678894 (colored)
Merge the 'svnmover' prototype from the 'move-tracking-2' branch to trunk.

See the dev@ email thread "Merge 'svnmover' demo tool to trunk" started on
2015-11-10, archived at e.g. <http://mail-archives.apache.org/mod_mbox/subversion-dev/201511.mbox/%3CCAEcU=1YE5Ci02j_4aAeB_roS1X0H2QWPP3juu0exjVJ-FGCLyg@mail.gmail.com%3E>.

This is a reintegration (performed as an automatic merge) followed by
reverting the unwanted parts. As such, those unwanted parts (such as shim
insertions in several libraries) will be treated as 'record-only merged' and
will not be picked up by any subsequent automatic merge to trunk.

A brief description of the changes follows.

* build.conf
  Adjust to build the new files.

* configure.ac
  Adjust compiler warning flags to not warn about passing or returning a
  structure, because some of the code does so.

* LICENSE
  Add the licence text for the embedded 'linenoise' library.

* notes/move-tracking/README
  New file, describing this work.

* subversion/include/private/svn_branch.h,
  subversion/include/private/svn_branch_compat.h,
  subversion/include/private/svn_branch_impl.h,
  subversion/include/private/svn_branch_nested.h,
  subversion/include/private/svn_branch_repos.h,
  subversion/include/private/svn_element.h
  New files.

* subversion/libsvn_delta/branch.c,
  subversion/libsvn_delta/branch_compat.c,
  subversion/libsvn_delta/branch_migrate.c,
  subversion/libsvn_delta/branch_nested.c,
  subversion/libsvn_delta/branch_repos.c,
  subversion/libsvn_delta/element.c
  New files.

* subversion/include/private/svn_cmdline_private.h
  subversion/libsvn_subr/cmdline.c
  (svn_cmdline__stdin_is_a_terminal,
   svn_cmdline__stdout_is_a_terminal,
   svn_cmdline__stderr_is_a_terminal): New.

* subversion/tests/cmdline/svnmover_tests.py
  New file.

* subversion/tests/cmdline/svntest/actions.py
  (run_and_verify_svnmover,
   run_and_verify_svnmover2): New.

* subversion/tests/cmdline/svntest/main.py
  (svnmover_binary,
   run_svnmover): New.
  (execute_tests): Initialize 'svnmover_binary'.

* subversion/tests/cmdline/svntest/wc.py
  (State): Add 'rename' and 'from_eids' methods.
  (StateItem): Add an 'eid' attribute.

* tools/dev/svnmover
  New tool.


Revision 1678894 - (view) (download) (annotate) - [select for diffs]
Modified Tue May 12 08:39:02 2015 UTC (9 years, 2 months ago) by rhuijben
File length: 53789 byte(s)
Diff to previous 1678734 (colored)
Following up on r1678734, remove unneeded prefix from error message.

* subversion/include/private/svn_cmdline_private.h
* subversion/libsvn_subr/cmdline.c
  (svn_cmdline__parse_trust_options): Remove unneeded argument and usage.

* subversion/svn/svn.c
* subversion/svnbench/svnbench.c
* subversion/svnmucc/svnmucc.c
* subversion/svnrdump/svnrdump.c
* subversion/svnsync/svnsync.c
  (sub_main): Update caller.


Revision 1678734 - (view) (download) (annotate) - [select for diffs]
Modified Mon May 11 11:56:46 2015 UTC (9 years, 2 months ago) by rhuijben
File length: 53909 byte(s)
Diff to previous 1678571 (colored)
Following up on an irc discussion integrate the --trust-unknown-ca,
--trust-cn-mismatch, --trust-expired, --trust-not-yet-valid and
--trust-other-failure commandline options of svn, svnbench, svnmucc,
svnrdump and svnsync into a new --trust-server-cert-failures option
with arguments that specify which error will be ignored.

This patch is based on an initial (much smaller)
Patch by: danielsh

This patch should be released in 1.9.0 or at least partially reverted.

* subversion/include/private/svn_cmdline_private.h
  (svn_cmdline__parse_trust_options): New function.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline__parse_trust_options): New function.

* subversion/svn/svn.c
  (svn_cl__longopt_t): Tweak options.
  (svn_cl__options): Update definition and documentation.
  (svn_cl__global_options): Update.
  (sub_main): Use new api. Tweak error.

* subversion/svnbench/svnbench.c
  (svn_cl__longopt_t): Tweak options.
  (svn_cl__options): Update definition and documentation.
  (svn_cl__global_options): Update.
  (sub_main): Use new api. Tweak error.

* subversion/svnmucc/svnmucc.c
  (help): Update documentation.
  (sub_main): Tweak options, definition and usage.

* subversion/svnrdump/svnrdump.c
  (svn_svnrdump__longopt_t,
   SVN_SVNRDUMP__BASE_OPTIONS): Tweak options.
  (svnrdump__options): Update definition and documentation.
  (sub_main): Use new api. Tweak error.

* subversion/svnsync/svnsync.c
  (svnsync__opt,
   SVNSYNC_OPTS_DEFAULT): Tweak options.
  (svnsync_options): Update definition and documentation.
  (sub_main): Use new api. Tweak error.

* subversion/tests/cmdline/getopt_tests_data/svn_help_log_switch_stdout
  Update expected output.


Revision 1678571 - (view) (download) (annotate) - [select for diffs]
Modified Sun May 10 15:54:22 2015 UTC (9 years, 2 months ago) by danielsh
File length: 51925 byte(s)
Diff to previous 1678497 (colored)
* subversion/libsvn_subr/cmdline.c
  (trust_server_cert_non_interactive): Fix false-positive acceptance of
    certificates with multiple failures of which some but not all were
    designated acceptable.

Revision 1678497 - (view) (download) (annotate) - [select for diffs]
Modified Sat May 9 15:11:59 2015 UTC (9 years, 2 months ago) by danielsh
File length: 51816 byte(s)
Diff to previous 1674305 (colored)
* subversion/libsvn_subr/cmdline.c
  (validate_config_option): Fix docstring.  No functional change.

Revision 1674305 - (view) (download) (annotate) - [select for diffs]
Modified Fri Apr 17 13:48:12 2015 UTC (9 years, 3 months ago) by rhuijben
File length: 51815 byte(s)
Diff to previous 1674301 (colored)
* subversion/libsvn_subr/cmdline.c
  (validate_config_option): Remove SVN_DBG() call to unbreak compilation in
    release mode.

Revision 1674301 - (view) (download) (annotate) - [select for diffs]
Modified Fri Apr 17 13:30:25 2015 UTC (9 years, 3 months ago) by danielsh
File length: 51882 byte(s)
Diff to previous 1663014 (colored)
--config-option: Warn when the FILE:SECTION:OPTION combination may be invalid.

Currently there are false negatives: if each component is individually known,
then there won't be a warning, even if the tuple as a whole is invalid.

The implementation is as follows: first, parse svn_config.h to generate a list
of valid file/section/option names:

* subversion/libsvn_subr/config_keys.inc:
    Not a versioned file, but will be generated by gen-make.py.

* build/generator/gen_base.py
  (collections): Import.
  (GeneratorBase.FileSectionOptionEnum): New class.
  (GeneratorBase._client_configuration_defines): New method.
  (GeneratorBase.write_config_keys): New method.
  (IncludeDependencyInfo._scan_for_includes):
    Exempt config_keys.inc from dependency scanning.

* build/generator/templates/build-outputs.mk.ezt
  (EXTRACLEAN_FILES): Clean config_keys.inc.

* gen-make.py
  (main): Generate config_keys.inc.

Second, have the --config-option parser warn to stderr about unknown values:

* subversion/include/private/svn_cmdline_private.h
  (svn_cmdline__parse_config_option): Add PREFIX argument, document new
    functionality.

* subversion/libsvn_subr/cmdline.c
  (config_keys.inc): Include.
  (most_similar, string_in_array, validate_config_option): New functions.
  (svn_cmdline__parse_config_option): Validate the config option's coordinates
    and warn if they may be invalid.

* subversion/svn/similarity.c
  (svn_cl__similarity_check): Cross-reference most_similar().
    No functional change.

Third, add a unit test:

* subversion/tests/cmdline/getopt_tests.py
  (getopt_config_option): New test.

Finally, update callers for the trivial signature change:

* subversion/svn/svn.c           (sub_main),
* subversion/svnbench/svnbench.c (sub_main),
* subversion/svnmucc/svnmucc.c   (sub_main),
* subversion/svnrdump/svnrdump.c (sub_main):
      Pass new PREFIX argument.

* subversion/svnsync/svnsync.c
  (sub_main): Ditto, in two places.


Revision 1663014 - (view) (download) (annotate) - [select for diffs]
Modified Sat Feb 28 23:47:28 2015 UTC (9 years, 4 months ago) by rhuijben
File length: 47764 byte(s)
Diff to previous 1663013 (colored)
* subversion/libsvn_subr/cmdline.c
  (svn_cmdline__edit_string_externally): Following up on r1663012 and r1663013,
    fix the ignoring of an error (as documented right above this function call).


Revision 1663013 - (view) (download) (annotate) - [select for diffs]
Modified Sat Feb 28 23:45:31 2015 UTC (9 years, 4 months ago) by rhuijben
File length: 47769 byte(s)
Diff to previous 1663012 (colored)
* subversion/libsvn_subr/cmdline.c
  (svn_cmdline__edit_string_externally): Really use time - 2 sec,
    instead of something like time - 0.002 sec


Revision 1663012 - (view) (download) (annotate) - [select for diffs]
Modified Sat Feb 28 23:26:08 2015 UTC (9 years, 4 months ago) by rhuijben
File length: 47707 byte(s)
Diff to previous 1630117 (colored)
* subversion/libsvn_subr/cmdline.c
  (svn_cmdline__edit_file_externally): Use svn_io_file_*() where possible,
    to use standard path conversions and error handling. Compose errors
    instead of dropping them.


Revision 1630117 - (view) (download) (annotate) - [select for diffs]
Modified Wed Oct 8 14:22:40 2014 UTC (9 years, 9 months ago) by stsp
File length: 48260 byte(s)
Diff to previous 1592144 (colored)
For non-interactive mode, allow fine-grained control over which SSL
certificate failures are considered fatal and which may be ignored.

The --trust-server-cert option only accepts certificates signed by an
unknown CA, and rejects certificates which fail for other reasons.
However, in practice, people run into broken SSL configurations that
trigger other failure conditions such as hostname/CN mismatch, expired
certs, etc. Sometimes they are not in a position to fix the problem themselves
and can't get work done (writing scripts) since SVN refuses to operate.
This topic is one of the most discussed issues in the #svn IRC channel.
Somewhat less so on the users@ mailing lists, though it also occurs there.

There is no real reason to prefer one kind of failure condition over
any other. An invalid cert is an invalid cert, regardless of why it fails
validation. Ultimately, it is up to users to waive trust in SSL when it
gets in the way in a particular situation. We should not be making this
decision for them.

Deprecate the --trust-server-cert option and add the following new options
to 'svn', exposing all possible failure modes the underlying API can handle:

  --trust-unknown-ca       : with --non-interactive, accept SSL server
                             certificates from unknown certificate authorities
  --trust-cn-mismatch      : with --non-interactive, accept SSL server
                             certificates even if the server hostname does not
                             match the certificate's common name attribute
  --trust-expired          : with --non-interactive, accept expired SSL server
                             certificates
  --trust-not-yet-valid    : with --non-interactive, accept SSL server
                             certificates from the future
  --trust-other-failure    : with --non-interactive, accept SSL server
                             certificates with failures other than the above

* subversion/include/svn_cmdline.h
  (svn_cmdline_create_auth_baton2): Declare and document new parameters.
  (svn_cmdline_create_auth_baton): Deprecate.

* subversion/libsvn_subr/cmdline.c
  (trust_server_cert_non_interactive_baton): New baton.
  (ssl_trust_unknown_server_cert): Rename to ...
  (trust_server_cert_non_interactive): .. this and implement generic
   validation failure checks according to flags passed in baton.
  (svn_cmdline_create_auth_baton): Move to libsvn_subr/deprecated.c.
  (svn_cmdline_create_auth_baton2): Implement new revision of this API with
   new options trust_server_cert_unknown_ca, trust_server_cert_cn_mismatch,
   trust_server_cert_expired, trust_server_cert_not_yet_valid, and
   trust_server_cert_other_failure.

* subversion/libsvn_subr/deprecated.c
  (svn_cmdline_create_auth_baton): Implement as wrapper around
   svn_cmdline_create_auth_baton2.

* subversion/svn/cl.h
  (svn_cl__opt_state_t): Add new options trust_server_cert_unknown_ca,
   trust_server_cert_cn_mismatch, trust_server_cert_expired,
   trust_server_cert_not_yet_valid, and trust_server_cert_other_failure.
  .
* subversion/svn/svn.c
   (svn_cl__longopt_t): Add new options opt_trust_server_cert_unknown_ca,
    opt_trust_server_cert_cn_mismatch, opt_trust_server_cert_expired,
    opt_trust_server_cert_not_yet_valid, opt_trust_server_cert_other_failure.
   (svn_cl__options): Add options and help text for --trust-unknown-ca,
    --trust-cn-mismatch, --trust-expired, --trust-not-yet-valid, and
    --trust-other-failure.
   (svn_cl__global_options): Add the new options here.
   (sub_main): Process new options and use svn_cmdline_create_auth_baton2().
                         
* subversion/tests/cmdline/getopt_tests_data/svn_help_log_switch_stdout:
   Adjust expected output.


Revision 1592144 - (view) (download) (annotate) - [select for diffs]
Modified Sat May 3 04:56:18 2014 UTC (10 years, 2 months ago) by breser
File length: 46324 byte(s)
Diff to previous 1575973 (colored)
* subversion/libsvn_subr/cmdline.c
  (svn_cmdline__edit_string_externally): Use NULLs for pointers to booleans
    that could potentially be filled in rather than FALSE when calling
    svn_subst_translate_string2(), no functional change, stylistic.


Revision 1575973 - (view) (download) (annotate) - [select for diffs]
Modified Mon Mar 10 15:31:49 2014 UTC (10 years, 4 months ago) by rhuijben
File length: 46326 byte(s)
Diff to previous 1555133 (colored)
Revert r1508225, which moved the include of svn_private_config.h before all
includes of our public headers. Public headers shouldn't depend on private
headers and all changes that required this are long reverted on trunk.

This patch excludes all conflicting cases.

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c
* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
* subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c
* subversion/libsvn_auth_gnome_keyring/gnome_keyring.c
* subversion/libsvn_client/add.c
* subversion/libsvn_client/cat.c
* subversion/libsvn_client/changelist.c
* subversion/libsvn_client/cleanup.c
* subversion/libsvn_client/commit.c
* subversion/libsvn_client/commit_util.c
* subversion/libsvn_client/copy.c
* subversion/libsvn_client/copy_foreign.c
* subversion/libsvn_client/ctx.c
* subversion/libsvn_client/delete.c
* subversion/libsvn_client/deprecated.c
* subversion/libsvn_client/diff.c
* subversion/libsvn_client/diff_local.c
* subversion/libsvn_client/diff_summarize.c
* subversion/libsvn_client/export.c
* subversion/libsvn_client/externals.c
* subversion/libsvn_client/import.c
* subversion/libsvn_client/info.c
* subversion/libsvn_client/iprops.c
* subversion/libsvn_client/list.c
* subversion/libsvn_client/locking_commands.c
* subversion/libsvn_client/log.c
* subversion/libsvn_client/merge.c
* subversion/libsvn_client/mergeinfo.c
* subversion/libsvn_client/patch.c
* subversion/libsvn_client/prop_commands.c
* subversion/libsvn_client/ra.c
* subversion/libsvn_client/repos_diff.c
* subversion/libsvn_client/resolved.c
* subversion/libsvn_client/revert.c
* subversion/libsvn_client/switch.c
* subversion/libsvn_client/update.c
* subversion/libsvn_client/util.c
* subversion/libsvn_delta/compat.c
* subversion/libsvn_delta/xdelta.c
* subversion/libsvn_diff/parse-diff.c
* subversion/libsvn_diff/util.c
* subversion/libsvn_fs/access.c
* subversion/libsvn_fs_base/bdb/changes-table.c
* subversion/libsvn_fs_base/bdb/env.c
* subversion/libsvn_fs_base/dag.c
* subversion/libsvn_fs_base/fs.c
* subversion/libsvn_fs_base/lock.c
* subversion/libsvn_fs_base/revs-txns.c
* subversion/libsvn_fs_base/tree.c
* subversion/libsvn_fs_fs/caching.c
* subversion/libsvn_fs_fs/lock.c
* subversion/libsvn_fs_fs/temp_serializer.c
* subversion/libsvn_fs_fs/tree.c
* subversion/libsvn_ra/compat.c
* subversion/libsvn_ra/deprecated.c
* subversion/libsvn_ra/ra_loader.c
* subversion/libsvn_ra_local/ra_plugin.c
* subversion/libsvn_ra_serf/blame.c
* subversion/libsvn_ra_serf/blncache.c
* subversion/libsvn_ra_serf/commit.c
* subversion/libsvn_ra_serf/getlocations.c
* subversion/libsvn_ra_serf/getlocationsegments.c
* subversion/libsvn_ra_serf/getlocks.c
* subversion/libsvn_ra_serf/inherited_props.c
* subversion/libsvn_ra_serf/log.c
* subversion/libsvn_ra_serf/merge.c
* subversion/libsvn_ra_serf/mergeinfo.c
* subversion/libsvn_ra_serf/options.c
* subversion/libsvn_ra_serf/property.c
* subversion/libsvn_ra_serf/replay.c
* subversion/libsvn_ra_serf/serf.c
* subversion/libsvn_ra_serf/update.c
* subversion/libsvn_ra_serf/util.c
* subversion/libsvn_ra_serf/xml.c
* subversion/libsvn_ra_svn/client.c
* subversion/libsvn_ra_svn/editorp.c
* subversion/libsvn_ra_svn/marshal.c
* subversion/libsvn_repos/authz.c
* subversion/libsvn_repos/commit.c
* subversion/libsvn_repos/delta.c
* subversion/libsvn_repos/deprecated.c
* subversion/libsvn_repos/fs-wrap.c
* subversion/libsvn_repos/hooks.c
* subversion/libsvn_repos/log.c
* subversion/libsvn_repos/replay.c
* subversion/libsvn_repos/reporter.c
* subversion/libsvn_repos/repos.c
* subversion/libsvn_repos/rev_hunt.c
* subversion/libsvn_subr/auth.c
* subversion/libsvn_subr/cmdline.c
* subversion/libsvn_subr/compat.c
* subversion/libsvn_subr/config.c
* subversion/libsvn_subr/config_auth.c
* subversion/libsvn_subr/deprecated.c
* subversion/libsvn_subr/dso.c
* subversion/libsvn_subr/hash.c
* subversion/libsvn_subr/io.c
* subversion/libsvn_subr/mergeinfo.c
* subversion/libsvn_subr/opt.c
* subversion/libsvn_subr/properties.c
* subversion/libsvn_subr/simple_providers.c
* subversion/libsvn_subr/sorts.c
* subversion/libsvn_subr/ssl_client_cert_providers.c
* subversion/libsvn_subr/ssl_client_cert_pw_providers.c
* subversion/libsvn_subr/ssl_server_trust_providers.c
* subversion/libsvn_subr/subst.c
* subversion/libsvn_subr/types.c
* subversion/libsvn_subr/username_providers.c
* subversion/libsvn_subr/utf.c
* subversion/libsvn_subr/win32_crypto.c
* subversion/libsvn_wc/adm_crawler.c
* subversion/libsvn_wc/adm_files.c
* subversion/libsvn_wc/conflicts.c
* subversion/libsvn_wc/copy.c
* subversion/libsvn_wc/deprecated.c
* subversion/libsvn_wc/diff_editor.c
* subversion/libsvn_wc/diff_local.c
* subversion/libsvn_wc/entries.c
* subversion/libsvn_wc/externals.c
* subversion/libsvn_wc/info.c
* subversion/libsvn_wc/lock.c
* subversion/libsvn_wc/node.c
* subversion/libsvn_wc/old-and-busted.c
* subversion/libsvn_wc/props.c
* subversion/libsvn_wc/revert.c
* subversion/libsvn_wc/status.c
* subversion/libsvn_wc/update_editor.c
* subversion/libsvn_wc/upgrade.c
* subversion/libsvn_wc/wc_db_update_move.c
* subversion/libsvn_wc/wc_db_wcroot.c
* subversion/mod_dav_svn/repos.c
* subversion/mod_dav_svn/version.c
* subversion/svn/cl-conflicts.c
* subversion/svn/commit-cmd.c
* subversion/svn/conflict-callbacks.c
* subversion/svn/diff-cmd.c
* subversion/svn/help-cmd.c
* subversion/svn/notify.c
* subversion/svn/propedit-cmd.c
* subversion/svn/propget-cmd.c
* subversion/svn/props.c
* subversion/svn/status-cmd.c
* subversion/svn/status.c
* subversion/svn/svn.c
* subversion/svn/util.c
* subversion/svnadmin/svnadmin.c
* subversion/svnlook/svnlook.c
* subversion/svnrdump/dump_editor.c
* subversion/svnrdump/svnrdump.c
* subversion/svnrdump/util.c
* subversion/svnserve/serve.c
* subversion/svnsync/svnsync.c
* subversion/svnsync/sync.c
* subversion/tests/libsvn_fs/fs-test.c
* subversion/tests/libsvn_repos/repos-test.c
* subversion/tests/libsvn_subr/hashdump-test.c
* subversion/tests/libsvn_subr/mergeinfo-test.c
* subversion/tests/libsvn_subr/subst_translate-test.c
* subversion/tests/libsvn_wc/conflict-data-test.c
* subversion/tests/libsvn_wc/op-depth-test.c
* subversion/tests/libsvn_wc/wc-test.c
* subversion/tests/svn_test_fs.c
* tools/server-side/fsfs-stats.c
  Move the svn_string_private.h include back to the original location.

Revision 1555133 - (view) (download) (annotate) - [select for diffs]
Modified Fri Jan 3 16:10:59 2014 UTC (10 years, 6 months ago) by rhuijben
File length: 46325 byte(s)
Diff to previous 1543477 (colored)
Get rid of the ever increasing number of private apis in svn_sorts.h by adding
a new private/svn_sorts_private.h file with the private parts and updating the
needed #include-s.
*AND*
Improve error reporting during xml parsing in ra_serf a bit.

For 1.9 the number of private apis in this public header more than doubled,
doubling the original filesize, while our policy is to never add private
functions in public headers.

* build.conf
  (libsvn_subr): Add export.

* subversion/include/private/svn_sorts_private.h
  New file, copied from ../svn_sorts.h.

* subversion/include/svn_sorts.h
  Remove everything possible in our private namespace. Keeping some
  references.

* subversion/libsvn_client/diff_local.c
* subversion/libsvn_client/import.c
* subversion/libsvn_client/info.c
* subversion/libsvn_client/list.c
* subversion/libsvn_client/merge.c
* subversion/libsvn_client/mergeinfo.c
* subversion/libsvn_client/status.c
* subversion/libsvn_delta/compat.c
* subversion/libsvn_fs_fs/cached_data.c
* subversion/libsvn_fs_fs/index.c
* subversion/libsvn_fs_fs/low_level.c
* subversion/libsvn_fs_fs/pack.c
* subversion/libsvn_fs_fs/temp_serializer.c
* subversion/libsvn_fs_fs/transaction.c
* subversion/libsvn_fs_x/index.c
* subversion/libsvn_fs_x/low_level.c
* subversion/libsvn_fs_x/pack.c
* subversion/libsvn_fs_x/transaction.c
* subversion/libsvn_ra/compat.c
* subversion/libsvn_ra_serf/inherited_props.c
* subversion/libsvn_ra_serf/lock.c
* subversion/libsvn_repos/dump.c
* subversion/libsvn_repos/fs-wrap.c
* subversion/libsvn_subr/cmdline.c
* subversion/libsvn_subr/hash.c
* subversion/libsvn_subr/mergeinfo.c
* subversion/libsvn_subr/sorts.c
* subversion/libsvn_wc/adm_ops.c
* subversion/libsvn_wc/diff_editor.c
* subversion/libsvn_wc/status.c
* subversion/libsvn_wc/wc_db.c
* subversion/libsvn_wc/wc_db_update_move.c
* subversion/mod_dav_svn/repos.c
* subversion/svn/log-cmd.c
* subversion/svn/propget-cmd.c
* subversion/svnadmin/svnadmin.c
* subversion/svnlook/svnlook.c
* subversion/tests/libsvn_subr/priority-queue-test.c
* subversion/tests/libsvn_wc/op-depth-test.c
  Fix includes.

* subversion/libsvn_ra_serf/util.c
  (expat_response_handler): Combine XML errors with our custom parser errors
    instead of only reporting one or the other.

Revision 1543477 - (view) (download) (annotate) - [select for diffs]
Modified Tue Nov 19 16:28:06 2013 UTC (10 years, 8 months ago) by julianfoad
File length: 46286 byte(s)
Diff to previous 1534953 (colored)
Use SVN_VA_NULL instead of plain NULL in variable-arguments lists in all
remaining cases, as far as I can discover, following r1536307 (introducing
SVN_VA_NULL) and r1543394 (warning about missing or inappropriate sentinels for
some Subersion functions).

[Lots of implementation files]: Replace NULL with SVN_VA_NULL in function
calls with variable argument lists.


Revision 1534953 - (view) (download) (annotate) - [select for diffs]
Modified Wed Oct 23 08:20:40 2013 UTC (10 years, 9 months ago) by brane
File length: 46265 byte(s)
Diff to previous 1534153 (colored)
Add an optional prefix parameter to the Windows-specific UTF-8 <-> UTF-16
conversion functions.

* subversion/include/private/svn_utf_private.h
  (svn_utf__win32_utf8_to_utf16, svn_utf__win32_utf16_to_utf8):
   Added prefix argument and updated docstrings.
* subversion/libsvn_subr/utf.c
  (svn_utf__win32_utf8_to_utf16, svn_utf__win32_utf16_to_utf8):
   Implemented prefix handling.
* subversion/bindings/javahl/native/JNIUtil.cpp,
  subversion/libsvn_subr/cmdline.c,
  subversion/libsvn_subr/config_win.c,
  subversion/libsvn_subr/nls.c: Updated all callers.


Revision 1534153 - (view) (download) (annotate) - [select for diffs]
Modified Mon Oct 21 13:46:21 2013 UTC (10 years, 9 months ago) by rhuijben
File length: 46259 byte(s)
Diff to previous 1534149 (colored)
Move the initialization of the platform specific ssl server certificate
initialization to svn_auth_get_platform_specific_client_providers().

* subversion/libsvn_subr/auth.c
  (svn_auth_get_platform_specific_client_providers): Move ssl server provider
    setup here..

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_create_auth_baton): ... that somehow stayed here when we moved
    the other providers some time ago.


Revision 1534149 - (view) (download) (annotate) - [select for diffs]
Modified Mon Oct 21 13:37:14 2013 UTC (10 years, 9 months ago) by rhuijben
File length: 47072 byte(s)
Diff to previous 1534118 (colored)
Extend the Windows CRYPTOAPI based ssl certificate verification to properly
handle intermediate authorities, like how webbrowsers handle this.

When I originally implemented the ssl server certificate verification, most
certificates were directly signed by the root authority while since then
most certificates moved to using short lived intermediate authorities.

This re-enables common cases like
$ svn info https://svn.apache.org/repos/asf/
to work directly on Windows, without an initial prompt for accepting a
certificate from an unknown authority, just like it worked a few years ago.

* subversion/include/private/svn_auth_private.h
  (SVN_AUTH_CRED_SSL_SERVER_AUTHORITY): Declare new credential type.
  (svn_auth__get_windows_ssl_server_authority_provider): New function.

* subversion/libsvn_ra_serf/util.c
  (includes): Add svn_auth_private.h.
  (ssl_server_cert): Instead of just recording authority failures call a
    new (optional) provider to allow

* subversion/libsvn_subr/auth.c
  (includes): Add svn_auth_private.h.
  (svn_auth_get_platform_specific_provider): Allow loading new provider.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_create_auth_baton): Hook new provider in the same place as
    where we hook the server certificate provider.

* subversion/libsvn_subr/win32_crypto.c
  (windows_ssl_server_trust_first_credentials): Fix an old bug, where instead
    of properly accepting a failure, we removed the failure where it was
    originally stored. (This happened to work in serf an neon for years)

  (windows_server_authority_provider): New variable.
  (svn_auth__get_windows_ssl_server_authority_provider): New function.


Revision 1534118 - (view) (download) (annotate) - [select for diffs]
Modified Mon Oct 21 12:08:32 2013 UTC (10 years, 9 months ago) by brane
File length: 46673 byte(s)
Diff to previous 1534039 (colored)
Move the new Win32-specific UTF-8 <-> UTF-16 conversion functions
to the svn_utf namespace.

* subversion/include/private/svn_subr_private.h
  (svn_subr__win32_utf8_to_utf16, svn_subr__win32_utf16_to_utf8):
   Move prototypes from here to ...
* subversion/include/private/svn_utf_private.h
  (svn_utf__win32_utf8_to_utf16, svn_utf__win32_utf16_to_utf8): ... here.

* subversion/libsvn_subr/win32_xlate.c
  (svn_subr__win32_utf8_to_utf16, svn_subr__win32_utf16_to_utf8):
   Move implementation from here to ...
* subversion/libsvn_subr/utf.c
  (svn_utf__win32_utf8_to_utf16, svn_utf__win32_utf16_to_utf8): ... here.

* subversion/bindings/javahl/native/JNIUtil.cpp,
  subversion/libsvn_subr/cmdline.c,
  subversion/libsvn_subr/config_win.c,
  subversion/libsvn_subr/nls.c: Update uses.
  Include svn_utf_private.h instead of svn_subr_private.h for
  svn_utf__win32_utf8_to_utf16 and svn_utf__win32_utf16_to_utf8.


Revision 1534039 - (view) (download) (annotate) - [select for diffs]
Modified Mon Oct 21 06:45:36 2013 UTC (10 years, 9 months ago) by brane
File length: 46712 byte(s)
Diff to previous 1533994 (colored)
Follow up to r1534037: Add missing include.

* subversion/libsvn_subr/cmdline.c: Do not include win32_xlate.h.
  Include private/svn_subr_private.h instead.


Revision 1533994 - (view) (download) (annotate) - [select for diffs]
Modified Sun Oct 20 21:35:23 2013 UTC (10 years, 9 months ago) by rhuijben
File length: 46699 byte(s)
Diff to previous 1530582 (colored)
Add a Windows specific svn_cmdline_puts() shortcut for the direct console
output case to avoid the insanely expensive double character conversion
in the Visual C++ CRT for this specific, but for Subversion very common case.

Before:                              VM/Network WC  Host
$ svn status -v trunk              = 7.5s           5.8s
$ svn status -v trunk > file       = 0.7s           0.1s

After:
$ svn status -v trunk              = 1.3s           0.4s
$ svn status -v trunk > file       = 0.7s           0.1s

(Measured on Windows 7, 8 and 8.1 with several CRT versions >= 2008)

When locales are explicitly enabled (such as in Subversion) the Visual
C++ CRT applies a double character conversion to make the console output
identical to what DOS and Win9X would do, while the console natively supports
displaying unicode. Instead of using the standard conversion route, this
shortcut converts our utf-8 to utf-16 and sends that to the attached console.

This patch avoids the extreme performance penalty and at the same time
enables displaying all unicode characters that the console support even
when they can't be expressed in the ansi character set.

Note that you will not see any change in the test suite, as the test suite
redirects all output. It will make subversion easier to profile though,
as before this patch many performance scenarios were console io bound on
Windows.

* subversion/libsvn_subr/cmdline.c
  (includes): Add conio.h on Windows. Add win32_xlate.
  (svn_cmdline_init): Detect if stdout and/or stderr are connected to the
    console.
  (svn_cmdline_fputs): Shortcut stdout/stderr to the console when possible.

* subversion/libsvn_subr/win32_xlate.c
  (includes): Add svn_private_config.h.
  (svn_subr__win32_utf8_to_utf16): New function.

* subversion/libsvn_subr/win32_xlate.h
  (svn_subr__win32_utf8_to_utf16): New function.


Revision 1530582 - (view) (download) (annotate) - [select for diffs]
Modified Wed Oct 9 12:34:11 2013 UTC (10 years, 9 months ago) by rhuijben
File length: 44271 byte(s)
Diff to previous 1522892 (colored)
Hide some essentially dead code by using the preprocessor.

* subversion/libsvn_subr/cmdline.c
  (CMDLINE_USE_CUSTOM_ENCODING): New macro. Document why this still exists.
  (input_encoding,
   output_encoding): Disable when CMDLINE_USE_CUSTOM_ENCODING is not defined.

  (svn_cmdline_init): Use CMDLINE_USE_CUSTOM_ENCODING as condition around
    initializing the encoding usage.

  (svn_cmdline_cstring_from_utf8,
   svn_cmdline_cstring_to_utf8,
   svn_cmdline_output_encoding): Use preprocessor instead of runtime check
    for the 99.9% case.


Revision 1522892 - (view) (download) (annotate) - [select for diffs]
Modified Fri Sep 13 12:12:58 2013 UTC (10 years, 10 months ago) by ivan
File length: 43924 byte(s)
Diff to previous 1508225 (colored)
Fix issue 4425 and issue 3014 on Windows. Treat ERROR_NO_DATA Windows 
error code as EPIPE error.

* subversion/include/svn_types.h
  (SVN__APR_STATUS_IS_EPIPE): New macro, same as APR_STATUS_IS_EPIPE with 
   additional handling of ERROR_NO_DATA on Windows.
* subversion/libsvn_subr/cmdline.c
* subversion/libsvn_subr/io.c
  (svn_cmdline_fputs, svn_cmdline_fflush, do_io_file_wrapper_cleanup): Use
   SVN__APR_STATUS_IS_EPIPE macro instead of APR_STATUS_IS_EPIPE.


Revision 1508225 - (view) (download) (annotate) - [select for diffs]
Modified Mon Jul 29 22:58:56 2013 UTC (10 years, 11 months ago) by stefan2
File length: 43914 byte(s)
Diff to previous 1506507 (colored)
Fix the #include order such that svn_private_config.h is always
included first before any other svn header - if we also include
svn_hash.h.

* subversion/bindings/javahl/native/org_apache_subversion_javahl_ConfigImpl_Category.cpp,
  subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c,
  subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c,
  subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c,
  subversion/libsvn_auth_gnome_keyring/gnome_keyring.c,
  subversion/libsvn_client/add.c,
  subversion/libsvn_client/cat.c,
  subversion/libsvn_client/changelist.c,
  subversion/libsvn_client/cleanup.c,
  subversion/libsvn_client/commit.c,
  subversion/libsvn_client/commit_util.c,
  subversion/libsvn_client/copy.c,
  subversion/libsvn_client/copy_foreign.c,
  subversion/libsvn_client/ctx.c,
  subversion/libsvn_client/delete.c,
  subversion/libsvn_client/deprecated.c,
  subversion/libsvn_client/diff.c,
  subversion/libsvn_client/diff_local.c,
  subversion/libsvn_client/diff_summarize.c,
  subversion/libsvn_client/export.c,
  subversion/libsvn_client/externals.c,
  subversion/libsvn_client/import.c,
  subversion/libsvn_client/info.c,
  subversion/libsvn_client/iprops.c,
  subversion/libsvn_client/list.c,
  subversion/libsvn_client/locking_commands.c,
  subversion/libsvn_client/log.c,
  subversion/libsvn_client/merge.c,
  subversion/libsvn_client/mergeinfo.c,
  subversion/libsvn_client/patch.c,
  subversion/libsvn_client/prop_commands.c,
  subversion/libsvn_client/ra.c,
  subversion/libsvn_client/repos_diff.c,
  subversion/libsvn_client/resolved.c,
  subversion/libsvn_client/revert.c,
  subversion/libsvn_client/status.c,
  subversion/libsvn_client/switch.c,
  subversion/libsvn_client/update.c,
  subversion/libsvn_client/util.c,
  subversion/libsvn_delta/compat.c,
  subversion/libsvn_delta/xdelta.c,
  subversion/libsvn_diff/parse-diff.c,
  subversion/libsvn_diff/util.c,
  subversion/libsvn_fs/access.c,
  subversion/libsvn_fs_base/bdb/changes-table.c,
  subversion/libsvn_fs_base/bdb/env.c,
  subversion/libsvn_fs_base/dag.c,
  subversion/libsvn_fs_base/fs.c,
  subversion/libsvn_fs_base/lock.c,
  subversion/libsvn_fs_base/revs-txns.c,
  subversion/libsvn_fs_base/tree.c,
  subversion/libsvn_fs_fs/caching.c,
  subversion/libsvn_fs_fs/fs_fs.c,
  subversion/libsvn_fs/fs-loader.c,
  subversion/libsvn_fs_fs/lock.c,
  subversion/libsvn_fs_fs/temp_serializer.c,
  subversion/libsvn_fs_fs/tree.c,
  subversion/libsvn_fs_util/fs-util.c,
  subversion/libsvn_ra/compat.c,
  subversion/libsvn_ra/deprecated.c,
  subversion/libsvn_ra_local/ra_plugin.c,
  subversion/libsvn_ra/ra_loader.c,
  subversion/libsvn_ra_serf/blame.c,
  subversion/libsvn_ra_serf/blncache.c,
  subversion/libsvn_ra_serf/commit.c,
  subversion/libsvn_ra_serf/getlocations.c,
  subversion/libsvn_ra_serf/getlocationsegments.c,
  subversion/libsvn_ra_serf/getlocks.c,
  subversion/libsvn_ra_serf/inherited_props.c,
  subversion/libsvn_ra_serf/log.c,
  subversion/libsvn_ra_serf/merge.c,
  subversion/libsvn_ra_serf/mergeinfo.c,
  subversion/libsvn_ra_serf/options.c,
  subversion/libsvn_ra_serf/property.c,
  subversion/libsvn_ra_serf/replay.c,
  subversion/libsvn_ra_serf/serf.c,
  subversion/libsvn_ra_serf/update.c,
  subversion/libsvn_ra_serf/util.c,
  subversion/libsvn_ra_serf/xml.c,
  subversion/libsvn_ra_svn/client.c,
  subversion/libsvn_ra_svn/editorp.c,
  subversion/libsvn_ra_svn/marshal.c,
  subversion/libsvn_repos/authz.c,
  subversion/libsvn_repos/commit.c,
  subversion/libsvn_repos/delta.c,
  subversion/libsvn_repos/deprecated.c,
  subversion/libsvn_repos/fs-wrap.c,
  subversion/libsvn_repos/hooks.c,
  subversion/libsvn_repos/log.c,
  subversion/libsvn_repos/replay.c,
  subversion/libsvn_repos/reporter.c,
  subversion/libsvn_repos/repos.c,
  subversion/libsvn_repos/rev_hunt.c,
  subversion/libsvn_subr/auth.c,
  subversion/libsvn_subr/cmdline.c,
  subversion/libsvn_subr/compat.c,
  subversion/libsvn_subr/config_auth.c,
  subversion/libsvn_subr/config.c,
  subversion/libsvn_subr/deprecated.c,
  subversion/libsvn_subr/dso.c,
  subversion/libsvn_subr/hash.c,
  subversion/libsvn_subr/io.c,
  subversion/libsvn_subr/mergeinfo.c,
  subversion/libsvn_subr/opt.c,
  subversion/libsvn_subr/properties.c,
  subversion/libsvn_subr/simple_providers.c,
  subversion/libsvn_subr/sorts.c,
  subversion/libsvn_subr/ssl_client_cert_providers.c,
  subversion/libsvn_subr/ssl_client_cert_pw_providers.c,
  subversion/libsvn_subr/ssl_server_trust_providers.c,
  subversion/libsvn_subr/subst.c,
  subversion/libsvn_subr/types.c,
  subversion/libsvn_subr/username_providers.c,
  subversion/libsvn_subr/utf.c,
  subversion/libsvn_subr/win32_crypto.c,
  subversion/libsvn_wc/adm_crawler.c,
  subversion/libsvn_wc/adm_files.c,
  subversion/libsvn_wc/adm_ops.c,
  subversion/libsvn_wc/conflicts.c,
  subversion/libsvn_wc/copy.c,
  subversion/libsvn_wc/deprecated.c,
  subversion/libsvn_wc/diff_editor.c,
  subversion/libsvn_wc/diff_local.c,
  subversion/libsvn_wc/entries.c,
  subversion/libsvn_wc/externals.c,
  subversion/libsvn_wc/info.c,
  subversion/libsvn_wc/lock.c,
  subversion/libsvn_wc/node.c,
  subversion/libsvn_wc/old-and-busted.c,
  subversion/libsvn_wc/props.c,
  subversion/libsvn_wc/revert.c,
  subversion/libsvn_wc/status.c,
  subversion/libsvn_wc/translate.c,
  subversion/libsvn_wc/update_editor.c,
  subversion/libsvn_wc/upgrade.c,
  subversion/libsvn_wc/wc_db.c,
  subversion/libsvn_wc/wc_db_update_move.c,
  subversion/libsvn_wc/wc_db_wcroot.c,
  subversion/libsvn_wc/workqueue.c,
  subversion/mod_dav_svn/activity.c,
  subversion/mod_dav_svn/deadprops.c,
  subversion/mod_dav_svn/lock.c,
  subversion/mod_dav_svn/merge.c,
  subversion/mod_dav_svn/mod_dav_svn.c,
  subversion/mod_dav_svn/reports/update.c,
  subversion/mod_dav_svn/repos.c,
  subversion/mod_dav_svn/version.c,
  subversion/svnadmin/svnadmin.c,
  subversion/svnauth/svnauth.c,
  subversion/svn/cl-conflicts.c,
  subversion/svn/commit-cmd.c,
  subversion/svn/conflict-callbacks.c,
  subversion/svn/diff-cmd.c,
  subversion/svn/help-cmd.c,
  subversion/svnlook/svnlook.c,
  subversion/svnmucc/svnmucc.c,
  subversion/svn/notify.c,
  subversion/svn/propedit-cmd.c,
  subversion/svn/propget-cmd.c,
  subversion/svn/props.c,
  subversion/svnrdump/dump_editor.c,
  subversion/svnrdump/svnrdump.c,
  subversion/svnrdump/util.c,
  subversion/svnserve/serve.c,
  subversion/svn/status.c,
  subversion/svn/status-cmd.c,
  subversion/svn/svn.c,
  subversion/svnsync/svnsync.c,
  subversion/svnsync/sync.c,
  subversion/svn/util.c,
  subversion/tests/libsvn_fs/fs-test.c,
  subversion/tests/libsvn_repos/repos-test.c,
  subversion/tests/libsvn_subr/hashdump-test.c,
  subversion/tests/libsvn_subr/mergeinfo-test.c,
  subversion/tests/libsvn_subr/subst_translate-test.c,
  subversion/tests/libsvn_wc/conflict-data-test.c,
  subversion/tests/libsvn_wc/op-depth-test.c,
  subversion/tests/libsvn_wc/wc-test.c,
  subversion/tests/svn_test_fs.c,
  tools/dev/fsfs-reorg.c,
  tools/server-side/fsfs-stats.c): #include svn_private_config.h first

Revision 1506507 - (view) (download) (annotate) - [select for diffs]
Modified Wed Jul 24 12:00:51 2013 UTC (11 years ago) by ivan
File length: 43915 byte(s)
Diff to previous 1482350 (colored)
On Windows add SVN_CMDLINE_DISABLE_CRASH_HANDLER environment variable to 
disable crash handler. Useful for debugging crashing command line client.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): Do not set crash handler if
   SVN_CMDLINE_DISABLE_CRASH_HANDLER environment variable set.


Revision 1482350 - (view) (download) (annotate) - [select for diffs]
Modified Tue May 14 14:43:49 2013 UTC (11 years, 2 months ago) by rhuijben
File length: 43776 byte(s)
Diff to previous 1467191 (colored)
Swap the argument order of svn_utf_initialize2() in its definition and all its
callers to follow our standard ordering rules.

* subversion/include/svn_utf.h
  (svn_utf_initialize2): Reorder arguments.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): Update caller.

* subversion/libsvn_subr/deprecated.c
  (svn_utf_initialize): Update caller.

* subversion/libsvn_subr/utf.c
  (svn_utf_initialize2): Update argument order.

* subversion/mod_dav_svn/mod_dav_svn.c
  (init): Update caller.


Revision 1467191 - (view) (download) (annotate) - [select for diffs]
Modified Fri Apr 12 07:44:37 2013 UTC (11 years, 3 months ago) by rhuijben
File length: 43776 byte(s)
Diff to previous 1461690 (colored)
* **/**
  Run tools/dev/remove-trailing-whitespace.sh to remove all trailing whitespace
  before we branch 1.8, like we did before creating previous branches.

  No functional changes.


Revision 1461690 - (view) (download) (annotate) - [select for diffs]
Modified Wed Mar 27 16:19:11 2013 UTC (11 years, 4 months ago) by rhuijben
File length: 43777 byte(s)
Diff to previous 1460163 (colored)
* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): Hook a few more error types to stderr in debug mode.


Revision 1460163 - (view) (download) (annotate) - [select for diffs]
Modified Sat Mar 23 14:35:40 2013 UTC (11 years, 4 months ago) by danielsh
File length: 43659 byte(s)
Diff to previous 1431017 (colored)
Use svn_hash_gets and svn_hash_sets.

* subversion/libsvn_subr/auth.c
* subversion/libsvn_subr/cmdline.c
* subversion/libsvn_subr/compat.c
* subversion/libsvn_subr/config.c
* subversion/libsvn_subr/config_auth.c
* subversion/libsvn_subr/deprecated.c
* subversion/libsvn_subr/dso.c
* subversion/libsvn_subr/hash.c
* subversion/libsvn_subr/io.c
* subversion/libsvn_subr/mergeinfo.c
* subversion/libsvn_subr/opt.c
* subversion/libsvn_subr/properties.c
* subversion/libsvn_subr/simple_providers.c
* subversion/libsvn_subr/ssl_client_cert_providers.c
* subversion/libsvn_subr/ssl_client_cert_pw_providers.c
* subversion/libsvn_subr/ssl_server_trust_providers.c
* subversion/libsvn_subr/subst.c
* subversion/libsvn_subr/types.c
* subversion/libsvn_subr/username_providers.c
* subversion/libsvn_subr/utf.c
* subversion/libsvn_subr/win32_crypto.c
* subversion/libsvn_subr/xml.c


Revision 1431017 - (view) (download) (annotate) - [select for diffs]
Modified Wed Jan 9 19:24:52 2013 UTC (11 years, 6 months ago) by stefan2
File length: 43711 byte(s)
Diff to previous 1425125 (colored)
Coding style patch: in logical expressions, instead of comparing
with arithmetic constants use boolean operations. I.e. replace

<expr> == TRUE with <expr>  and
<expr> == FALSE with !<expr>

* subversion/libsvn_delta/svndiff.c
  (send_simple_insertion_window,
   window_handler): change condition style
* subversion/libsvn_fs_base/fs.c
  (svn_fs_base__clean_logs): ditto
* subversion/libsvn_fs_fs/fs_fs.c
  (representation_string,
   create_rep_state_body, 
   build_rep_list): ditto
* subversion/libsvn_ra_serf/locks.c
  (handle_lock): ditto
* subversion/libsvn_ra_serf/property.c
  (create_propfind_body): same here,
* subversion/libsvn_ra_serf/update.c
  (cancel_fetch, 
   handle_fetch,
   end_report,
   finish_report): here,
* subversion/libsvn_ra_serf/util.c
  (svn_ra_serf__handle_xml_parser): here,
* subversion/libsvn_ra_svn/client.c
  (optbool_to_tristate): here, 
* subversion/libsvn_repos/authz.c
  (authz_parse_section): and here.
* subversion/libsvn_repos/fs-wrap.c
  (svn_repos__validate_prop): here as well
* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_create_auth_baton): and here
* subversion/libsvn_subr/deprecated.c
  (print_command_info): here
* subversion/libsvn_subr/opt.c
  (print_command_info2): more of the same
* subversion/libsvn_subr/subst.c
  (translate_chunk): ditto
* subversion/libsvn_subr/win32_crashrpt.c
  (write_var_values,
   svn__unhandled_exception_filter): ditto
* subversion/svn/svn.c
  (sub_main): ditto
* subversion/svnsync/svnsync.c
  (filter_props): and more of the
* subversion/tests/libsvn_subr/stream-test.c
  (test_readonly): same thing
* subversion/tests/libsvn_subr/string-test.c
  (test21): ditto
* subversion/tests/libsvn_subr/subst_translate-test.c
  (test_svn_subst_translate_string2_null_encode): here
* subversion/tests/libsvn_wc/db-test.c
  (test_getting_info,
   test_working_info): and here
* tools/client-side/svn-bench/svn-bench.c
  (sub_main): and finally here

Revision 1425125 - (view) (download) (annotate) - [select for diffs]
Modified Fri Dec 21 20:14:27 2012 UTC (11 years, 7 months ago) by cmpilato
File length: 43735 byte(s)
Diff to previous 1424655 (colored)
Move some fairly useful utility functions from the command-line client
to libsvn_subr, exposing as private svn_cmdline__ APIs.

* subversion/include/private/svn_cmdline_private.h
  (svn_cmdline__edit_file_externally,
   svn_cmdline__edit_string_externally): Rename and move here ...

* subversion/svn/cl.h
  (svn_cl__edit_file_externally, svn_cl__edit_string_externally):
     ... from here.  Callers updated.

* subversion/libsvn_subr/cmdline.c
  (find_editor_binary, svn_cmdline__edit_file_externally,
   svn_cmdline__edit_string_externally): Rename and move here ...

* subversion/svn/util.c
  (find_editor_binary, svn_cl__edit_file_externally,
   svn_cl__edit_string_externally): ... from here.  Callers updated.

* subversion/svn/conflict-callbacks.c,
* subversion/svn/file-merge.c,
* subversion/svn/propedit-cmd.c
  Track function renames.


Revision 1424655 - (view) (download) (annotate) - [select for diffs]
Modified Thu Dec 20 20:04:03 2012 UTC (11 years, 7 months ago) by stsp
File length: 31702 byte(s)
Diff to previous 1424037 (colored)
Factor out common code from svn, svnsync, and svnrdump into the cmdline.c file.
No functional change.

* subversion/include/svn_cmdline.h
  (svn_cmdline__stdin_isatty): Remove.
  (svn_cmdline__be_interactive): Declare.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline__be_interactive): New function, based on the former
   svn_cmdline__stdin_isatty() function, which determines whether a
   command line tool should be interactive.

* subversion/svn/svn.c
  (sub_main): Call svn_cmdline__be_interactive() and remove corresponding
   inline logic.

* subversion/svnrdump/svnrdump.c
  (main): As previous.

* subversion/svnsync/svnsync.c
  (main): As previous.


Revision 1424037 - (view) (download) (annotate) - [select for diffs]
Modified Wed Dec 19 19:12:43 2012 UTC (11 years, 7 months ago) by stsp
File length: 31292 byte(s)
Diff to previous 1416637 (colored)
Add a new function to the cmdline library to determine whether standard
input is connected to a terminal device, and set the --non-interactive
option if standard input is not connected to a terminal device.

The idea is to make 'svn' non-interactive by default if run from scripts
which are launched in some unattended automated fashion. In such a situation
it is possible for scripts to hang if 'svn' decides to prompt for information
such as login credentials or conflict resolution options.

Also add a new --force-interactive option which enforces the old behaviour.

* subversion/include/svn_cmdline.h
  (svn_cmdline__stdin_isatty): Declare.

* subversion/libsvn_subr/cmdline.c: Include io.h on Windows.
  (svn_cmdline__stdin_isatty): New.

* subversion/svn/cl.h
  (svn_cl__opt_state_t): Add force_interactive option.

* subversion/svn/svn.c
  (svn_cl__longopt_t): Add opt_force_interactive.
  (sub_main): Set the --non-interactive option based on whether stdin is a tty,
   unless interactive mode has been forced with --force-interactive.
   Enforce mutual exclusion of --non-interactive and --force-interactive.

* subversion/tests/cmdline/getopt_tests_data/svn_help_log_switch_stdout: Adjust.

* subversion/tests/cmdline/update_tests.py
  (eof_in_interactive_conflict_resolver): Pass --force-interactive to ensure
   the interactive conflict resolver will be run as expected.


Revision 1416637 - (view) (download) (annotate) - [select for diffs]
Modified Mon Dec 3 18:52:24 2012 UTC (11 years, 7 months ago) by pburba
File length: 31067 byte(s)
Diff to previous 1395109 (colored)
Add --show-inherited-props support to 'svnlook propget' and
'svnlook proplist' and '--verbose' support to 'svnlook propget'.

The output of these new options now mimics the output of 'svn pl' and
'svn pg' with the same options.  The only change to *existing* 1.7 behavior
is for 'svnlook pl' and 'svnlook pl -v', which now mimics 'svn pl' and
'svn pl -v':

  Old:

    >svnlook pl autoprop_tests-30 /
      svn:auto-props

    >svnlook pl autoprop_tests-30 / -v
      svn:auto-props : *.h=svn:eol-style=native

  New:

    >svnlook pl autoprop_tests-30 /
    Properties on '/':
      svn:auto-props

    >svnlook pl autoprop_tests-30 /  -v
    Properties on '/':
      svn:auto-props
        *.h=svn:eol-style=native

See http://svn.haxx.se/dev/archive-2012-11/0508.shtml and
http://svn.haxx.se/dev/archive-2012-11/0510.shtml

* subversion/include/svn_repos.h

  (svn_repos_fs_get_inherited_props): Add a new argument signaling retrieval
   of only a particular property.

* subversion/libsvn_repos/fs-wrap.c

  (svn_repos_fs_get_inherited_props): Implement new argument.

* subversion/libsvn_ra_local/ra_plugin.c
  (get_node_props):
* subversion/mod_dav_svn/reports/inherited-props.c
  (dav_svn__get_inherited_props_report):
* subversion/svnserve/serve.c
  (get_props):
  Update calls to svn_repos_fs_get_inherited_props() to account for new
  argument.

* subversion/svn/cl.h

  (svn_cl__print_prop_hash,
   svn_cl__print_xml_commit,
   svn_cl__indent_string): Renamed and moved to svn_cmdline_private.h

* subversion/include/private/svn_cmdline_private.h

  (svn_cmdline__indent_string,
   svn_cmdline__print_prop_hash,
   svn_cmdline__print_xml_prop_hash): New.  Moved here from cl.h.

* subversion/svn/props.c

  (svn_cl__print_prop_hash,
   svn_cl__print_xml_prop_hash): Renamed and moved these implementations to
   subversion/libsvn_subr/cmdline.c.

* subversion/svn/util.c

  (next_line,
   svn_cl__indent_string): Renamed and moved these implementations to
   subversion/libsvn_subr/cmdline.c.

* subversion/libsvn_subr/cmdline.c

  (next_line,
   svn_cmdline__indent_string): New.  Renamed and moved here from
   subversion/svn/util.c.

  (svn_cmdline__print_prop_hash,
   svn_cmdline__print_xml_prop_hash): New.  Renamed and moved here from
   subversion/svn/props.c. 

* subversion/svn/log-cmd.c
  (log_entry_receiver_xml):
* subversion/svn/propget-cmd.c
  (print_single_prop):
* subversion/svn/proplist-cmd.c
  (proplist_receiver_xml,
   proplist_receiver,
   svn_cl__proplist):
  Account for svn_cl__* --> svn_cmdline__* renamed functions.

* subversion/svnlook/svnlook.c

  (svnlook__show_inherited_props): New enum for --show-inherited-props
   option.

  (options_table): New help line for --show-inherited-props.

  (cmd_table): Add '-v' and '--show-inherited-props' options to
   'svnlook propget'.  Add '--show-inherited-props' option to
   'svnlook proplist'.

  (svnlook_opt_state): Add member to track --show-inherited-props.

  (stream_write):

  (do_pget): Add new arguments corresponding to the --verbose and
   --show-inherited-props options. 

  (do_plist): Remove comment about returning SVN_ERR_PROPERTY_NOT_FOUND
   if no properties are found, we haven't done that ever for proplist,
   it appears to simply be a copy & paste typo from way back in r845574.
   Add new argument corresponding to the --show-inherited-props option. 

  (subcommand_pget): Update call to do_plist() and do_pget().

  (main): Handle --show-inherited-props.  Raise an error if --revprop and
   --show-inherited-props options are used together.

* subversion/svnserve/serve.c
  (get_props): Update caller.

* subversion/tests/cmdline/svnlook_tests.py

  (output_command): Adjust test expectations to account for change in default
   output of .svnlook pl'.

* tools/client-side/svn-bench/cl.h

  (svn_cl__print_prop_hash): Remove declaration.  No need to rename to
   svn_cmdline__print_prop_hash, as it was no longer referenced in
   tools\client-side\svn-bench.


Revision 1395109 - (view) (download) (annotate) - [select for diffs]
Modified Sat Oct 6 16:40:55 2012 UTC (11 years, 9 months ago) by pburba
File length: 25705 byte(s)
Diff to previous 1382028 (colored)
Merge the inheritable-props branch back to trunk.

See http://svn.haxx.se/dev/archive-2012-09/0177.shtml

Revision 1382028 - (view) (download) (annotate) - [select for diffs]
Modified Fri Sep 7 13:53:05 2012 UTC (11 years, 10 months ago) by cmpilato
File length: 25552 byte(s)
Diff to previous 1295006 (colored)
Finish issue #2410 ("Allow client to avoid SSL certificate prompts").
This adds a runtime configuration knob for explicitly enabling and
disabling the client certificate path prompt provider.

* subversion/include/svn_config.h
  (SVN_CONFIG_OPTION_SSL_CLIENT_CERT_FILE_PROMPT): New #define.

* subversion/libsvn_subr/config_file.c
  (svn_config_ensure): Add configuration templatry for the new
    'ssl-client-cert-file-prompt' option.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_create_auth_baton): Check the runtime configuration to
    see if we're allowed to prompt for client certificate paths, and
    add the provider which does so only if that is, in fact, allowed.

NOTE: I don't know if "templatry" (used above) is a real word or not,
      but I rather like it.  -- cmpilato

Patch by: kfogel
          (Tweaked by me.)


Revision 1295006 - (view) (download) (annotate) - [select for diffs]
Modified Wed Feb 29 08:22:01 2012 UTC (12 years, 4 months ago) by danielsh
File length: 25114 byte(s)
Diff to previous 1239203 (colored)
Revert r1295004, which contained numerous accidental changes.

[ This was an svnmucc commit that replaced trunk@HEAD with
trunk@r1295003.  See r1295004 for the exact changes reverted. ]


Revision 1239203 - (view) (download) (annotate) - [select for diffs]
Modified Wed Feb 1 16:58:50 2012 UTC (12 years, 5 months ago) by stsp
File length: 25114 byte(s)
Diff to previous 1190623 (colored)
For issue #2487, "mod_dav_svn and locales fail to play nicely together",
add a new configuration option which allows Subversion libraries called
from mod_dav_svn to process UTF-8 strings, instead of just ASCII strings.

Because httpd is not locale-aware, we cannot assume that a native character
set other than ASCII is present in the environment that mod_dav_svn runs in.
UTF-8 is backward compatible to ASCII, and all paths within Subversion
repositories are already encoded in UTF-8. Thus, we can safely allow UTF-8
without running into character set conversion issues in code called from
mod_dav_svn.

Basic testing shows that httpd is prepared to tolerate non-ASCII characters,
even though it doesn't seem to interpret them. E.g. it logs such characters
as hex codes preceded by a backslash.

The new configuration option is called SVNUseUTF8 and can be set to
"On" or "Off" (the default is "Off"). It is a global option that takes
effect for all repository locations defined in the configuration file.

When the option is "On", files that contain UTF-8 characters in their
names can be processed by the pre-lock hook, hooks are able to write
UTF-8 characters to stdout and stderr, and filesystem paths to Subversion
repositories may contain UTF-8 characters.

* subversion/mod_dav_svn/mod_dav_svn.c
  (server_conf_t): Add use_utf8 boolean.
  (init): Initialise the native character set of Subversion's UTF-8
   conversion routines to either ASCII (default) or UTF-8.
  (SVNUseUTF8_cmd): New option command processor.
  (cmds): Add new "SVNUseUTF8" option.

* subversion/include/svn_utf.h
  (svn_utf_initialize2): Declare. Includes the ablity to force the native
   character set to UTF-8, regardless of locale.
  (svn_utf_initialize): Deprecate.

* subversion/libsvn_subr/deprecated.c
  (svn_utf_initialize): Re-implement as wrapper around svn_utf_initialize2().

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): Update funtion call to svn_utf_initialize2(), keeping
   the native character set based on the current locale.

* subversion/libsvn_subr/utf.c
  (svn_utf_initialize2): New.
  (assume_native_charset_is_utf8): New global boolean variable. Defaults
   to FALSE, and may be set to TRUE by svn_utf_initialize2() (which, like
   its predecessor, is documented to not be thread-safe).
  (get_ntou_xlate_handle_node, get_uton_xlate_handle_node): If the native
   character set has been forced to UTF-8, use SVN_APR_UTF8_CHARSET instead
   of SVN_APR_LOCALE_CHARSET.


Revision 1190623 - (view) (download) (annotate) - [select for diffs]
Modified Fri Oct 28 22:09:51 2011 UTC (12 years, 9 months ago) by stefan2
File length: 25106 byte(s)
Diff to previous 1182679 (colored)
Reintegrate integrate-string-improvements branch into /trunk.

Revision 1182679 - (view) (download) (annotate) - [select for diffs]
Modified Thu Oct 13 06:28:15 2011 UTC (12 years, 9 months ago) by danielsh
File length: 25104 byte(s)
Diff to previous 1182513 (colored)
Follow-up to r1182513:

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): Add a text pointer to a more detailed explanation.

Revision 1182513 - (view) (download) (annotate) - [select for diffs]
Modified Wed Oct 12 18:30:04 2011 UTC (12 years, 9 months ago) by philip
File length: 25064 byte(s)
Diff to previous 1160604 (colored)
* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): Use standard function for better error reporting,
   tweak comment about DSO lifetime.


Revision 1160604 - (view) (download) (annotate) - [select for diffs]
Modified Tue Aug 23 10:16:07 2011 UTC (12 years, 11 months ago) by philip
File length: 24778 byte(s)
Diff to previous 1151068 (colored)
* subversion/libsvn_ra_svn/cyrus_auth.c
  subversion/libsvn_subr/cmdline.c: Remove unnecessary apr_atomic.h includes.


Revision 1151068 - (view) (download) (annotate) - [select for diffs]
Modified Tue Jul 26 12:09:32 2011 UTC (13 years ago) by stsp
File length: 24836 byte(s)
Diff to previous 1133032 (colored)
* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_create_auth_baton): Convert 'space-before-paren' formatting
    to 'no-space-before-paren' as per our coding style guidelines.


Revision 1133032 - (view) (download) (annotate) - [select for diffs]
Modified Tue Jun 7 14:45:59 2011 UTC (13 years, 1 month ago) by julianfoad
File length: 24791 byte(s)
Diff to previous 1087533 (colored)
Add a missing #include of svn_version.h, following r1132966, and remove it
where it is unused.

* subversion/libsvn_subr/auth.c
  Add a missing #include of svn_version.h (needed when compiled with support
  for Gnome keyring or KDE Wallet).

* subversion/libsvn_ra_serf/blame.c,
  subversion/libsvn_ra_serf/commit.c,
  subversion/libsvn_ra_serf/getdate.c,
  subversion/libsvn_ra_serf/getlocations.c,
  subversion/libsvn_ra_serf/getlocks.c,
  subversion/libsvn_ra_serf/locks.c,
  subversion/libsvn_ra_serf/log.c,
  subversion/libsvn_ra_serf/merge.c,
  subversion/libsvn_ra_serf/options.c,
  subversion/libsvn_ra_serf/replay.c,
  subversion/libsvn_ra_serf/update.c,
  subversion/libsvn_ra_serf/xml.c,
  subversion/libsvn_subr/cmdline.c,
  subversion/tests/libsvn_subr/checksum-test.c
    Remove unused #include of svn_version.h.


Revision 1087533 - (view) (download) (annotate) - [select for diffs]
Modified Fri Apr 1 01:01:22 2011 UTC (13 years, 3 months ago) by stsp
File length: 24816 byte(s)
Diff to previous 1086936 (colored)
stats++

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_fputs): kill space-before-paren


Revision 1086936 - (view) (download) (annotate) - [select for diffs]
Modified Wed Mar 30 12:49:39 2011 UTC (13 years, 4 months ago) by stsp
File length: 24827 byte(s)
Diff to previous 1086607 (colored)
* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_fputs, svn_cmdline_fflush): Don't needlessly create an error
   and destroy it. For portability, use apr_get_os_error() instead of
   referencing errno directly.

Suggested by: danielsh
              rhuijben


Revision 1086607 - (view) (download) (annotate) - [select for diffs]
Modified Tue Mar 29 14:46:38 2011 UTC (13 years, 4 months ago) by stsp
File length: 24940 byte(s)
Diff to previous 930239 (colored)
Fix issue #3014, "svn log | head" should not print "Write error: Broken pipe".

Make svn and other commands exit silently (with EXIT_FAILURE) if a pipe write
error occured. The rationale being that the process closing the pipe is also
responsible for printing a related error message, if necessary.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_fputs, svn_cmdline_fflush): Return
   SVN_ERR_IO_PIPE_WRITE_ERROR when writes fail due to EPIPE, so that
   callers can choose to ignore this kind of error.
  (svn_cmdline_handle_exit_error): Don't print message for pipe write errors.

* subversion/libsvn_subr/io.c
  (do_io_file_wrapper_cleanup): Return SVN_ERR_IO_PIPE_WRITE_ERROR when writes
   fail due to EPIPE.

* subversion/libsvn_subr/opt.c
  (svn_opt_print_generic_help2): Don't print message for pipe write errors.

* subversion/svn/notify.c
  (notify): Same.

* subversion/svn/main.c
  (main): Same.

* subversion/svn/obliterate-cmd.c
  (notify): Same.

* subversion/svnadmin/main.c
  (main): Same.

* subversion/include/svn_error_codes.h
  (SVN_ERR_IO_PIPE_WRITE_ERROR): New error code.


Revision 930239 - (view) (download) (annotate) - [select for diffs]
Modified Fri Apr 2 11:16:39 2010 UTC (14 years, 3 months ago) by rhuijben
File length: 23730 byte(s)
Diff to previous 930191 (colored)
Following up upon r930191, also redirect CRT messages to STDERR
on Windows when compiling in _DEBUG modes, to allow continuing the
testsuite on this class of errors.

* subversion/libsvn_subr/cmdline.c
  (includes): Include crtdbg.h on Windows.
  (svn_cmdline_init): Set all crt error handlers to log to stderr and the
     debugger instead of to a dialog.


Revision 930191 - (view) (download) (annotate) - [select for diffs]
Modified Fri Apr 2 09:00:00 2010 UTC (14 years, 3 months ago) by rhuijben
File length: 23209 byte(s)
Diff to previous 922239 (colored)
* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): On Windows disable the abort dialog from the Visual
    C++ runtime for our commandline tools, by redirecting the information
    to stderr. This allows the testsuite to continue without user
    interaction after all exceptions.


Revision 922239 - (view) (download) (annotate) - [select for diffs]
Modified Fri Mar 12 12:36:23 2010 UTC (14 years, 4 months ago) by julianfoad
File length: 22782 byte(s)
Diff to previous 880911 (colored)
Add "const" to all "apr_array_header_t *" input parameters in public and
private APIs.

(Note that we are allowed to add "const" to a pointer parameter of a public
API, and have done so before, because that is a backward-compatible API
change and doesn't change the ABI at all.)

The public functions whose prototypes are changed are listed individually
below; the private functions are not.

* subversion/include/svn_auth.h
  (svn_auth_open)

* subversion/include/svn_client.h
  (svn_client_get_commit_log_t,
   svn_client_copy5,
   svn_client_copy4,
   svn_client_move5,
   svn_client_patch)

* subversion/include/svn_delta.h
  (svn_delta_path_driver,
   svn_file_rev_handler_t,
   svn_file_rev_handler_old_t)

* subversion/include/svn_fs.h
  (svn_fs_change_txn_props)

* subversion/include/svn_mergeinfo.h
  (svn_rangelist_diff,
   svn_rangelist_merge,
   svn_rangelist_remove,
   svn_rangelist_intersect,
   svn_rangelist_inheritable2,
   svn_rangelist_inheritable,
   svn_rangelist_dup)

* subversion/include/svn_opt.h
  (svn_opt_args_to_target_array3,
   svn_opt_args_to_target_array2,
   svn_opt_args_to_target_array,
   svn_opt_eat_peg_revisions)

* subversion/include/svn_ra.h
  (svn_ra_file_rev_handler_t,
   svn_ra_get_locations,
   svn_ra_plugin_t.get_locations)

* subversion/include/svn_ra_svn.h
  (svn_ra_svn_command_handler,
   svn_ra_svn_set_capabilities,
   svn_ra_svn_parse_tuple,
   svn_ra_svn_parse_proplist)

* subversion/include/svn_repos.h
  (svn_repos_file_rev_handler_t,
   svn_repos_trace_node_locations,
   svn_repos_fs_get_mergeinfo,
   svn_repos_fs_change_txn_props,
   svn_repos_remember_client_capabilities)

* subversion/include/svn_sorts.h
  (svn_sort__bsearch_lower_bound)

* subversion/include/svn_string.h
  (svn_cstring_match_glob_list)

* subversion/include/svn_wc.h
  (svn_wc_get_status_editor3,
   svn_wc_get_update_editor4,
   svn_wc_get_update_editor3,
   svn_wc_get_switch_editor4,
   svn_wc_get_switch_editor3,
   svn_wc_match_ignore_list)

* subversion/include/private/svn_cmdline_private.h
* subversion/include/private/svn_opt_private.h
* subversion/libsvn_client/blame.c
* subversion/libsvn_client/client.h
* subversion/libsvn_client/commit.c
* subversion/libsvn_client/commit_util.c
* subversion/libsvn_client/copy.c
* subversion/libsvn_client/deprecated.c
* subversion/libsvn_client/merge.c
* subversion/libsvn_client/mergeinfo.c
* subversion/libsvn_client/mergeinfo.h
* subversion/libsvn_client/patch.c
* subversion/libsvn_client/ra.c
* subversion/libsvn_delta/compat.c
* subversion/libsvn_delta/path_driver.c
* subversion/libsvn_fs_base/reps-strings.c
* subversion/libsvn_fs_base/revs-txns.c
* subversion/libsvn_fs_base/revs-txns.h
* subversion/libsvn_fs_fs/fs_fs.c
* subversion/libsvn_fs_fs/fs_fs.h
* subversion/libsvn_fs/fs-loader.c
* subversion/libsvn_fs/fs-loader.h
* subversion/libsvn_ra/compat.c
* subversion/libsvn_ra/ra_loader.c
* subversion/libsvn_ra/ra_loader.h
* subversion/libsvn_ra/wrapper_template.h
* subversion/libsvn_ra_local/ra_plugin.c
* subversion/libsvn_ra_neon/get_locations.c
* subversion/libsvn_ra_neon/props.c
* subversion/libsvn_ra_neon/ra_neon.h
* subversion/libsvn_ra_serf/getlocations.c
* subversion/libsvn_ra_serf/ra_serf.h
* subversion/libsvn_ra_svn/client.c
* subversion/libsvn_ra_svn/cyrus_auth.c
* subversion/libsvn_ra_svn/editorp.c
* subversion/libsvn_ra_svn/internal_auth.c
* subversion/libsvn_ra_svn/marshal.c
* subversion/libsvn_ra_svn/ra_svn.h
* subversion/libsvn_repos/fs-wrap.c
* subversion/libsvn_repos/log.c
* subversion/libsvn_repos/repos.c
* subversion/libsvn_repos/repos.h
* subversion/libsvn_repos/rev_hunt.c
* subversion/libsvn_subr/auth.c
* subversion/libsvn_subr/cmdline.c
* subversion/libsvn_subr/deprecated.c
* subversion/libsvn_subr/mergeinfo.c
* subversion/libsvn_subr/opt.c
* subversion/libsvn_subr/sorts.c
* subversion/libsvn_subr/svn_string.c
* subversion/libsvn_wc/adm_ops.c
* subversion/libsvn_wc/deprecated.c
* subversion/libsvn_wc/diff.c
* subversion/libsvn_wc/status.c
* subversion/libsvn_wc/update_editor.c
* subversion/libsvn_wc/util.c
* subversion/mod_dav_svn/dav_svn.h
* subversion/mod_dav_svn/reports/file-revs.c
* subversion/mod_dav_svn/util.c
* subversion/svn/cl.h
* subversion/svn/props.c
* subversion/svn/switch-cmd.c
* subversion/svn/util.c
* subversion/svndumpfilter/main.c
* subversion/svnserve/serve.c
* subversion/tests/libsvn_repos/repos-test.c
* subversion/tests/libsvn_subr/mergeinfo-test.c



Revision 880911 - (view) (download) (annotate) - [select for diffs]
Modified Mon Nov 16 19:07:17 2009 UTC (14 years, 8 months ago) by hwright
File length: 22776 byte(s)
Diff to previous 880443 (colored)
Test out my new and fancy ASF commit priviledges by changing the copyright
wording in our license headers to reflect ownership by the ASF.

* NOTICE:
  Change terminology to ASF, and update a link.

* subversion/libsvn_subr/opt.c
  (svn_opt__print_version_info): Note that the product as a whole is
    copyrighted by the ASF, and update the project website.

* everywhere:
  Change license text to reflect ASF ownership.


Revision 880443 - (view) (download) (annotate) - [select for diffs]
Modified Wed Nov 4 05:50:12 2009 UTC (14 years, 8 months ago) by hwright
File length: 22784 byte(s)
Diff to previous 878444 (colored)
Scrub trailing whitespace throughout (see r35894).


Revision 878444 - (view) (download) (annotate) - [select for diffs]
Modified Tue Jul 7 22:03:10 2009 UTC (15 years ago) by hwright
File length: 22786 byte(s)
Diff to previous 878384 (colored)
Relicense Subversion under the Apache License, Version 2.0.

* NOTICE: New.

* LICENSE: New.

* COPYING,
  subversion/LICENSE: Remove.

* subversion/libsvn_subr/opt.c
  (svn_opt__print_version_info): Note that the product as a whole is
    copyrighted by the SVN Corp, and that it contains contributions from
    many people, as referenced in NOTICE.

* subversion/bindings/swig/python/LICENSE_FOR_PYTHON_BINDINGS:
  Relicense the SVN parts under Apache 2.0.

* everywhere:
  Change copyright notices in file headers to reflect the Apache 2.0 license.


Revision 878384 - (view) (download) (annotate) - [select for diffs]
Modified Thu Jul 2 17:11:37 2009 UTC (15 years ago) by hwright
File length: 22517 byte(s)
Diff to previous 877554 (colored)
Fix yet more deprecation warnings with svn_path_local_style().

(Does it never end?!?)

* subversion/libsvn_ra/compat.c,
  subversion/libsvn_ra/util.c,
  subversion/libsvn_subr/subst.c,
  subversion/libsvn_subr/cmdline.c,
  subversion/libsvn_subr/opt.c,
  subversion/libsvn_subr/dirent_uri.c,
  subversion/libsvn_subr/path.c,
  subversion/svnadmin/main.c,
  subversion/libsvn_ra_serf/util.c,
  subversion/libsvn_ra_serf/commit.c:
   Replace all calls to svn_path_local_style() with relevant svn_dirent or
   svn_uri variants.


Revision 877554 - (view) (download) (annotate) - [select for diffs]
Modified Sun Apr 26 03:37:10 2009 UTC (15 years, 3 months ago) by arfrever
File length: 22487 byte(s)
Diff to previous 876434 (colored)
Follow-up to r36360:
Fix segmentation fault which occurs when unrecognized file was specified in
argument of the --config-option option.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline__apply_config_options): Don't call svn_config_set() with cfg=NULL.


Revision 876434 - (view) (download) (annotate) - [select for diffs]
Modified Fri Mar 6 01:00:42 2009 UTC (15 years, 4 months ago) by rhuijben
File length: 22457 byte(s)
Diff to previous 875635 (colored)
Move the --config-option processing from svn to the svn_cmdline__ part of
libsvn_subr to make it possible to use the same parser in svnsync.

* subversion/include/private/svn_cmdline_private.h
  (svn_cmdline__config_argument_t): New struct.
  (svn_cmdline__parse_config_option): New function.
  (svn_cmdline__apply_config_options): New function.
* subversion/libsvn_subr/cmdline.c
  (svn_cmdline__parse_config_option): New function.
  (svn_cmdline__apply_config_options): New function.
* subversion/svn/main.c
  (includes): Include private/svn_cmdline_private.h.
  (config_option_t): Remove struct.
  (parse_config_option): Remove function.
  (main): Use svn_cmdline__parse_config_option and
    svn_cmdline__apply_config_options for config option parsing.


Revision 875635 - (view) (download) (annotate) - [select for diffs]
Modified Thu Jan 29 22:22:30 2009 UTC (15 years, 5 months ago) by rhuijben
File length: 19715 byte(s)
Diff to previous 875530 (colored)
* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_setup_auth_baton): Move deprecated function to ...
* subversion/libsvn_subr/deprecated.c
  (svn_cmdline_setup_auth_baton): ... deprecated.c


Revision 875530 - (view) (download) (annotate) - [select for diffs]
Modified Sun Jan 25 17:41:08 2009 UTC (15 years, 6 months ago) by arfrever
File length: 20555 byte(s)
Diff to previous 875498 (colored)
Move all functions from 'utf_impl.h' to 'svn_utf_private.h'.

* subversion/libsvn_subr/utf_impl.h
  (svn_utf__cstring_from_utf8_fuzzy,
   svn_utf__last_valid,
   svn_utf__last_valid2): Move from here ...
* subversion/include/private/svn_utf_private.h
  (svn_utf__cstring_from_utf8_fuzzy,
   svn_utf__last_valid,
   svn_utf__last_valid2): ... to here.

* subversion/libsvn_diff/diff_file.c:
* subversion/libsvn_subr/cmdline.c:
* subversion/libsvn_subr/utf.c:
* subversion/libsvn_subr/utf_validate.c:
* subversion/libsvn_subr/xml.c:
* subversion/tests/libsvn_subr/utf-test.c: Update includes.


Revision 875498 - (view) (download) (annotate) - [select for diffs]
Modified Fri Jan 23 18:30:04 2009 UTC (15 years, 6 months ago) by gstein
File length: 20541 byte(s)
Diff to previous 875388 (colored)
Adjust a bunch of our public header files:

- make sure everything the header needs is included
- make sure nothing is included which is NOT needed

Added an exception to svn_types.h: it now explicitly includes svn_error.h
since Everybody needs that thing. We go ahead and make it easy for them,
even though that is counter-philosophy.

After altering the header files, some .c files in our codebase would not
compile -- they used stuff that they did not explicitly include. Thus, a
goodly number of .c files were updated, too.

* subversion/libsvn_ra/wrapper_template.h:
* subversion/libsvn_ra/deprecated.c:
* subversion/libsvn_ra/compat.c:
* subversion/libsvn_subr/iter.c:
* subversion/libsvn_subr/cmdline.c:
* subversion/libsvn_subr/ssl_client_cert_pw_providers.c:
* subversion/libsvn_subr/error.c:
* subversion/libsvn_subr/auth.c:
* subversion/libsvn_subr/opt.c:
* subversion/libsvn_subr/checksum.c:
* subversion/libsvn_subr/compat.c:
* subversion/libsvn_subr/sha1.c:
* subversion/libsvn_subr/deprecated.c:
* subversion/libsvn_subr/ssl_server_trust_providers.c:
* subversion/mod_dav_svn/activity.c:
* subversion/mod_dav_svn/reports/log.c:
* subversion/tests/libsvn_fs/fs-test.c:
* subversion/tests/libsvn_repos/repos-test.c:
* subversion/svn/list-cmd.c:
* subversion/svn/changelist-cmd.c:
* subversion/svn/log-cmd.c:
* subversion/svn/conflict-callbacks.c:
* subversion/libsvn_fs_base/dag.c:
* subversion/libsvn_fs_base/util/fs_skels.c:
* subversion/include/svn_dirent_uri.h:
* subversion/include/svn_error_codes.h:
* subversion/include/svn_fs.h:
* subversion/include/svn_diff.h:
* subversion/include/svn_sorts.h:
* subversion/include/svn_mergeinfo.h:
* subversion/include/svn_base64.h:
* subversion/include/svn_dso.h:
* subversion/include/svn_ra_svn.h:
* subversion/include/svn_repos.h:
* subversion/include/svn_delta.h:
* subversion/include/svn_path.h:
* subversion/include/svn_subst.h:
* subversion/include/svn_xml.h:
* subversion/include/svn_props.h:
* subversion/include/svn_iter.h:
* subversion/include/svn_types.h:
* subversion/include/svn_config.h:
* subversion/include/svn_string.h:
* subversion/include/svn_io.h:
* subversion/include/svn_wc.h:
* subversion/include/svn_cmdline.h:
* subversion/include/svn_client.h:
* subversion/include/svn_user.h:
* subversion/include/svn_hash.h:
* subversion/include/svn_md5.h:
* subversion/include/svn_error.h:
* subversion/include/svn_pools.h:
* subversion/include/private/svn_log.h:
* subversion/include/svn_time.h:
* subversion/include/svn_utf.h:
* subversion/include/svn_auth.h:
* subversion/include/svn_ra.h:
* subversion/include/svn_opt.h:
* subversion/include/svn_checksum.h:
* subversion/libsvn_wc/deprecated.c:
* subversion/libsvn_wc/util.c:
* subversion/libsvn_wc/merge.c:
* subversion/libsvn_wc/tree_conflicts.c:
* subversion/libsvn_client/list.c:
* subversion/libsvn_client/log.c:
* subversion/libsvn_ra_neon/util.c:
* subversion/libsvn_ra_neon/log.c:
* subversion/libsvn_repos/deprecated.c:
* subversion/libsvn_fs_fs/tree.c:
* subversion/libsvn_fs_fs/fs_fs.c:
  (): adjust #include statements appropriately



Revision 875388 - (view) (download) (annotate) - [select for diffs]
Modified Sun Jan 18 17:55:07 2009 UTC (15 years, 6 months ago) by arfrever
File length: 20519 byte(s)
Diff to previous 875242 (colored)
Rename svn_auth_unlock_prompt_func_t to
svn_auth_gnome_keyring_unlock_prompt_func_t.
Rename svn_cmdline_auth_unlock_prompt() to
svn_cmdline__auth_gnome_keyring_unlock_prompt().

* subversion/include/svn_auth.h
  (svn_auth_unlock_prompt_func_t): Rename to ...
  (svn_auth_gnome_keyring_unlock_prompt_func_t): ... this.
  (svn_auth_get_gnome_keyring_simple_provider,
   svn_auth_get_gnome_keyring_ssl_client_cert_pw_provider): Fix doc string.

* subversion/include/svn_cmdline.h
* subversion/libsvn_subr/prompt.c
  (svn_cmdline_auth_unlock_prompt): Rename to ...
* subversion/include/private/svn_cmdline_private.h
* subversion/libsvn_subr/prompt.c
  (svn_cmdline__auth_gnome_keyring_unlock_prompt): ... this.

* subversion/libsvn_auth_gnome_keyring/gnome_keyring.c
  (simple_gnome_keyring_first_creds,
   simple_gnome_keyring_save_creds,
   ssl_client_cert_pw_gnome_keyring_first_creds,
   ssl_client_cert_pw_gnome_keyring_save_creds): Update.
* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_create_auth_baton): Update.


Revision 875242 - (view) (download) (annotate) - [select for diffs]
Modified Mon Jan 12 09:51:24 2009 UTC (15 years, 6 months ago) by stylesen
File length: 20504 byte(s)
Diff to previous 875237 (colored)
Set unlock prompt function conditionally.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_create_auth_baton): Set unlock prompt function only if we
   have GNOME Keyring enabled.

Suggested by: arfrever


Revision 875237 - (view) (download) (annotate) - [select for diffs]
Modified Mon Jan 12 06:54:26 2009 UTC (15 years, 6 months ago) by stylesen
File length: 20513 byte(s)
Diff to previous 875235 (colored)
Follow up r35161.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_create_auth_baton): Set unlock prompt function only if operating
   system is other than darwin and win32 which otherwise breaks the builds.


Revision 875235 - (view) (download) (annotate) - [select for diffs]
Modified Mon Jan 12 04:31:13 2009 UTC (15 years, 6 months ago) by arfrever
File length: 20438 byte(s)
Diff to previous 875186 (colored)
Follow-up to r34977, r35055 and r35112:
Pass unlock prompt function for GNOME Keyring providers by authentication
baton parameters. Simplify some functions. Fix a segmentation fault which
was causing failure of auth-test.

* subversion/include/svn_auth.h
  (svn_auth_unlock_provider_func_t): Delete.
  (svn_auth_get_platform_specific_provider): Delete 'pb', 'prompt_func' and
   'command_line' arguments.
  (svn_auth_get_platform_specific_client_providers): Delete 'pb', 'prompt_func'
   and 'command_line' arguments.
  (SVN_AUTH_PARAM_GNOME_KEYRING_UNLOCK_PROMPT_FUNC): Define.
  (SVN_AUTH_PARAM_GNOME_KEYRING_UNLOCK_PROMPT_BATON): Define.
  (svn_auth_get_gnome_keyring_simple_provider): Delete 'unlock_prompt_func'
   and 'prompt_baton' arguments.

* subversion/libsvn_subr/auth.c
  (svn_auth_get_platform_specific_provider): Fix segmentation fault which was
   happening when we were calling svn_auth_get_gnome_keyring_simple_provider()
   and 'command_line' was FALSE, because the symbol of that function was
   earlier cast to svn_auth_simple_provider_func_t, while that function was
   actually of type svn_auth_unlock_provider_func_t. Delete 'pb', 'prompt_func'
   and 'command_line' arguments.
  (svn_auth_get_platform_specific_client_providers): Delete 'pb', 'prompt_func'
   and 'command_line' arguments. Update calls to
   svn_auth_get_platform_specific_provider().

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_create_auth_baton): Update calls to
   svn_auth_get_platform_specific_client_providers() and
   svn_auth_get_platform_specific_provider().
   Set SVN_AUTH_PARAM_GNOME_KEYRING_UNLOCK_PROMPT_FUNC with value of
   svn_cmdline_auth_unlock_prompt() in authentication baton parameters.

* subversion/libsvn_auth_gnome_keyring/gnome_keyring.c
  (unlock_prompt_provider_baton_t): Delete.
  (callback_done): Fix indentation.
  (get_default_keyring_name): Delete needless parenthesis around returned value.
  (gnome_keyring_simple_first_creds): Retrieve unlock prompt function and
   unlock prompt baton from authentication baton parameters.
  (gnome_keyring_simple_save_creds): Retrieve unlock prompt function and
   unlock prompt baton from authentication baton parameters.
  (svn_auth_get_gnome_keyring_simple_provider): Delete 'unlock_prompt_func' and
   'unlock_prompt_baton' arguments. Don't set '*provider->provider_baton'.

* subversion/bindings/javahl/native/SVNClient.cpp
  (SVNClient::getContext): Update calls to
   svn_auth_get_platform_specific_client_providers() and
   svn_auth_get_platform_specific_provider().

* subversion/tests/libsvn_subr/auth-test.c
  (test_platform_specific_auth_providers): Update calls to
   svn_auth_get_platform_specific_provider() and
   svn_auth_get_platform_specific_client_providers().


Revision 875186 - (view) (download) (annotate) - [select for diffs]
Modified Fri Jan 9 14:09:58 2009 UTC (15 years, 6 months ago) by stylesen
File length: 20423 byte(s)
Diff to previous 874545 (colored)
Follow up r35055.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_create_auth_baton): For platform specific providers pass prompt
   function.
* subversion/libsvn_subr/auth.c
  (svn_auth_get_platform_specific_provider): Change signature and include logic
   to accept prompt function and a boolean to indicate whether we are called
   from command line.
  (svn_auth_get_platform_specific_client_providers): Same as above.
* subversion/include/svn_auth.h
  (svn_auth_get_platform_specific_provider): Reflect above changes.
  (svn_auth_get_platform_specific_client_providers): Reflect above changes.
* subversion/tests/libsvn_subr/auth-test.c
  (test_platform_specific_auth_providers): Modify to accomodate above changes.

Suggested by: rhuijben
              arfrever
              julianfoad
              hwright


Revision 874545 - (view) (download) (annotate) - [select for diffs]
Modified Sat Nov 29 16:31:28 2008 UTC (15 years, 7 months ago) by arfrever
File length: 20402 byte(s)
Diff to previous 874473 (colored)
Follow-up to r34399:
Support the 'password-stores' configuration option in
svn_auth_get_platform_specific_client_providers().

* subversion/include/svn_auth.h
  (svn_auth_get_platform_specific_client_providers): Add 'config' argument.
  (svn_auth_get_platform_specific_provider,
   svn_auth_get_platform_specific_client_providers): Delete partially
   misleading information from doc string.

* subversion/libsvn_subr/auth.c
  (svn_auth_get_platform_specific_client_providers): Add 'config' argument.
   Use the 'password-stores' configuration option from 'config' to determine
   order of the platform-specific authentication providers.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_create_auth_baton): Update call to
   svn_auth_get_platform_specific_client_providers().
* subversion/bindings/javahl/native/SVNClient.cpp
  (SVNClient::getContext): Update call to
   svn_auth_get_platform_specific_client_providers().
* subversion/tests/libsvn_subr/auth-test.c
  (test_platform_specific_auth_providers): Update call to
   svn_auth_get_platform_specific_client_providers().


Revision 874473 - (view) (download) (annotate) - [select for diffs]
Modified Tue Nov 25 04:02:43 2008 UTC (15 years, 8 months ago) by jwhitlock
File length: 20281 byte(s)
Diff to previous 874303 (colored)
Greatly simplify how to get a list of available platform-specific auth
providers.

* subversion/libsvn_subr/auth.c,
* subversion/include/svn_auth.h
  (svn_auth_get_platform_specific_client_providers): Added.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_create_auth_baton):
* subversion/bindings/javahl/native/SVNClient.cpp
  (SVNClient::getContext): Use the new function added above.

* subversion/tests/libsvn_subr/auth-test.c
  (test_platform_specific_auth_providers): Test the new function added above.


Revision 874303 - (view) (download) (annotate) - [select for diffs]
Modified Sun Nov 16 17:32:20 2008 UTC (15 years, 8 months ago) by arfrever
File length: 24608 byte(s)
Diff to previous 874295 (colored)
Revert r34223 and r34221.

Suggested by: rhuijben


Revision 874295 - (view) (download) (annotate) - [select for diffs]
Modified Sun Nov 16 14:19:54 2008 UTC (15 years, 8 months ago) by arfrever
File length: 25532 byte(s)
Diff to previous 874294 (colored)
Implement termination of authentication providers.

* subversion/include/svn_auth.h
  (svn_auth_provider_t.terminate_provider): New function which terminates
   authentication provider.

* subversion/include/svn_cmdline.h
  (svn_cmdline_terminate_auth_baton): New function which terminates all
   authentication providers in authentication baton, which have non-NULL
   terminate_provider() function.

* subversion/libsvn_subr/cmdline.c
  (provider_set_t): New structure.
  (svn_cmdline_terminate_auth_baton): New function which terminates all
   authentication providers in authentication baton, which have non-NULL
   terminate_provider() function.

* subversion/libsvn_subr/auth.c
  (svn_auth_baton_t): Move from here ...
* subversion/include/private/svn_auth_private.h
  (svn_auth_baton_t): ... to here.

* subversion/svn/main.c
  (main): Call svn_cmdline_terminate_auth_baton().

* subversion/svnsync/main.c
  (main): Call svn_cmdline_terminate_auth_baton().


Revision 874294 - (view) (download) (annotate) - [select for diffs]
Modified Sun Nov 16 12:33:16 2008 UTC (15 years, 8 months ago) by rhuijben
File length: 24608 byte(s)
Diff to previous 874292 (colored)
To complete issue #2489, implement secure client certificate passphrase 
caching for Windows CryptoAPI.

* subversion/include/private/svn_auth_private.h
  (svn_auth__ssl_client_cert_pw_file_save_creds_helper): Update documentation
    to note that it is used by the windows cryptoapi store.
  (svn_auth__ssl_client_cert_pw_get): Add passphrase getter for use by the 
    Windows crypto provider.
  (svn_auth__ssl_client_cert_pw_set): Add passphrase setter for use by the 
    Windows crypto provider.
* subversion/include/svn_auth.h
  (svn_auth_get_windows_ssl_client_cert_pw_provider): Add Windows Crypto api
    ssl client certificate passphrase provider.
* subversion/libsvn_subr/auth.c
  (svn_auth_get_platform_specific_provider): Handle requests for windows 
    ssl_client_cert_pw.
* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_create_auth_baton): Register Windows Crypto api ssl client 
    certificate passphrase provider in the auth batton.
* subversion/libsvn_subr/ssl_client_cert_pw_providers.c
  (simple_passphrase_get): Renamed to ...
  (svn_auth__ssl_client_cert_pw_get): .... and remove static to allow reuse
    by the Windows Crypto api implementation.
  (simple_passphrase_set): Renamed to ...
  svn_auth__ssl_client_cert_pw_set): ... and remove static to allow reuse
    by the Windows Crypto api implementation.
  (svn_auth__ssl_client_cert_pw_file_save_creds_helper): Mark that passphrases
    saved by the Windows Crypto api are encrypted to remove the confirmation 
    prompt.
  (ssl_client_cert_pw_file_first_credentials, 
   ssl_client_cert_pw_file_save_credentials): Update references to 
    simple_passphrase_*.
* subversion/libsvn_subr/win32_crypto.c
  (windows_ssl_client_cert_pw_encrypter, 
   windows_ssl_client_cert_pw_decrypter,
   windows_ssl_client_cert_pw_first_creds, 
   windows_ssl_client_cert_pw_save_creds, 
   windows_ssl_client_cert_pw_provider): Add ssl client certificate passphrase
    provider, forwarding caching and save requests to the file provider like
    the simple provider.
  (svn_auth_get_windows_ssl_client_cert_pw_provider): Add registration function
    for the Windows Crypto api ssl client certificate passphrase provider.
* subversion/tests/libsvn_subr/auth-test.c
  (test_platform_specific_auth_providers): Test registration of the CryptoApi 
    provider via svn_auth_get_platform_specific_provider.


Revision 874292 - (view) (download) (annotate) - [select for diffs]
Modified Sat Nov 15 16:30:20 2008 UTC (15 years, 8 months ago) by arfrever
File length: 24276 byte(s)
Diff to previous 874159 (colored)
Follow-up to r34085:

* subversion/libsvn_subr/auth.c
  (svn_auth_get_platform_specific_provider): Rename local constant.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_create_auth_baton): Consistently use SVN_ERR() and improve
   indentation.

* subversion/bindings/javahl/native/SVNClient.cpp
  (SVNClient::getContext): Consistently use SVN_JNI_ERR() and improve
   indentation.

* subversion/tests/libsvn_subr/auth-test.c: Fix copyright year.


Revision 874159 - (view) (download) (annotate) - [select for diffs]
Modified Thu Nov 6 21:06:14 2008 UTC (15 years, 8 months ago) by jwhitlock
File length: 23528 byte(s)
Diff to previous 874081 (colored)
Refactor how Subversion accesses platform-specific auth providers.

* build.conf
  (auth-test): New section for the auth tests.
  (__LIBS__): Added auth-test to lib.

* subversion/libsvn_subr/cmdline.c
  (get_auth_provider): Removed.
  (svn_cmdline_create_auth_baton): Use the new API to access
   platform-specific auth providers.

* subversion/libsvn_subr/auth.c
  (svn_auth_get_platform_specific_provider): Added.

* subversion/tests/libsvn_subr
  (svn:ignore): Ignore auth-test.

* subversion/tests/libsvn_subr/auth-test.c: Added.

* subversion/bindings/javahl/native/SVNClient.cpp
  (get_auth_provider): Removed.
  (SVNClient::getContext): Use the new API to access platform-specific
   auth providers.

* subversion/bindings/ctypes-python/setup.py
  (build.get_apr_config): Removed the libsvn_auth_gnome_keyring and
   libsvn_auth_kwallet libs.

* subversion/bindings/swig/core.i,
* subversion/bindings/swig/svn_client.i: Add explicit ignores for all
   platform-specific auth providers.

* subversion/bindings/swig/python/tests/auth.py
  (test_conditional_auth_provider_support): Removed.

* subversion/bindings/swig/include/svn_global.swg
  (PLATFORM_SPECIFIC_WRAPPER): Removed.

* subversion/include/svn_auth.h
  (svn_auth_get_platform_specific_provider): Added.
  (svn_auth_get_windows_simple_provider,
   svn_auth_get_windows_ssl_server_trust_provider,
   svn_auth_get_keychain_simple_provider,
   svn_auth_get_keychain_ssl_client_cert_pw_provider,
   svn_auth_gnome_keyring_version,
   svn_auth_get_gnome_keyring_simple_provider,
   svn_auth_get_gnome_keyring_ssl_client_cert_pw_provider,
   svn_auth_kwallet_version,
   svn_auth_get_kwallet_simple_provider,
   svn_auth_get_kwallet_ssl_client_cert_pw_provider): Removed exposure to
    swig and ctypesgen.


Revision 874081 - (view) (download) (annotate) - [select for diffs]
Modified Sun Nov 2 19:34:25 2008 UTC (15 years, 8 months ago) by arfrever
File length: 26471 byte(s)
Diff to previous 874026 (colored)
Delete trailing whitespace.
Follow-up to r26317 and r27598.

* build/generator/extractor.py:
* build/generator/gen_vcnet_vcproj.py:
* build/generator/gen_win.py:
* contrib/client-side/svnmerge/svnmerge-migrate-history-remotely.py:
* subversion/bindings/ctypes-python/csvn/repos.py:
* subversion/bindings/ctypes-python/csvn/wc.py:
* subversion/bindings/ctypes-python/examples/mucc.py:
* subversion/bindings/ctypes-python/setup.py:
* subversion/bindings/ctypes-python/test/localrepos.py:
* subversion/bindings/ctypes-python/test/remoterepos.py:
* subversion/bindings/ctypes-python/test/run_all.py:
* subversion/bindings/ctypes-python/test/svntypes.py:
* subversion/bindings/ctypes-python/test/wc.py:
* subversion/bindings/javahl/src/org/tigris/subversion/javahl/Operation.java:
* subversion/include/private/svn_auth_private.h:
* subversion/include/private/svn_sqlite.h:
* subversion/include/private/svn_wc_private.h:
* subversion/include/svn_auth.h:
* subversion/include/svn_checksum.h:
* subversion/include/svn_client.h:
* subversion/include/svn_cmdline.h:
* subversion/include/svn_dirent_uri.h:
* subversion/include/svn_path.h:
* subversion/include/svn_props.h:
* subversion/libsvn_client/commit_util.c:
* subversion/libsvn_client/copy.c:
* subversion/libsvn_client/deprecated.c:
* subversion/libsvn_client/export.c:
* subversion/libsvn_client/externals.c:
* subversion/libsvn_client/info.c:
* subversion/libsvn_client/merge.c:
* subversion/libsvn_client/mergeinfo.h:
* subversion/libsvn_client/ra.c:
* subversion/libsvn_client/repos_diff.c:
* subversion/libsvn_fs_base/bdb/checksum-reps-table.c:
* subversion/libsvn_fs_base/bdb/checksum-reps-table.h:
* subversion/libsvn_fs_base/bdb/miscellaneous-table.c:
* subversion/libsvn_fs_base/bdb/reps-table.c:
* subversion/libsvn_fs_base/dag.c:
* subversion/libsvn_fs_base/dag.h:
* subversion/libsvn_fs_base/err.h:
* subversion/libsvn_fs_base/fs.c:
* subversion/libsvn_fs_base/reps-strings.c:
* subversion/libsvn_fs_base/tree.c:
* subversion/libsvn_fs_base/tree.h:
* subversion/libsvn_fs_base/util/fs_skels.c:
* subversion/libsvn_fs_fs/dag.h:
* subversion/libsvn_fs_fs/fs_fs.h:
* subversion/libsvn_fs/fs-loader.c:
* subversion/libsvn_fs/fs-loader.h:
* subversion/libsvn_fs_fs/rep-cache.c:
* subversion/libsvn_fs_fs/rep-cache.h:
* subversion/libsvn_fs_fs/tree.c:
* subversion/libsvn_ra/compat.c:
* subversion/libsvn_ra_neon/log.c:
* subversion/libsvn_ra_neon/session.c:
* subversion/libsvn_ra_serf/log.c:
* subversion/libsvn_ra_serf/update.c:
* subversion/libsvn_ra_serf/util.c:
* subversion/libsvn_ra_serf/win32_auth_sspi.c:
* subversion/libsvn_repos/hooks.c:
* subversion/libsvn_repos/log.c:
* subversion/libsvn_repos/repos.h:
* subversion/libsvn_subr/checksum.c:
* subversion/libsvn_subr/cmdline.c:
* subversion/libsvn_subr/config_file.c:
* subversion/libsvn_subr/config_win.c:
* subversion/libsvn_subr/dirent_uri.c:
* subversion/libsvn_subr/dso.c:
* subversion/libsvn_subr/io.c:
* subversion/libsvn_subr/nls.c:
* subversion/libsvn_subr/simple_providers.c:
* subversion/libsvn_subr/sqlite.c:
* subversion/libsvn_subr/ssl_client_cert_pw_providers.c:
* subversion/libsvn_subr/stream.c:
* subversion/libsvn_subr/win32_crypto.c:
* subversion/libsvn_wc/adm_ops.c:
* subversion/libsvn_wc/diff.c:
* subversion/libsvn_wc/props.c:
* subversion/libsvn_wc/status.c:
* subversion/libsvn_wc/tree_conflicts.c:
* subversion/libsvn_wc/tree_conflicts.h:
* subversion/libsvn_wc/update_editor.c:
* subversion/libsvn_wc/wc_db.h:
* subversion/svn/cl.h:
* subversion/svndumpfilter/main.c:
* subversion/svnlook/main.c:
* subversion/svn/propedit-cmd.c:
* subversion/svn/propget-cmd.c:
* subversion/svnserve/main.c:
* subversion/svn/status-cmd.c:
* subversion/svn/tree-conflicts.c:
* subversion/svn/util.c:
* subversion/tests/cmdline/commit_tests.py:
* subversion/tests/cmdline/copy_tests.py:
* subversion/tests/cmdline/info_tests.py:
* subversion/tests/cmdline/log_tests.py:
* subversion/tests/cmdline/merge_tests.py:
* subversion/tests/cmdline/prop_tests.py:
* subversion/tests/cmdline/revert_tests.py:
* subversion/tests/cmdline/stat_tests.py:
* subversion/tests/cmdline/svntest/actions.py:
* subversion/tests/cmdline/svntest/tree.py:
* subversion/tests/cmdline/switch_tests.py:
* subversion/tests/cmdline/tree_conflict_tests.py:
* subversion/tests/cmdline/update_tests.py:
* subversion/tests/libsvn_repos/repos-test.c:
* subversion/tests/libsvn_subr/checksum-test.c:
* subversion/tests/libsvn_subr/dirent_uri-test.c:
* subversion/tests/libsvn_subr/path-test.c:
* subversion/tests/libsvn_subr/target-test.c:
* subversion/tests/libsvn_wc/tree-conflict-data-test.c:
* tools/examples/svnlook.py: Delete trailing whitespace.


Revision 874026 - (view) (download) (annotate) - [select for diffs]
Modified Wed Oct 29 20:06:22 2008 UTC (15 years, 8 months ago) by cmpilato
File length: 26473 byte(s)
Diff to previous 873379 (colored)
Rename a new 1.6-era function for a few reasons:

  - it's a little harder to tell the difference between "set_up" and
    "setup" than between even "function" and "function2".

  - but if we don't like the noun "setup" being used as a verb, let's
    at least avoid the use of "up" as a verb modifier in English,
    which is ... weird.

  - besides, "set up" sounds like it initializes an existing auth
    baton, which it doesn't.  So let's go with "create" as a closer
    binding with names of similar factory functions.

  - i like mine sage green.   

* subversion/include/svn_cmdline.h,
* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_create_auth_baton): Was svn_cmdline_set_up_auth_baton().
  (svn_cmdline_setup_auth_baton): Track renamed function.

* subversion/svn/main.c
  (main): Track renamed function.

* subversion/svnsync/main.c
  (main): Track renamed function.


Revision 873379 - (view) (download) (annotate) - [select for diffs]
Modified Thu Sep 25 20:43:36 2008 UTC (15 years, 10 months ago) by arfrever
File length: 26473 byte(s)
Diff to previous 872934 (colored)
Check version of libsvn_auth_(gnome_keyring|kwallet) before loading provider
function symbols.

* subversion/include/svn_auth.h
  (): Include "svn_version.h".
  (svn_auth_gnome_keyring_version, svn_auth_kwallet_version): New functions.

* subversion/include/svn_version.h
  (svn_version_func_t): New function type.

* subversion/libsvn_auth_gnome_keyring/version.c
  (svn_auth_gnome_keyring_version): New function.

* subversion/libsvn_auth_kwallet/version.c
  (svn_auth_kwallet_version): New function.

* subversion/libsvn_subr/cmdline.c
  (get_auth_provider): Check versions of dynamically loaded libraries. Rename
   some local variables.

Found by: philip


Revision 872934 - (view) (download) (annotate) - [select for diffs]
Modified Tue Sep 2 19:12:54 2008 UTC (15 years, 10 months ago) by jwhitlock
File length: 25353 byte(s)
Diff to previous 872884 (colored)
Support storing SSL client certificate passphrases in OSX Keychain.

* subversion/libsvn_subr/cmdline.c (svn_cmdline_set_up_auth_baton): Add OSX
   Keychain SSL client certificate passphrase provider to the providers array.

* subversion/libsvn_subr/macos_keychain.c (keychain_password_set,
   keychain_password_get): Added NULL check for username.
  (keychain_ssl_client_cert_pw_first_creds,
   keychain_ssl_client_cert_pw_save_creds,
   svn_auth_get_keychain_ssl_client_cert_pw_provider): New functions.
  (keychain_ssl_client_cert_pw_provider): New object.

* subversion/libsvn_subr/ssl_client_cert_pw_providers.c
  (svn_auth__ssl_client_cert_pw_file_save_creds_helper): Add OSX Keychain SSL
   client certificate passphrase provider to the list of providers which
   store passphrases encrypted.

* subversion/include/svn_auth.h
  (svn_auth_get_keychain_ssl_client_cert_pw_provider): New function.

Approved by: arfrever
             stylesen


Revision 872884 - (view) (download) (annotate) - [select for diffs]
Modified Fri Aug 29 15:43:09 2008 UTC (15 years, 11 months ago) by hwright
File length: 25196 byte(s)
Diff to previous 872573 (colored)
Replace calls to the deprecated svn_base64_encode_string() with 
svn_base64_encode_string2(), preserving the sematics of the former.

* subversion/libsvn_subr/cmdline.c
* subversion/mod_dav_svn/deadprops.c
* subversion/mod_dav_svn/reports/update.c
* subversion/mod_dav_svn/reports/get-locks.c
* subversion/mod_dav_svn/reports/file-revs.c
* subversion/mod_dav_svn/reports/replay.c
* subversion/libsvn_ra_svn/cyrus_auth.c
* subversion/libsvn_ra_neon/props.c
* subversion/libsvn_ra_serf/commit.c
* subversion/svnserve/cyrus_auth.c:
  Replace calls to svn_base64_encode_string().


Revision 872573 - (view) (download) (annotate) - [select for diffs]
Modified Fri Aug 15 23:44:10 2008 UTC (15 years, 11 months ago) by arfrever
File length: 25126 byte(s)
Diff to previous 872572 (colored)
* subversion/libsvn_auth_kwallet/kwallet.cpp
  (kwallet_password_get, kwallet_password_set): Fix compiler warnings and
   simplify logic.

* subversion/libsvn_auth_gnome_keyring/gnome_keyring.c
  (GNOME Keyring SSL client certificate passphrase provider): Add a comment.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_set_up_auth_baton): Change indentation.


Revision 872572 - (view) (download) (annotate) - [select for diffs]
Modified Fri Aug 15 21:29:50 2008 UTC (15 years, 11 months ago) by arfrever
File length: 25152 byte(s)
Diff to previous 872453 (colored)
Support storing SSL client certificate passphrases in KWallet.

* subversion/include/svn_auth_dso.h
  (svn_auth_get_kwallet_ssl_client_cert_pw_provider): New function.

* subversion/libsvn_auth_kwallet/kwallet.cpp
  (kwallet_ssl_client_cert_pw_first_creds,
   kwallet_ssl_client_cert_pw_save_creds,
   svn_auth_get_kwallet_ssl_client_cert_pw_provider): New functions.
  (kwallet_ssl_client_cert_pw_provider): New object.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_set_up_auth_baton): Add KWallet SSL client certificate
   passphrase provider to the providers array.

* subversion/libsvn_subr/ssl_client_cert_pw_providers.c
  (svn_auth__ssl_client_cert_pw_file_save_creds_helper): Add KWallet SSL
   client certificate passphrase provider to the list of providers which
   store passphrases encrypted.


Revision 872453 - (view) (download) (annotate) - [select for diffs]
Modified Wed Aug 6 15:12:55 2008 UTC (15 years, 11 months ago) by cmpilato
File length: 24878 byte(s)
Diff to previous 872450 (colored)
Fix a compiler warning introduced in r32376.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): Rework to avoid trying to return an svn_error_t*
    from a function that returns ints.

Revision 872450 - (view) (download) (annotate) - [select for diffs]
Modified Wed Aug 6 13:36:49 2008 UTC (15 years, 11 months ago) by kameshj
File length: 24738 byte(s)
Diff to previous 872438 (colored)
Bump 'svn_dso_initialize' to 'svn_dso_initialize2' which has a
return type of 'svn_error_t *' with a reason of error.

Fix callers of 'svn_dso_initialize' to make use 'svn_dso_initialize2'

* subversion/include/svn_dso.h
  (svn_dso_initialize2): New prototype.
  (svn_dso_initialize): Deprecated.

* subversion/libsvn_subr/dso.c
  (svn_dso_initialize2): New function.
  (svn_dso_initialize): Make use of new 'svn_dso_initialize2' and ignore
   error if any.
  (svn_dso_load): Make use of 'svn_dso_initialize2' instead of
   'svn_dso_initialize'.

* subversion/mod_dav_svn/mod_dav_svn.c
  (init_dso):
* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): Make use of svn_dso_initialize2
   instead of 'svn_dso_initialize'.

Suggested by: stsp
              blair


Revision 872438 - (view) (download) (annotate) - [select for diffs]
Modified Mon Aug 4 14:52:00 2008 UTC (15 years, 11 months ago) by pburba
File length: 24728 byte(s)
Diff to previous 872206 (colored)
Purge AS400 port specific code.

The AS400 port is no longer maintained nor does anyone have plans to
maintain it.  That's not so bad, but keeping the port code consistent with
changes made to trunk is becoming rather difficult, see
http://subversion.tigris.org/servlets/ReadMsg?listName=dev&msgNo=141147.

* subversion/include/svn_utf.h
* subversion/libsvn_client/add.c
* subversion/libsvn_ra_svn/streams.c
* subversion/libsvn_subr/cmdline.c
* subversion/libsvn_subr/io.c
* subversion/libsvn_subr/prompt.c
* subversion/libsvn_subr/utf.c
* subversion/svn/main.c
* subversion/svn/util.c
* subversion/svnlook/main.c
* subversion/tests/libsvn_ra_local/ra-local-test.c
* subversion/tests/libsvn_subr/target-test.c
  Remove AS400 blocked code and related comments.

Revision 872206 - (view) (download) (annotate) - [select for diffs]
Modified Tue Jul 15 19:41:22 2008 UTC (16 years ago) by kfogel
File length: 25302 byte(s)
Diff to previous 872140 (colored)
Cache SSL client certificate passphrases, when user indicates it's okay.
This resolves issue #2489, and prompted issues #3238, #3239, and #3236.

Patch by: stylesen
(Tweaked by kfogel.)

* subversion/include/svn_config.h
  (SVN_CONFIG_OPTION_STORE_SSL_CLIENT_CERT_PP,
   SVN_CONFIG_OPTION_STORE_SSL_CLIENT_CERT_PP_PLAINTEXT): New options,
    for storing SSL client cert passphrase at all and for storing it
    as plaintext, respectively.
  (SVN_CONFIG_DEFAULT_OPTION_STORE_SSL_CLIENT_CERT_PP,
   SVN_CONFIG_DEFAULT_OPTION_STORE_SSL_CLIENT_CERT_PP_PLAINTEXT): New defaults.

* subversion/libsvn_subr/config_file.c
  (ensure_auth_dirs): Create new auth dir to store ssl client cert passphrase.
  (svn_config_ensure): Add doc for the new options in the servers file string.

* subversion/libsvn_ra/ra_loader.c
  (svn_ra_open3): Load above new options from servers config file.

* subversion/libsvn_subr/cmdline.c
  (get_auth_simple_provider): Rename to...
  (get_auth_provider): ...this.  Take a new argument provider_type
    and use it to get the right provider.  Document this function.
  (svn_cmdline_setup_auth_baton): If we have gnome keyring support get the
    corresponding ssl client cert passphrase provider.

* subversion/libsvn_subr/prompt.c
  (plaintext_prompt_helper): New helper function, abstracts out the
    logic for plaintext promting.
  (svn_cmdline_auth_plaintext_prompt): Just wrap above new helper.
  (svn_cmdline_auth_plaintext_passphrase_prompt): New function, also
    using above new helper.

* subversion/libsvn_subr/ssl_client_cert_pw_providers.c: Include
    svn_auth_private.h and svn_private_config.h.
  (AUTHN_PASSPHRASE_KEY): Define passphrase key.
  (AUTHN_PASSTYPE_KEY): Define passtype key.
  (ssl_client_cert_pw_file_provider_baton_t): New baton for ssl client cert
   passphrase provider.
  (simple_passphrase_get): New function to get plaintext passphrase.
  (simple_passphrase_set): New function to store plaintext passphrase.
  (svn_auth__ssl_client_cert_pw_file_first_creds_helper): New internal
    API, abstracted out from...
  (ssl_client_cert_pw_file_first_credentials): ...here, which just
    wraps the above now.
  (svn_auth__ssl_client_cert_pw_file_save_creds_helper): New internal
    API, abstracted out from...
  (ssl_client_cert_pw_file_save_credentials): ...here, which just
    wraps the above now.
  (ssl_client_cert_pw_file_provider): Register above to save the credentials.
  (svn_auth_get_ssl_client_cert_pw_file_provider2): New public API which has
    a prompt function now.
  (svn_auth_get_ssl_client_cert_pw_file_provider): Update API for the above.

* subversion/include/private/svn_auth_private.h
  (svn_auth__ssl_client_cert_pw_file_first_creds_helper): Declare new API.
  (svn_auth__ssl_client_cert_pw_file_save_creds_helper): Declare new API.

* subversion/libsvn_auth_gnome_keyring/gnome_keyring.c
  (gnome_keyring_ssl_client_cert_pw_first_creds): New function to get ssl
   client cert passphrase from encrypted credentials.
  (gnome_keyring_ssl_client_cert_pw_save_creds): New function to save
   encrypted ssl client cert passphrase.
  (gnome_keyring_ssl_client_cert_pw_provider): New baton.
  (svn_auth_get_gnome_keyring_ssl_client_cert_pw_provider): New public API for
   gnome keyring based ssl client cert passphrase storage and retrieval.

* subversion/include/svn_auth_dso.h
  (svn_auth_get_gnome_keyring_ssl_client_cert_pw_provider): New public API.

* subversion/include/svn_cmdline.h
  (svn_cmdline_auth_plaintext_passphrase_prompt): New public API added to
   prompt for storing plaintext passphrases.

* subversion/include/svn_auth.h
  (svn_auth_ssl_client_cert_pw_provider_func_t): Define function type for the
   provider.
  (svn_auth_plaintext_passphrase_prompt_func_t): New function prototype.
  (SVN_AUTH_PARAM_DONT_STORE_SSL_CLIENT_CERT_PP): New constant.
  (SVN_AUTH_PARAM_STORE_SSL_CLIENT_CERT_PP_PLAINTEXT): New constant.
  (svn_auth_get_ssl_client_cert_pw_file_provider2): New public API.

* subversion/libsvn_ra_neon/session.c
  (client_ssl_decrypt_cert): Call svn_auth_save_credentials to save
    the ssl client certificate passphrase.


Revision 872140 - (view) (download) (annotate) - [select for diffs]
Modified Thu Jul 10 16:43:14 2008 UTC (16 years ago) by julianfoad
File length: 23453 byte(s)
Diff to previous 872139 (colored)
Include the header that declares a function in the source file that defines
that function, so the compiler can check that the signature matches. A
follow-up to r32065.

Found by GCC's warning.

* subversion/libsvn_subr/cmdline.c
  Include "private/svn_cmdline_private.h".


Revision 872139 - (view) (download) (annotate) - [select for diffs]
Modified Thu Jul 10 16:13:06 2008 UTC (16 years ago) by julianfoad
File length: 23411 byte(s)
Diff to previous 872065 (colored)
Factor out an XML-printing function that was common to "svn" and "svnlook"
since r31978.

This follows up to r32015, r32018, r32021, r32022, r32043, r32060 and
the discussions in this thread:
http://svn.haxx.se/dev/archive-2008-07/0227.shtml

* build.conf
  (libsvn_subr): Add svn_cmdline_private.h to msvc-export.

* subversion/libsvn_subr/cmdline.c
  (): Include svn_xml.h, svn_base64.h
  (svn_cmdline__print_xml_prop): New name for svn_cl__print_xml_prop().

* subversion/svn/props.c
  (): Include svn_cmdline_private.h
  (svn_cl__print_xml_prop): Removed, since it is renamed to
    svn_cmdline__print_xml_prop.
  (svn_cl__print_xml_prop_hash): Use svn_cmdline__print_xml_prop due to
    above change.

* subversion/svn/cl.h
  (svn_cl__print_xml_prop): Move to ..

* subversion/include/private/svn_cmdline_private.h
  (svn_cmdline__print_xml_prop): .. here

* subversion/svn/propget-cmd.c
  (): Include svn_cmdline_private.h
  (print_properties_xml, svn_cl__propget): Use svn_cmdline__print_xml_prop
    due to above change.

* subversion/svnlook/main.c
  (): Include svn_cmdline_private.h
  (print_xml_prop): Removed since we can use svn_cmdline__print_xml_prop now.
  (do_plist): Use svn_cmdline__print_xml_prop due to above changes.

Patch by: stylesen
Suggested by: glasser


Revision 872065 - (view) (download) (annotate) - [select for diffs]
Modified Thu Jul 3 18:25:35 2008 UTC (16 years ago) by kfogel
File length: 22235 byte(s)
Diff to previous 871825 (colored)
Resolve issue #2597: Add --trust-server-cert option to svn and svnsync,
so that non-interactive operations can work with (e.g.) self-signed
certificates not backed by a known trust authority.

Set up some shared infrastructure:

* subversion/include/svn_cmdline.h
  (svn_cmdline_setup_auth_baton): Deprecate, replace with...
  (svn_cmdline_set_up_auth_baton): ...this, which takes a new boolean
    parameter trust_server_cert.

* subversion/libsvn_subr/cmdline.c
  (ssl_trust_unknown_server_cert): New function.
  (svn_cmdline_setup_auth_baton): Just wrap below.
  (svn_cmdline_set_up_auth_baton): New function, based on above.  If
    both non_interactive and the new parameter trust_server_cert are
    true, then register ssl_trust_unknown_server_cert as a provider.

Add the new option to 'svn':

* subversion/svn/cl.h
  (svn_cl__opt_state_t): New boolean trust_server_cert.

* subversion/svn/main.c
  (svn_cl__options): Add new "trust-server-cert" option.
  (svn_cl__longopt_t): New opt_trust_server_cert enum.
  (svn_cl__global_options): Add opt_trust_server_cert to this list.
  (main): Parse the new option, do the expect things with the result.

Add the new option to 'svnsync':

* subversion/svnsync/main.c
  (svnsync_opt_trust_server_cert): New opt enum.
  (SVNSYNC_OPTS_DEFAULT, svnsync_options): List the new option.
  (struct opt_baton_t): New field trust_server_cert.
  (main): Parse the new option, do the expect things with the result.

Update the expected help output for the tests:

* subversion/tests/cmdline/getopt_tests_data/svn_help_log_switch_stdout: 
  Adjust for above.


Revision 871825 - (view) (download) (annotate) - [select for diffs]
Modified Sun Jun 15 18:26:08 2008 UTC (16 years, 1 month ago) by arfrever
File length: 20056 byte(s)
Diff to previous 871617 (colored)
Follow-up to r31739:

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_setup_auth_baton): Use SVN_ERR_BAD_CONFIG_VALUE instead of
   SVN_ERR_AUTHN_NO_PROVIDER.


Revision 871617 - (view) (download) (annotate) - [select for diffs]
Modified Sat May 31 15:46:41 2008 UTC (16 years, 1 month ago) by arfrever
File length: 20057 byte(s)
Diff to previous 871616 (colored)
Follow-up to r31515:

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_setup_auth_baton): Fix indentation.

Found by: stylesen


Revision 871616 - (view) (download) (annotate) - [select for diffs]
Modified Sat May 31 15:34:58 2008 UTC (16 years, 1 month ago) by arfrever
File length: 19999 byte(s)
Diff to previous 871596 (colored)
Don't ignore errors when loading libsvn_auth_*.

* subversion/libsvn_subr/cmdline.c
  (get_auth_simple_provider):
* subversion/bindings/javahl/native/SVNClient.cpp
  (get_auth_simple_provider): Change returned type to 'svn_error_t *' and
   don't ignore any errors.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_setup_auth_baton):
* subversion/bindings/javahl/native/SVNClient.cpp
  (SVNClient::getContext): Update calls to get_auth_simple_provider().

Suggested by: philip


Revision 871596 - (view) (download) (annotate) - [select for diffs]
Modified Thu May 29 19:53:53 2008 UTC (16 years, 2 months ago) by lgo
File length: 20083 byte(s)
Diff to previous 871589 (colored)
Follow up r31515: Fix the build on Windows (C89 compiler).

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_setup_auth_baton): Move some variable declarations to the 
   first lines of the block.


Revision 871589 - (view) (download) (annotate) - [select for diffs]
Modified Thu May 29 19:28:34 2008 UTC (16 years, 2 months ago) by arfrever
File length: 20064 byte(s)
Diff to previous 871520 (colored)
Follow-up to r31428:

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_setup_auth_baton): Use the 'password-stores' option also
   for Keychain and Windows CryptoAPI.
   Print error when the 'password-stores' option contains invalid value.

* subversion/libsvn_subr/config_file.c
  (svn_config_ensure): Update the default 'config' file.

Suggested by: me
              kfogel
              glasser
              danielsh


Revision 871520 - (view) (download) (annotate) - [select for diffs]
Modified Sun May 25 14:43:27 2008 UTC (16 years, 2 months ago) by arfrever
File length: 19664 byte(s)
Diff to previous 871502 (colored)
Follow-up to r31428:

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_setup_auth_baton): Delete obsolete comment.


Revision 871502 - (view) (download) (annotate) - [select for diffs]
Modified Sat May 24 20:22:10 2008 UTC (16 years, 2 months ago) by arfrever
File length: 19755 byte(s)
Diff to previous 871441 (colored)
Implement the 'password-stores' config option.

* subversion/include/svn_config.h
  (SVN_CONFIG_OPTION_PASSWORD_STORES): Define.

* subversion/libsvn_subr/config_file.c
  (svn_config_ensure): Update the default 'config' file.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_setup_auth_baton): Use the 'password-stores' option
   to determine order of dynamically loaded auth simple providers.


Revision 871441 - (view) (download) (annotate) - [select for diffs]
Modified Thu May 22 18:46:43 2008 UTC (16 years, 2 months ago) by arfrever
File length: 18729 byte(s)
Diff to previous 871435 (colored)
* subversion/libsvn_subr/cmdline.c
  (get_auth_simple_provider):
* subversion/bindings/javahl/native/SVNClient.cpp
  (get_auth_simple_provider): Check for errors before loading symbols.

Suggested by: Philip Martin <philip@codematters.co.uk>


Revision 871435 - (view) (download) (annotate) - [select for diffs]
Modified Thu May 22 16:59:56 2008 UTC (16 years, 2 months ago) by arfrever
File length: 18644 byte(s)
Diff to previous 871411 (colored)
* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_setup_auth_baton):
* subversion/bindings/javahl/native/SVNClient.cpp
  (SVNClient::getContext): Use dynamically loaded simple providers in
   alphabetic order.


Revision 871411 - (view) (download) (annotate) - [select for diffs]
Modified Wed May 21 18:33:35 2008 UTC (16 years, 2 months ago) by arfrever
File length: 18644 byte(s)
Diff to previous 871364 (colored)
Merge the 'gnome-keyring' branch to trunk.


Revision 871364 - (view) (download) (annotate) - [select for diffs]
Modified Sun May 18 19:31:12 2008 UTC (16 years, 2 months ago) by arfrever
File length: 18461 byte(s)
Diff to previous 871333 (colored)
* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_setup_auth_baton): Fix indentation.


Revision 871333 - (view) (download) (annotate) - [select for diffs]
Modified Sat May 17 10:51:45 2008 UTC (16 years, 2 months ago) by arfrever
File length: 18455 byte(s)
Diff to previous 871315 (colored)
* subversion/libsvn_subr/cmdline.c
  (get_auth_simple_provider): Be defined only when SVN_HAVE_KWALLET or
   SVN_HAVE_GNOME_KEYRING is defined.

Suggested by: epg


Revision 871315 - (view) (download) (annotate) - [select for diffs]
Modified Fri May 16 20:25:00 2008 UTC (16 years, 2 months ago) by arfrever
File length: 18383 byte(s)
Diff to previous 871126 (colored)
Merge the 'kwallet' branch to trunk.


Revision 871126 - (view) (download) (annotate) - [select for diffs]
Modified Tue May 6 21:49:13 2008 UTC (16 years, 2 months ago) by cmpilato
File length: 17175 byte(s)
Diff to previous 871120 (colored)
Fix more bug fallout from the recent dont-store-plaintext-passwords
feature branch merge.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_setup_auth_baton): Keep non-prompting providers ahead
    of prompting ones.  Otherwise, even if Subversion finds valid cached
    auth creds, it still asks you for more, which is ... non-ideal.


Revision 871120 - (view) (download) (annotate) - [select for diffs]
Modified Tue May 6 16:29:01 2008 UTC (16 years, 2 months ago) by stsp
File length: 17025 byte(s)
Diff to previous 870730 (colored)
Merge the dont-save-plaintext-passwords-by-default branch into trunk.

Summary of the functionality implemented:

- Add a 'store-plaintext-passwords' option, which can be set to
  'yes', 'no', or 'ask' (which is the default). If the option
  is set to 'ask', ask the user before saving plaintext passwords
  to disk. This is done from a callback that should be implemented
  by all clients. The callback is called once per authentication realm.
  If a client does not implement the callback, and does not provide
  an explicit default value, we default to storing plaintext passwords.
  I don't like this, but it's a compromise because we don't really want
  the semantics of the old API to change retroactively.
  We can, however, change this default anytime by tweaking a single
  line of code, should we decide to do so. The old API has been deprecated.

- Provide an implementation of the callback for our command line
  client, which, in addition to prompting, prints a warning explaining
  that the password can only be stored unencrypted, and shows the name
  of the authentication realm in question.
  
- Authentication parameter configuration has been moved to the
  RA layer completely. For users, this means that parameters
  which used to be configured in the [auth] section in the 'config'
  file are now configured in the 'servers' file, and can be specified
  both in the [global] section, and per server group. The [auth]
  section in 'config' is still being evaluated, but is overridden
  by anything specified in 'servers'.

Please consult the log messages of the branch for a detailed list
of all changes.


Revision 870730 - (view) (download) (annotate) - [select for diffs]
Modified Thu Apr 17 14:10:20 2008 UTC (16 years, 3 months ago) by stsp
File length: 16150 byte(s)
Diff to previous 869075 (colored)
* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_setup_auth_baton): Don't reuse a variable that
   represents the store-passwords option to also represent the
   store-auth-creds option. This made it look at first glance
   as if the store-passwords option was equivalent to the
   --no-auth-cache command line option, which isn't true.


Revision 869075 - (view) (download) (annotate) - [select for diffs]
Modified Wed Jan 23 15:45:11 2008 UTC (16 years, 6 months ago) by cmpilato
File length: 16101 byte(s)
Diff to previous 867003 (colored)
Fix some SEGFAULTs which crop up in kdesvn.  
(https://bugzilla.novell.com/show_bug.cgi?id=343706)

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): Check 'error_stream' for non-NULL-ness before
    using it.

Patch by: Olaf Hering <olh@suse.de>

Also accidentally committed in this changeset:

* subversion/bindings/swig/include/svn_containers.swg
  (STRINGLIST_MAY_BE_NULL): Implement this for Python.

* subversion/bindings/swig/svn_wc.i
  (STRINGLIST_MAY_BE_NULL): Apply this for 'changelists' parameters.

* subversion/bindings/swig/svn_client.i
  Merge two similar typemap applications into one statement.


Revision 867003 - (view) (download) (annotate) - [select for diffs]
Modified Thu Oct 4 03:48:21 2007 UTC (16 years, 9 months ago) by pburba
File length: 16049 byte(s)
Diff to previous 866991 (colored)
Follow-up to r26917, accomodate Win32's lack of line buffering.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): Don't change the buffering mode of stdout to line
  based buffering on Windows (it's not supported).

Suggested by: epg
              jrepenning

Revision 866991 - (view) (download) (annotate) - [select for diffs]
Modified Wed Oct 3 23:11:11 2007 UTC (16 years, 9 months ago) by dlr
File length: 16028 byte(s)
Diff to previous 866391 (colored)
Set output buffering mode early during command-line initialization processing.

* subversion/include/svn_cmdline.h
  (svn_cmdline_init): Indicate that stdout and ERROR_STREAM will have
   their buffering mode changed to line-based and unbuffered
   (character-based, really), respectively.

* subversion/libsvn_subr/cmdline.c
  Bump copyright date.  Include stdio.h.
  (svn_cmdline_init): Call setvbuf() on stdout and ERROR_STREAM (which
   is typically stderr).

Suggested by: epg
              jrepenning
Reviewed by: epg
             sussman


Revision 866391 - (view) (download) (annotate) - [select for diffs]
Modified Sun Aug 26 01:04:48 2007 UTC (16 years, 11 months ago) by hwright
File length: 15744 byte(s)
Diff to previous 863886 (colored)
Channeling Erik Hülsmann, remove all trailing whitespace within our source
tree:

for extsn in c h cpp java py pl rb; do
sed -i -e 's/[ \t]*$//' `find . -name "*.$extsn" | xargs grep '[ \t]$' -l`
done

Inspired by: ehu


Revision 863886 - (view) (download) (annotate) - [select for diffs]
Modified Wed Mar 14 12:19:01 2007 UTC (17 years, 4 months ago) by ivan
File length: 15756 byte(s)
Diff to previous 863368 (colored)
Add a new ssl server certificate trust provider for Windows (WinNT and later)
that automatically accepts server certificates with a trusted certificate
chain after validating it with the Windows CryptoApi.

* subversion/include/svn_auth.h
  (svn_auth_get_windows_ssl_server_trust_provider): New prototype.
* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_setup_auth_baton): Register the ssl server trust provider
  on Windows.
* subversion/libsvn_subr/ssl_server_trust_providers.c
  (windows_ssl_server_trust_first_credentials, windows_server_trust_provider,
  svn_auth_get_windows_ssl_server_trust_provider): Implementation of the ssl
  server certificate provider.

Patch by: Bert Huijben <bhuijben@competence.biz>
          me

Revision 863368 - (view) (download) (annotate) - [select for diffs]
Modified Tue Jan 30 20:17:41 2007 UTC (17 years, 5 months ago) by lgo
File length: 15567 byte(s)
Diff to previous 863366 (colored)
Follow up r23292: use the correct define to attach the crash handler.

Review by: dlr

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): use the SVN_USE_WIN32_CRASHHANDLER define to conditionally
   attach the crash handler.


Revision 863366 - (view) (download) (annotate) - [select for diffs]
Modified Tue Jan 30 19:13:52 2007 UTC (17 years, 5 months ago) by lgo
File length: 15561 byte(s)
Diff to previous 863352 (colored)
Add a define SVN_USE_WIN32_CRASHHANDLER that enables building the crash 
handler, define it by default. 

Suggested by: Stefan Küng <tortoisesvn@gmail.com>

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): only attach the crash handler when wanted.

* subversion/libsvn_subr/win32_crashrpt.c
* subversion/libsvn_subr/win32_crashrpt.h
* subversion/libsvn_subr/win32_crashrpt_dll.h:
  Make the windows crash handler code conditional on the 
   SVN_USE_WIN32_CRASHHANDLER define.

* build/generator/gen_win.py
  (get_win_defines): add the SVN_USE_WIN32_CRASHHANDLER define on the 
   libsvn_subr target by default.


Revision 863352 - (view) (download) (annotate) - [select for diffs]
Modified Mon Jan 29 19:43:13 2007 UTC (17 years, 6 months ago) by lgo
File length: 15526 byte(s)
Diff to previous 863313 (colored)
Fixes in the crash handler to better match our project standards.

Review by: malcolm

* subversion/libsvn_subr/win32_crashrpt.h
  (svn_unhandled_exception_filter): function is internal to libsvn_subr, 
   rename to svn__unhandled_exception_filter

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): call the renamed function

* subversion/libsvn_subr/win32_crashrpt.c
  (write_to_file): remove obsolete function
  (exception_string): undefine EXCEPTION
  (write_module_info_callback, write_process_info, write_var_values,
   write_function_detail, svn__unhandled_exception_filter):
   replace write_to_file with fprintf.
  (write_function_detail): remove unneeded parameter in fprintf call
  (write_var_values): remove unneeded casting of value_str


Revision 863313 - (view) (download) (annotate) - [select for diffs]
Modified Thu Jan 25 20:39:34 2007 UTC (17 years, 6 months ago) by lgo
File length: 15525 byte(s)
Diff to previous 862088 (colored)
Add a Windows-specific crash handler, capable of dumping module info and
stack information in log and minidump format on disk.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): On Windows attach the crash handler.

* subversion/libsvn_subr/win32_crashrpt.c
* subversion/libsvn_subr/win32_crashrpt.h: New files, implement the crash
   handler.

* subversion/libsvn_subr/win32_crashrpt_dll.h: New file, definitions of the
   exported functions in the dbghelp, version and kernel32 DLL's.


Revision 862088 - (view) (download) (annotate) - [select for diffs]
Modified Wed Oct 18 01:11:47 2006 UTC (17 years, 9 months ago) by rooneg
File length: 15380 byte(s)
Diff to previous 862080 (colored)
Fix typo from r22006 so we correctly use windows crypto on non-MinGW builds.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_setup_auth_baton): Actually ifdef correctly for MinGW.


Revision 862080 - (view) (download) (annotate) - [select for diffs]
Modified Tue Oct 17 21:13:41 2006 UTC (17 years, 9 months ago) by rooneg
File length: 15378 byte(s)
Diff to previous 861070 (colored)
Disable the windows specific auth provider when building under MinGW
since it doesn't currently compile due to defficiencies in the MinGW
headers.

Submitted by: Paul Querna <chip@force-elite.com>
Tweaked by: me

* subversion/include/svn_client.h
  (svn_client_get_windows_simple_provider): Don't declare on MinGW.

* subversion/include/svn_auth.h
  (svn_auth_get_windows_simple_provider): Ditto.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_setup_auth_baton): Only add the windows simple provider
   when we aren't built with MinGW.

* subversion/libsvn_client/compat_providers.c
  (svn_client_get_windows_simple_provider): Don't define if we're built
   on MinGW.

* subversion/libsvn_subr/simple_providers.c
  (description, windows_crypto_type, get_crypto_function,
   windows_password_encrypter, windows_password_decrypter,
   windows_simple_first_creds, windows_simple_save_creds,
   windows_simple_provider, svn_auth_get_simple_provider): Don't define
   if we're built on MinGW.


Revision 861070 - (view) (download) (annotate) - [select for diffs]
Modified Mon Aug 7 16:56:48 2006 UTC (17 years, 11 months ago) by rooneg
File length: 15349 byte(s)
Diff to previous 860648 (colored)
Make --enable-dso work in the face of global bdb environment caching.

Really this time.

This adds a custom wrapper for APR's dso loading code, which loads the
DSOs into a global pool that will persist long enough that we don't risk
having the DSO unloaded before any cleanup functions it registered are
called.  Note that this only works if the new initialization function is
called early enough, otherwise we are still vulnerable to the problem.

Note that I have marked the new functions as being added in 1.4.0, if we
do not backport this revision to 1.4.x then this will have to be changed.

* subversion/include/svn_dso.h: New header.

* subversion/libsvn_subr/dso.c: New function, holds the DSO wrapper code.

* subversion/libsvn_ra/ra_loader.c
  Stop including apr_dso.h.  Include svn_dso.h.
  (load_ra_module): Use svn_dso_load instead of apr_dso_load.

* subversion/libsvn_fs/fs-loader.c
  Remove include of apr_dso.h, add include of svn_dso.h.
  (load_module): Use svn_dso_load, not apr_dso_load.

* subversion/libsvn_subr/cmdline.c
  Include svn_dso.h.
  (svn_cmdline_init): Call svn_dso_initialize.

* subversion/mod_dav_svn/mod_dav_svn.c
  Include svn_dso.h.
  (init_dso): New hook function.
  (register_hooks): Register init_dso to be called as early as possible.


Revision 860648 - (view) (download) (annotate) - [select for diffs]
Modified Tue Jul 11 20:59:30 2006 UTC (18 years ago) by maxb
File length: 15246 byte(s)
Diff to previous 860182 (colored)
1.4.x API: Fix svn_cmdline__getopt_init() to obey pool parameter
convention.

* subversion/include/svn_cmdline.h (svn_cmdline__getopt_init),
* subversion/libsvn_subr/cmdline.c (svn_cmdline__getopt_init):
  Re-order parameters.
  
* subversion/svn/main.c (main),
* subversion/svnadmin/main.c (main),
* subversion/svndumpfilter/main.c (main),
* subversion/svnlook/main.c (main),
* subversion/svnserve/main.c (main),
* subversion/svnsync/main.c (main),
* subversion/svnversion/main.c (main),
* subversion/tests/svn_test_main.c (main):
  Adjust calls.


Revision 860182 - (view) (download) (annotate) - [select for diffs]
Modified Wed Jun 14 22:26:13 2006 UTC (18 years, 1 month ago) by djh
File length: 15246 byte(s)
Diff to previous 859519 (colored)
Fix input/output encoding support when built with VC2005.

Newer versions of MS' CRT do the codepage translation for us
so we don't need to do it ourselves if the compiler is new
enough.

Found by: Jens Peters <jpeters7677@gmx.de>
Review by: brane

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): VC2005 doesn't need to do special encoding.



Revision 859519 - (view) (download) (annotate) - [select for diffs]
Modified Fri Apr 21 20:30:49 2006 UTC (18 years, 3 months ago) by lundblad
File length: 15197 byte(s)
Diff to previous 859397 (colored)
Make locale handling more forgiving in the clients.

Patch by: Peter Samuelson <peter@p12n.org>
(Style tweak by me.)

* subversion/libsvn_subr/cmdline.c (svn_cmdline_init): Try setting both
  LC_ALL and LC_CTYPE locale variables, warning only if both fail.
  Do not consider this a fatal error.


Revision 859397 - (view) (download) (annotate) - [select for diffs]
Modified Wed Apr 12 12:46:56 2006 UTC (18 years, 3 months ago) by pburba
File length: 15182 byte(s)
Diff to previous 858610 (colored)
Rev svn_utf_cstring_*_utf8_ex so xlate_handle_node_t structs are
cached based on the conversion taking place rather than a string
key argument.

Review by: lundblad
           julianfoad

* subversion/include/svn_utf.h
  (svn_utf_cstring_to_utf8_ex2, svn_utf_cstring_from_utf8_ex2): New.
  (svn_utf_cstring_to_utf8_ex, svn_utf_cstring_from_utf8_ex):
  Deprecate.

* subversion/libsvn_subr/cmdline.c
  (SVN_UTF_CONTOU_XLATE_HANDLE, SVN_UTF_UTOCON_XLATE_HANDLE,
  SVN_UTF_ETOU_XLATE_HANDLE): Remove.
  (svn_cmdline_cstring_from_utf8, svn_cmdline_cstring_to_utf8,
  svn_cmdline__getopt_init): Change calls to svn_utf_cstring_*_utf8_ex
  to use svn_utf_cstring_*_utf8_ex2.

* subversion/libsvn_subr/io.c
  (SVN_UTF_ETOU_XLATE_HANDLE, SVN_UTF_UTOE_XLATE_HANDLE): Remove.
  (svn_io_create_unique_link, svn_io_read_link): Change calls to
   svn_utf_cstring_*_utf8_ex to use svn_utf_cstring_*_utf8_ex2.

* subversion/libsvn_subr/utf.c
  (get_xlate_key): New function.
  (convert_cstring): Update doc string.
  (svn_utf_cstring_to_utf8_ex2): New.
  (svn_utf_cstring_to_utf8_ex): Reimplement as wrapper around
  svn_utf_cstring_to_utf8_ex2.
  (svn_utf_cstring_from_utf8_ex2): New.
  (svn_utf_cstring_from_utf8_ex): Reimplement as wrapper around
  svn_utf_cstring_from_utf8_ex2.

* subversion/libsvn_client/diff.c,
  subversion/libsvn_diff/diff_file.c,
  subversion/libsvn_repos/hooks.c,
  subversion/libsvn_subr/stream.c,
  subversion/libsvn_subr/subst.c,
  subversion/svn/util.c:
  Change all callers of svn_utf_cstring_*_utf8_ex to use
  svn_utf_cstring_*_utf8_ex2.

Revision 858610 - (view) (download) (annotate) - [select for diffs]
Modified Mon Feb 20 21:47:33 2006 UTC (18 years, 5 months ago) by pburba
File length: 15644 byte(s)
Diff to previous 858609 (colored)
OS400/EBCDIC Port: Convert string args to EBCDIC for functions that
require it.

This is one of several patches to allow Subversion to run
on IBM's OS400 V5R4.

Despite V5R4's UTF support, a handful of functions on OS400 still
require EBCDIC encoded string arguments.

Approved by: Peter Lundblad <peter@famlundblad.se>

* subversion/libsvn_subr/cmdline.c
   (svn_cmdline_init): Convert string args to open() to EBCDIC.

* subversion/libsvn_subr/io.c
   (SVN_UTF_UTOE_XLATE_HANDLE): New xlate key for UTF-8 (CCSID 1208)
    to EBCDIC (CCSID 0) conversions.
   (svn_io_create_unique_link): Convert string args to symlink() to
    EBCDIC.
   (svn_io_read_link): Convert string args to readlink() to EBCDIC. 

Revision 858609 - (view) (download) (annotate) - [select for diffs]
Modified Mon Feb 20 21:39:55 2006 UTC (18 years, 5 months ago) by pburba
File length: 15389 byte(s)
Diff to previous 858553 (colored)
OS400/EBCDIC Port: Convert command-line arguments from EBCDIC to UTF-8.

This is one of several patches to allow Subversion to run on IBM's
OS400 V5R4.  Despite IBM's building of APR/Apache with UTF support in
V5R4, command line arguments to main() are still encoded in EBCDIC.

To avoid const restrictions and allow EBCDIC to UTF-8 conversion of 
command line arguments in place, the signature of main() in all command
line programs is standardized to main(int argc, const char *argv[]).

Approved by: Julian Foad <julianfoad@btopenworld.com>

Suggestions by: Julian, Philip Martin <philip@codematters.co.uk>, and
                Brane <brane@xbc.nu>
 
* subversion/include/svn_cmdline.h
   Include apr_getopt.h
   (svn_cmdline__getopt_init): New function declaration.

* subversion/libsvn_subr/cmdline.c
   (SVN_UTF_ETOU_XLATE_HANDLE): New xlate key for EBCDIC (CCSID 0) to
    UTF-8 (CCSID 1208) conversions.
   (svn_cmdline__getopt_init): New function definition.

* subversion/svn/main.c
* subversion/svnadmin/main.c
* subversion/svndumpfilter/main.c
* subversion/svnlook/main.c
* subversion/svnserve/main.c
* subversion/svnsync/main.c
* subversion/svnversion/main.c
   (main): Standardize signature and replace call to apr_getopt_init()
    with new wrapper function svn_cmdline__getopt_init().

Revision 858553 - (view) (download) (annotate) - [select for diffs]
Modified Thu Feb 16 13:40:31 2006 UTC (18 years, 5 months ago) by pburba
File length: 14468 byte(s)
Diff to previous 858545 (colored)
OS400/EBCDIC Port: Handle xlate page differences.

This is one of several patches to allow Subversion to run on IBM's
OS400 V5R4.

OS400 uses integers (Coded Character Set Identifiers or CCSIDs in 
IBM-speak) to represent charsets rather than strings, e.g. 1208 vs.
"UTF-8".  This has two implications for the subversion code:

  1) apr_xlate_open() has a different signature, taking ints for topage
     and frompage. 

  2) APR_DEFAULT_CHARSET and APR_LOCALE_CHARSET are of type int not
     const char *.

The addition of new "wrapper" symbols for APR_DEFAULT_CHARSET and
APR_LOCALE_CHARSET address the bulk of these problems, leaving only
some minor error message creation tweaks.

Approved By: Philip Martin <philip@codematters.co.uk>

* subversion/include/svn_utf.h
   (SVN_APR_LOCALE_CHARSET, SVN_APR_DEFAULT_CHARSET): New symbol
    replacements for APR_LOCALE_CHARSET and APR_DEFAULT_CHARSET
    respectively.

* subversion/libsvn_client/diff.c
   (svn_client_diff2, svn_client_diff_peg2):
* subversion/libsvn_diff/diff_file.c
   (svn_diff_file_output_unified):
* subversion/libsvn_subr/cmdline.c
   (svn_cmdline_output_encoding):
    Use SVN_APR_LOCALE_CHARSET in place of APR_LOCALE_CHARSET.

* subversion/libsvn_subr/utf.c
   (SVN_APR_UTF8_CHARSET) New symbolic constant.
   (get_xlate_handle_node): Use SVN_APR_DEFAULT_CHARSET and
    SVN_APR_LOCALE_CHARSET in place of APR_DEFAULT_CHARSET and
    APR_LOCALE_CHARSET respectively.  Disable assert that doesn't
    apply to V5R4 and handle error condition this may now permit.
    Cast arguments to apr_xlate_open() to agree with OS400 signature.
   (convert_to_stringbuf): Account for fact xlate_handle_node_t
    topage and frompage members are always ints on OS400 when
    creating error messages.

Revision 858545 - (view) (download) (annotate) - [select for diffs]
Modified Wed Feb 15 21:30:49 2006 UTC (18 years, 5 months ago) by kfogel
File length: 14464 byte(s)
Diff to previous 857693 (colored)
Reformat the code to use a consistent no-space-before-param-list-paren style.
See here for the vote that decided this:

   http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=111877
   From: "Peter N. Lundblad" <peter@famlundblad.se>
   To: "Peter N. Lundblad" <peter@famlundblad.se>
   cc: dev@subversion.tigris.org
   Subject: Results of: [VOTE] New space-before-parens style
   Date: Wed, 8 Feb 2006 12:00:35 +0100 (CET)
   Message-ID: <Pine.LNX.4.55.0602080918350.10805@localhost.localdomain>

I took the opportunity to make spacing among all parens in SVN_ERR
macro calls consistent.  But I did not address consistency of casts,
nor whether a function name should always appear below its return type
in declarations and definitions, nor whether there should be a space
before/after the "*" when declaring pointer return types.

* www/hacking.html
  (coding-style): Document that we are no-space-before-paren now.

* everywhere: Reformat.


Revision 857693 - (view) (download) (annotate) - [select for diffs]
Modified Sun Dec 4 02:16:04 2005 UTC (18 years, 7 months ago) by mbk
File length: 14575 byte(s)
Diff to previous 857365 (colored)
On Mac OS, use KeyChain services to store password (Issue 2339).

Note: SecKeychainSetUserInteractionAllowed (FALSE) does not appear to
actually prevent all user interaction.  Specifically, if the executable
changes (for example, if it is rebuilt), the system prompts the user
to okay the use of the new executable.

I'm not sure if I'm doing something wrong, or if this is a genuine bug
in the KeyChain implementation itself.

Suggested by: Wilfredo Sánchez <wsanchez@wsanchez.net>
Patch by: Ken Allan <k.allan@au.darkbluesea.com>
          Wilfredo Sánchez <wsanchez@wsanchez.net>
          me
Review by: djames


* Makefile.in:
  Add SVN_KEYCHAIN_LIBS, an autoconf substituted variable.
  Add SVN_KEYCHAIN_INCLUDES to INCLUDES.

* build.conf:
  Define keychain, an external lib, using the SVN_KEYCHAIN_LIBS variable.
  Add keychain to the libs for the svn exe.

* configure.in:
  Add --enable-keychain/--disable-keychain configury.  Default to enabled,
  if the appropriate OS and version are detected.

* subversion/include/svn_auth.h:
  (svn_auth_get_keychain_simple_provider): New prototype.

* subversion/libsvn_subr/cmdline.c:
  #include "svn_auth.h"
  (svn_cmdline_setup_auth_baton): Add keychain provider to list,
   and though not strictly required, increase the initial array size
   accordingly.

* subversion/libsvn_subr/simple_providers.c:
  #include "svn_private_config.h"
  (SVN_AUTH__KEYCHAIN_PASSWORD_TYPE): New password-type macro.
  Conditionally #include <Security/Security.h>
  (keychain_password_set, keychain_password_get, keychain_simple_first_creds,
   keychain_simple_save_creds, svn_auth_get_keychain_simple_provider): New
   functions.
  (keychain_simple_provider): New svn_auth_provider_t instance.


Revision 857365 - (view) (download) (annotate) - [select for diffs]
Modified Thu Nov 10 18:23:52 2005 UTC (18 years, 8 months ago) by rooneg
File length: 14382 byte(s)
Diff to previous 857271 (colored)
Fix a crash in the command line client's prompting code.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_setup_auth_baton): Correct setup of the prompt providers,
   they take a pointer to the prompt baton, not a pointer to a pointer
   to the prompt baton...


Revision 857271 - (view) (download) (annotate) - [select for diffs]
Modified Fri Nov 4 18:52:20 2005 UTC (18 years, 8 months ago) by rooneg
File length: 14387 byte(s)
Diff to previous 856366 (colored)
Move the command line client's auth baton setup into libsvn_subr so it
can be reused by other applications.

* subversion/include/svn_cmdline.h
  (svn_cmdline_setup_auth_baton): New function prototype.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_setup_auth_baton): New function, holds the logic that
   used to live in the command line client.

* subversion/clients/cmdline/main.c
  (main): Use svn_cmdline_setup_auth_baton to set up our auth baton.


Revision 856366 - (view) (download) (annotate) - [select for diffs]
Modified Tue Sep 27 05:15:18 2005 UTC (18 years, 10 months ago) by rooneg
File length: 9343 byte(s)
Diff to previous 856318 (colored)
Don't bother with a wrapper around apr_initialize and apr_atomic_init,
since apr_initialize already calls apr_atomic_init for us.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): use apr_initialize, not svn_apr_initialize.
  (svn_apr_initialize): removed.


Revision 856318 - (view) (download) (annotate) - [select for diffs]
Modified Sun Sep 25 02:22:00 2005 UTC (18 years, 10 months ago) by brane
File length: 9594 byte(s)
Diff to previous 855448 (colored)
Remove knowledge about the admin directory name from the public
API, preparing the way for run-time parameterisation.

NOTES:
  - _svn is now always a reserved name, just like .svn.
  - On Windows, setting the environment variable SVN_ASP_DOT_NET_HACK
    will change the admin dir name to "_svn".

* subversion/include/svn_wc.h
  (svn_wc_is_adm_dir, svn_wc_set_adm_dir): New prototypes.
  (SVN_WC_ADM_DIR_NAME): Deprecate.

* subversion/libsvn_wc/adm_files.c: Include apr_atomic.h.
  (DEFAULT_ADM_DIR_NAME): New constant.
  (adm_dir_name) New file-scope variable.
  (svn_wc_is_adm_dir, svn_wc_set_adm_dir): Implement.
  (v_extend_with_adm_name): Use adm_dir_name instead of SVN_WC_ADM_DIR_NAME.

* subversion/libsvn_subr/cmdline.c: Include apr_atomic.h and apr_pools.h.
  (svn_apr_initialize): New. Initialization for apr and apr-atomic.
  (svn_cmdline_init) Use svn_apr_initialize instead of apr_initialize.

* subversion/libsvn_wc/copy.c (post_copy_cleanup): Call svn_wc__adm_path
   to construct the path to the admin directory.

* subversion/libsvn_wc/adm_ops.c (erase_from_wc),
  subversion/libsvn_wc/status.c (get_dir_status),
  subversion/libsvn_wc/update_editor.c (add_directory),
  subversion/libsvn_client/add.c (add_dir_recursive),
  subversion/libsvn_client/commit.c (import_dir, svn_client_import2):
   Call svn_wc_is_adm_dir instead of strcmp'ing with SVN_WC_ADM_DIR_NAME.

* subversion/libsvn_subr/opt.c (svn_opt_args_to_target_array2):
   Check all valid admin dir names and document the fact that this
   list a non-canonical copy.

* subversion/clients/cmdline/main.c,
  subversion/svnversion/main.c,
  tools/examples/minimal_client.c: On Windows, if the environment variable
   SVN_ASP_DOT_NET_HACK is set, change the admin dir name to "_svn".

* win-tests.py: Add option --asp.net-hack to test with "_svn".

* subversion/tests/clients/cmdline/svntest/main.py (get_admin_name):
   Return '.svn' or '_svn', depending on the environment.

* subversion/tests/clients/cmdline/basic_tests.py,
  subversion/tests/clients/cmdline/cat_tests.py,
  subversion/tests/clients/cmdline/trans_tests.py,
  subversion/tests/clients/cmdline/update_tests.py:
   Use svntest.main.get_admin_name() instead of explicit '.svn'.


Revision 855448 - (view) (download) (annotate) - [select for diffs]
Modified Thu Jul 21 03:28:44 2005 UTC (19 years ago) by kou
File length: 9262 byte(s)
Diff to previous 855430 (colored)
Fix documentation and coding style.
Follow-up to r15343.

* subversion/include/svn_nls.h
  (svn_nls_environment_init,
   svn_nls_init): Docstring fixes.

* subversion/libsvn_subr/cmdline.c (svn_cmdline_init),
  subversion/libsvn_subr/nls.c (svn_nls_environment_init):
  - Use err instead of error as svn_error_t * variable name.
  - Fix coding style.

* subversion/libsvn_subr/nls.c(svn_nls_init): Fix coding style.

Approbed by: +1: lundblad
Review by: Peter N. Lundblad <peter@famlundblad.se>
           Branko ÄŒibej <brane@xbc.nu>


Revision 855430 - (view) (download) (annotate) - [select for diffs]
Modified Mon Jul 18 09:58:18 2005 UTC (19 years ago) by brane
File length: 9252 byte(s)
Diff to previous 855417 (colored)
Fix Windows build -- include necessary header files.

Patch by: Kouhei Sutou <kou@cozmixng.org>

* subversion/libsvn_subr/cmdline.c: Move
  '#include "arch/win32/apr_arch_utf8.h"' to
  subversion/libsvn_subr/nls.c.

* subversion/libsvn_subr/nls.c: Include svn_path.h and
  arch/win32/apr_arch_utf8.h.


Revision 855417 - (view) (download) (annotate) - [select for diffs]
Modified Fri Jul 15 05:06:55 2005 UTC (19 years ago) by kou
File length: 9552 byte(s)
Diff to previous 855392 (colored)
Extract NLS initialization code from svn_cmdline_init.

* subversion/libsvn_subr/nls.c
  (svn_nls_environment_init): Initialize NLS environment.
  (svn_nls_init): Initialize NLS environment and set up
  text domain.

* subversion/include/svn_nls.h: Add.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): Extract NLS initialization code.

Approved by: Garrett Rooney <rooneg@electricjellyfish.net>


Revision 855392 - (view) (download) (annotate) - [select for diffs]
Modified Mon Jul 11 20:26:48 2005 UTC (19 years ago) by kfogel
File length: 11300 byte(s)
Diff to previous 854631 (colored)
Finish the abstraction started in r15240 and r15241: Define the standard
command-line error handler in one place instead of N places.

* subversion/include/svn_cmdline.h, subversion/libsvn_subr/cmdline.c
  (svn_cmdline_handle_exit_error): New function.

* subversion/clients/cmdline/main.c
  (error_exit): Remove.
  (main): Use svn_cmdline_handle_exit_error.

* subversion/svnlook/main.c
  (error_exit): Remove.
  (main): Use svn_cmdline_handle_exit_error.

* subversion/svnadmin/main.c
  (error_exit): Remove.
  (main): Use svn_cmdline_handle_exit_error.

* subversion/svndumpfilter/main.c
  (error_exit): Remove.
  (main): Use svn_cmdline_handle_exit_error.


Revision 854631 - (view) (download) (annotate) - [select for diffs]
Modified Mon May 2 19:01:09 2005 UTC (19 years, 2 months ago) by lundblad
File length: 11003 byte(s)
Diff to previous 853718 (colored)
Fix issue #1533: Make svn diff output headers in the output encoding.

* subversion/include/svn_diff.h (svn_diff_file_output_unified2): New function,
  adding the header_encoding argument.
  (svn_diff_file_output_unified): Deprecate.

* subversion/include/svn_io.h (svn_stream_printf_from_utf8),
* subversion/include/svn_cmdline.h (svn_cmdline_output_encoding): New function.

* subversion/include/svn_client.h (svn_client_diff3, svn_client_diff_peg3): 
  New functions, adding header_encoding argument.
  (svn_client_diff2, svn_client_diff_peg2): Deprecate.

* subversion/libsvn_diff/diff_file.c
  (svn_diff__file_output_baton_t): Add header_encoding, context_str,
  delete_str and insert_str members.
  (svn_diff__file_output_unified_line): Use new *_str members in baton to
  output markers.  Translate headers to the header encoding.  Mark a string
  for translation.
  (svn_diff__file_output_unified_flush_hunk): Translate headers to header
  encoding.
  (svn_diff_file_output_unified2): Rename from below.  Add header_encoding
  argument.  Initialize new baton members.  Translate headers to header
  encoding.
  (svn_diff_file_output_unified): New function, wrapping above.

* subversion/libsvn_subr/cmdline.c (svn_cmdline_output_encoding): New function.

* subversion/libsvn_subr/stream.c (svn_stream_printf): Fix whitespace.
  (svn_stream_printf_from_utf8): New function.

* subversion/svnlook/main.c (print_diff_tree): Don't use deprecated functioin;
  output in output encoding.

* subversion/libsvn_client/diff.c: Change comments referring to
  svn_client_diff2 to talk about svn_client_diff3.
  (file_printf_from_utf8): Add encoding argument.  Callers updated.
  Translate to that encoding.  Whitespace fix.
  (display_prop_diffs): Add encoding argument, translating output to that
  encoding.  Callers updated.
  (diff_cmd_baton): Add header_encoding member.
  (diff_content_changed): Output headers in header encoding.
  (svn_client_diff3, svn_client_diff_peg3): Rename from below, adding
  header_encoding argument.  Initialize baton member with the same name.
  (svn_client_diff2, svn_client_diff_peg2): New function, wrapping the above.

* subversion/clients/cmdline/diff-cmd.c (svn_cl__diff): Don't use
  deprecated functions; translate diff output to output encoding.


Revision 853718 - (view) (download) (annotate) - [select for diffs]
Modified Thu Mar 24 20:32:20 2005 UTC (19 years, 4 months ago) by ehu
File length: 10830 byte(s)
Diff to previous 853256 (colored)
Surrender to the fact that we cannot consistently prevent message translation
across platforms: consistently obey locale settings. Also see
http://svn.collab.net/repos/svn/trunk/notes/l10n-problems

Revert r13182.

Note: mod_dav_svn already obeyed locale settings, so we're now consistent
across servers and platforms.

Additional change:

* subversion/svnserve/main.c (main): Don't change locale settings before
  going into server mode.


Revision 853256 - (view) (download) (annotate) - [select for diffs]
Modified Sun Feb 27 21:43:31 2005 UTC (19 years, 5 months ago) by ehu
File length: 11122 byte(s)
Diff to previous 852254 (colored)
Fix svnserve error message translation by postponing locale initialization.

* subversion/include/svn_cmdline.h,
  subversion/libsvn_subr/cmdline.c (svn_cmdline_init): Deprecated.
  (svn_cmdline_init2): New. Derived from svn_cmdline_init, but takes
   an extra 'server_mode' boolean parameter.

* subversion/clients/cmdline/main.c,
  subversion/svnadmin/main.c,
  subversion/svndumpfilter/main.c,
  subversion/svnlook/main.c: Update calls to svn_cmdline_init2.

* subversion/svnserve/main.c: Set LC_ALL locale before calling _() (and
  thus gettext()) to ensure getting the correct translation. Also,
  don't translate messages which may be sent to the client.


Revision 852254 - (view) (download) (annotate) - [select for diffs]
Modified Mon Dec 6 11:26:58 2004 UTC (19 years, 7 months ago) by jszakmeister
File length: 10830 byte(s)
Diff to previous 852232 (colored)
Get rid of an undefined label warning under Linux.

* subversion/subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): Move the utf8_error handling inside the WIN32
  preprocessor block.



Revision 852232 - (view) (download) (annotate) - [select for diffs]
Modified Sun Dec 5 02:39:42 2004 UTC (19 years, 7 months ago) by jszakmeister
File length: 10814 byte(s)
Diff to previous 852231 (colored)
* subversion/subversion/libsvn_subr/cmdline.c
  Remove the include for mbctype.h as it is no longer necessary.



Revision 852231 - (view) (download) (annotate) - [select for diffs]
Modified Sun Dec 5 02:32:42 2004 UTC (19 years, 7 months ago) by jszakmeister
File length: 10836 byte(s)
Diff to previous 852146 (colored)
Clean up some more nits related to initialization on Win9x platforms.

Suggested by: Max Bowsher <maxb@ukf.net>

* subversion/subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): Implement better error checking when obtaining the
  module path under Win9x.  Also optimized away the calls to lstrlen().


Revision 852146 - (view) (download) (annotate) - [select for diffs]
Modified Sun Nov 28 22:36:31 2004 UTC (19 years, 8 months ago) by jszakmeister
File length: 10641 byte(s)
Diff to previous 851961 (colored)
Always use the ANSI code page when converting the executable path to UTF-8 in
Win32.  

Suggested by: Max Bowsher <maxb@ukf.net>

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): Make sure to use the ANSI code page when converting the
  path, and get rid of the MB_PRECOMPOSED flag.  It doesn't make sense in this
  context.


Revision 851961 - (view) (download) (annotate) - [select for diffs]
Modified Sat Nov 13 19:27:22 2004 UTC (19 years, 8 months ago) by julianfoad
File length: 10659 byte(s)
Diff to previous 851557 (colored)
Rationalize #includes in C source files.

If a file does not use symbols from a given header, then do not include
that header.

If a file uses symbols from a given header 'H', and H was only being
included via another header that neither needs nor guarantees to include
H, then include H directly.

(By "symbols from a given header" I mean symbols that it either defines
itself or pulls in from other headers with the specific intention of
providing them to its users.)


Revision 851557 - (view) (download) (annotate) - [select for diffs]
Modified Tue Oct 19 13:42:11 2004 UTC (19 years, 9 months ago) by jszakmeister
File length: 10613 byte(s)
Diff to previous 850978 (colored)
Fix Issue #2091: svnadmin error on Win98: Can't convert module path to
UTF-8.  

* subversion/subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): if GetModuleFileNameW() fails, then fall back to the
  ANSI character version and convert it to Unicode.  This prevents
  ucs_path being passed uninitialized to apr_conv_ucs2_to_utf8().



Revision 850978 - (view) (download) (annotate) - [select for diffs]
Modified Sat Sep 11 13:49:01 2004 UTC (19 years, 10 months ago) by lundblad
File length: 10266 byte(s)
Diff to previous 850929 (colored)
Various fixes to r10788, r10796.

* include/svn_utf.h (svn_utf_initialize): Add pool argument.
* libsvn_subr/utf.c (svn_utf_initialize): Create the hashtable pool as a
  subpool of the pool passed in the new argument.
  (get_xlate_handle_node): Look for the xlate handle in the pool if there is no
  global cache.  Register a cleanup that marks the node as defunct.
  Check for defunct nodes before returning them.  e concistent about checking
  if the UTF-8 routines were initialized by checking the hash table
  (instead of sometimes checking the mutex).
  (put_xlate_handle_node): New pool argument, callers updated.  Store the
  handle in the pool if there is no global cache.  Store the handle in the
  global cache, if one, even in the single-threaded case.  Same concistency
  change as for get_xlate_handle_node.
* libsvn_subr/cmdline.c (svn_cmdline_initialize): Create a separate pool for
  the UTF-8 initialization.


Revision 850929 - (view) (download) (annotate) - [select for diffs]
Modified Wed Sep 8 20:53:26 2004 UTC (19 years, 10 months ago) by ringstrom
File length: 10147 byte(s)
Diff to previous 850893 (colored)
Check for errors when opening /dev/null as (sort of) requested by
Peter Lundblad.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): Print an error message and return if /dev/null
  cannot be opened.


Revision 850893 - (view) (download) (annotate) - [select for diffs]
Modified Sun Sep 5 15:32:02 2004 UTC (19 years, 10 months ago) by ringstrom
File length: 9989 byte(s)
Diff to previous 850862 (colored)
Prevent severe database corruption and other horrors on unix systems
if e.g. svnadmin is run with it's standard input, standard output or
standard error file descriptors closed.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): Open '/dev/null' for standard input, output and
  error if they are closed.


Revision 850862 - (view) (download) (annotate) - [select for diffs]
Modified Tue Aug 31 19:20:47 2004 UTC (19 years, 10 months ago) by lundblad
File length: 9348 byte(s)
Diff to previous 850698 (colored)
Fix issue #2016.  Cache UTF8 translation handles in a global hash table
instead of in the current pool, which improves performance, especially on
Windows.

* include/svn_utf.h (svn_utf_initialize): New function.
* libsvn_subr/utf.c (xlate_handle_mutex, xlate_handle_hash): New variables.
  (xlate_handle_node_t): New struct.
  (xlate_cleanup, svn_utf_initialize, put_xlate_handle_node): New functions.
  (get_xlate_handle_node): Renamed from get_xlate_handle and rewritten using
  a global hash table and locking in MT environments.
  (get_ntou_xlate_handle_node, get_uton_xlate_handle_node,
  svn_utf_stringbuf_to_utf8, svn_utf_string_to_utf8, svn_utf_cstring_to_utf8,
  svn_utf_cstring_to_utf8_ex, svn_utf_stringbuf_from_utf8,
  svn_utf_string_from_utf8, svn_utf_cstring_from_utf8,
  svn_utf_cstring_from_utf8_ex, svn_utf_cstring_from_utf8_string): Use
  {get,put}_xlate_handle_node for the
  xlate handle.
* libsvn_subr/cmdline.c (svn_cmdline_initialize): Initialize UTF-8 routines.


Revision 850698 - (view) (download) (annotate) - [select for diffs]
Modified Fri Aug 13 22:50:27 2004 UTC (19 years, 11 months ago) by ehu
File length: 9282 byte(s)
Diff to previous 850697 (colored)
Revert accidental commit r10623.

Revision 850697 - (view) (download) (annotate) - [select for diffs]
Modified Fri Aug 13 22:45:44 2004 UTC (19 years, 11 months ago) by ehu
File length: 9918 byte(s)
Diff to previous 850204 (colored)
Fix alexis bots accepting /msg input where they were not allowed in /query.

Revision 850204 - (view) (download) (annotate) - [select for diffs]
Modified Sat Jul 3 15:24:57 2004 UTC (20 years ago) by lundblad
File length: 9282 byte(s)
Diff to previous 849927 (colored)
Get rid of msgfmt warnings on most (or all) target systems and some
tweaks to TRANSLATING.

* configure.in: Check for bind_textdomain_codeset().
* Makefile.in: Don't strip Content-Type header from po files if
  bind_textdomain_codeset() is available.

* subversion/libsvn_subr/cmdline.c (svn_cmdline_init): Use
  bind_textdomain_codeset() if available to convert messages to UTF-8.

* TRANSLATING: Only require that po files are UTF-8 and describe that on most
  systems we now use bind_textdomain_codeset().
  Allow Last-Translator: field in po files so "msgfmt -c" (GNU gettext)
  likes the file.
  Other fixes and small clarifications.



Revision 849927 - (view) (download) (annotate) - [select for diffs]
Modified Sat May 22 14:43:46 2004 UTC (20 years, 2 months ago) by lundblad
File length: 9189 byte(s)
Diff to previous 849919 (colored)
Fix error handling in cmdline stdio function.s.

* libsvn_subr/cmdline.c (svn_cmdline_fputs, svn_cmdline_fflush): Use errno
instead of apr_{set,get}_os_error(), which hopefully works on Win32.


Revision 849919 - (view) (download) (annotate) - [select for diffs]
Modified Fri May 21 21:55:51 2004 UTC (20 years, 2 months ago) by lundblad
File length: 9201 byte(s)
Diff to previous 849880 (colored)
We also need to check errors on fflush calls because of stdio buffering
(sigh!!!).

This is a part of the fix for issue #780.

* libsvn_subr/cmdline.c (svn_cmdline_fflush): New function.

* clients/cmdline/main.c (main): Use svn_cmdline_fflush before a normal exit.


Revision 849880 - (view) (download) (annotate) - [select for diffs]
Modified Thu May 20 23:30:05 2004 UTC (20 years, 2 months ago) by lundblad
File length: 8930 byte(s)
Diff to previous 849778 (colored)
Actually check for write errors in svn_cmdline_printf, svn_cmdline__fprint and
svn_cmdline_fputs.

* include/svn_error_codes.h (SVN_ERR_IO_WRITE_ERROR): New error code.

* libsvn_subr/cmdline.c (svn_cmdline_fputs): Check the call of fputs()
  fo errors and return it in that case.


Revision 849778 - (view) (download) (annotate) - [select for diffs]
Modified Thu May 13 18:52:36 2004 UTC (20 years, 2 months ago) by lundblad
File length: 8379 byte(s)
Diff to previous 849490 (colored)
Implement new functions for printf, fprintf and fputs for use in
command line programs.

Approved by brane.

* subversion/include/svn_cmdline.h:
* subversion/libsvn_subr/cmdline.c:
  (svn_cmdline_printf, svn_cmdline_fprintf, svn_cmdline_fputs):
  New functions.




Revision 849490 - (view) (download) (annotate) - [select for diffs]
Modified Sun Apr 18 18:32:14 2004 UTC (20 years, 3 months ago) by djh
File length: 7053 byte(s)
Diff to previous 849482 (colored)
Fix gettext initialization issues on Win32 pointed out by
Brane.

* svn_private_config.hw
  Add define for SVN_LOCALE_RELATIVE_PATH.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): Tweak Win32 gettext initialization
  to use unicode version of the GetModuleFileName api and
  convert it to utf8 for internal handling.



Revision 849482 - (view) (download) (annotate) - [select for diffs]
Modified Sat Apr 17 23:51:15 2004 UTC (20 years, 3 months ago) by djh
File length: 6191 byte(s)
Diff to previous 849317 (colored)
Update the Win32 vcproj project generator to handle gettext and
localization requirements.  Dsp generator changes coming.

* build.conf
  Add external-project path to locale target for Win32.

* build/win32/svn_locale.vcproj
  New project file for locale build target.

* build/generator/build_locale.ezt
  New batch file template for creating localization files.

* build/generator/gen_vcnet_vcproj.py
  Add support for the new TargetI18N target type.

* build/generator/gen_base.py
  (TargetI18N.__init__): Read in the external-project option.

* build/generator/gen_win.py
  Add --enable-nls option.  If it's on then populate the
  build_locale.bat file with the .po file targets and setup the
  appropriate defines and link settings.

* svn_private_config.hw
  Define N_, _, PACKAGE_NAME appropriately and stub in a
  SVN_LOCALE_DIR for now.

* gen-make.py
  Add Windows-specific --enable-nls option.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): Setup gettext support for Win32 which involved
  moving the gettext initialization to after apr initialization so
  it's functionality could be used.



Revision 849317 - (view) (download) (annotate) - [select for diffs]
Modified Wed Mar 31 08:53:33 2004 UTC (20 years, 4 months ago) by jerenkrantz
File length: 5460 byte(s)
Diff to previous 849316 (colored)
Minor fixups to gettext build support added in r9242.

* Makefile.in: Add .mo to suffixes to clean up.
* subversion/libsvn_subr/cmdline.c: Add back in <locale.h> include as we
  need it for setlocale() even if --disable-nls is passed or we are on Win32.


Revision 849316 - (view) (download) (annotate) - [select for diffs]
Modified Wed Mar 31 08:32:29 2004 UTC (20 years, 4 months ago) by jerenkrantz
File length: 5406 byte(s)
Diff to previous 849034 (colored)
Add gettext build support to begin i18n work.  (Place your po's in po/ and go.)

* Makefile.in: Add localedir, MSGFMT, PACKAGE_NAME, PACKAGE_VERSION substs from
  configure; define INSTALL_LOCALE as INSTALL_DATA; add SUFFIXES information
  so we can make mo's from po's.
* build.conf: Add i18n target called 'locale'.
* configure.in: Remove old placeholder for GNU gettext and move down to a
  more sensible location; allow --disable-nls to override use of gettext;
  add in i18n support iff msgfmt is in PATH and bindtextdomain is available;
  export SVN_LOCALE_DIR properly escaped so svn_cmdline_init can use;
  add gettext macro snippet to bottom of svn_private_config.h as necessary;
  if NLS is enabled, add in locale/install-locale targets to our default.
* build/ac-macros/svn-macros.m4: Import APR_EXPAND_VAR from apr_common.m4.
* build/generator/gen_base.py: Define TargetI18N class to represent po files.
  (_sorted_files): Add in any NONLIB non-Target classes when we do not
  have a filename.  This also fixes an outstanding bug in gen_make.py.
* build/generator/gen_make.py: Add appropriate defines for TargetI18N class;
  Remove kludge with blank filename (see gen_base.py as to why); if we are
  doing the 'locale' target, construct a suitable install line for each mo.
* subversion/libsvn_subr/opt.c (svn_opt_print_help): Add _() to the default
  help when there are no arguments.  (This is an easy test case to start with.)
* subversion/libsvn_subr/cmdline.c: 
  (svn_cmdline_init): Change setlocale from LC_CTYPE to LC_ALL so our message
  locales are respected; print a slightly more helpful error message when
  setlocale fails; call bindtextdomain and textdomain to initialize
  gettext when ENABLE_NLS is defined.
* svn_private_config.hw: Fix a tpyo in a comment; add no-op #define's so that
  Win32 should still be able to build.
* po/es.po (added): Initial Spanish translation from Nicolas Lichtmaier with
  a help string added for the 'default' error message.

Tested on Solaris (native gettext) and Darwin (GNU gettext).
(Passes 'make check' on Solaris.)

Preliminary review by: Ben and Greg.
Thanks to: Nicolas Lichtmaier


Revision 849034 - (view) (download) (annotate) - [select for diffs]
Modified Wed Mar 10 15:32:17 2004 UTC (20 years, 4 months ago) by julianfoad
File length: 5242 byte(s)
Diff to previous 848090 (colored)
Set property 'svn:eol-style' consistently to 'native' on C and Python source
files and files that are only for humans to read (README, INSTALL).  Most such
files were already set this way; the files changed here had no 'svn:eol-style'.

* subversion/bindings/swig/python/__init__.py
* subversion/bindings/swig/python/svn/core.py
* subversion/libsvn_client/ctx.c
* subversion/libsvn_client/relocate.c
* subversion/libsvn_client/url.c
* subversion/libsvn_delta/cancel.c
* subversion/libsvn_delta/path_driver.c
* subversion/libsvn_diff/diff.h
* subversion/libsvn_diff/diff3.c
* subversion/libsvn_diff/diff4.c
* subversion/libsvn_diff/lcs.c
* subversion/libsvn_diff/token.c
* subversion/libsvn_diff/util.c
* subversion/libsvn_ra_svn/cram.c
* subversion/libsvn_repos/replay.c
* subversion/libsvn_subr/cmdline.c
* subversion/libsvn_subr/config_auth.c
* subversion/libsvn_subr/date.c
* subversion/libsvn_subr/stream.c
* subversion/libsvn_wc/relocate.c
* subversion/mod_authz_svn/INSTALL
* subversion/tests/README
* subversion/tests/clients/cmdline/revert_tests.py
* subversion/tests/libsvn_subr/config-test.c
* subversion/tests/libsvn_vcdiff/README
* subversion/tests/libsvn_wc/translate-test.c
* subversion/tests/python-libs/exectest.py
* subversion/tests/svn_test_editor.c
* subversion/tests/svn_tests_main.c
  Set property 'svn:eol-style' to 'native'.


Revision 848090 - (view) (download) (annotate) - [select for diffs]
Modified Tue Dec 16 16:41:14 2003 UTC (20 years, 7 months ago) by kfogel
File length: 5242 byte(s)
Diff to previous 848034 (colored)
Update copyright notices for 2004, resolving issue #1651.

(See also revision 8019, which fixed a couple of missed spots.)

Revision 848034 - (view) (download) (annotate) - [select for diffs]
Modified Mon Dec 8 20:40:28 2003 UTC (20 years, 7 months ago) by julianfoad
File length: 5242 byte(s)
Diff to previous 848009 (colored)
Format and convert text appropriately for console output.

* subversion/clients/cmdline/info-cmd.c (svn_cl__info_print_time, print_entry,
    svn_cl__info)
* subversion/clients/cmdline/log-cmd.c (log_message_receiver)
* subversion/clients/cmdline/prompt.c (maybe_print_realm)
* subversion/clients/cmdline/propdel-cmd.c (svn_cl__propdel)
* subversion/clients/cmdline/propedit-cmd.c (svn_cl__propedit)
* subversion/clients/cmdline/propget-cmd.c (svn_cl__propget)
* subversion/clients/cmdline/proplist-cmd.c (svn_cl__proplist)
* subversion/clients/cmdline/propset-cmd.c (svn_cl__propset)
* subversion/clients/cmdline/status.c (svn_cl__print_status)
  Use "svn_cmdline_cstring_from_utf8" instead of "svn_utf_cstring_from_utf8"
    to get the correct encoding for console output.
  Convert paths to local style for output: use native path separators and "."
    instead of "".

* subversion/clients/cmdline/notify.c
  (notify): Quote paths where they appear within a sentence.

* subversion/include/svn_cmdline.h
* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_path_local_style_from_utf8): New function.
  Fix comments.

* subversion/tests/clients/cmdline/schedule_tests.py (check_reversion)
* subversion/tests/clients/cmdline/svntest/tree.py (build_tree_from_skipped)
  Expect the file name to be quoted in "Reverted" and "Skipped" notifications.


Revision 848009 - (view) (download) (annotate) - [select for diffs]
Modified Fri Dec 5 00:28:52 2003 UTC (20 years, 7 months ago) by brane
File length: 4859 byte(s)
Diff to previous 847242 (colored)
Kill the SVN_WIN32 define; use WIN32 instead. This is a standard
compiler symbol on Windows, and I know of no conflicts with other
platforms.

Yes, this means I'm reversing my own decision.

* svn_private_config.hw (SVN_WIN32): Remove.

* subversion/libsvn_subr/config_impl.h,
  subversion/libsvn_subr/config.c,
  subversion/libsvn_subr/config_file.c,
  subversion/libsvn_subr/config_win.c,
  subversion/libsvn_subr/cmdline.c,
  subversion/libsvn_subr/io.c,
  subversion/libsvn_ra_local/split_url.c,
  subversion/libsvn_repos/hooks.c: Replace SVN_WIN32 with WIN32, and
  don't include svn_private_config.h if this symbol was the only
  reason for the inclusion.


Revision 847242 - (view) (download) (annotate) - [select for diffs]
Modified Wed Sep 24 00:29:40 2003 UTC (20 years, 10 months ago) by brane
File length: 4919 byte(s)
Diff to previous 846365 (colored)
Finishing issue #872 (at least until 1.0).

* subversion/include/svn_cmdline.h: New. Declare functions used by
  command-line programs.
* subversion/include/svn_pools.h (svn_cmdline_init): Moved to svn_cmdline.h.
* subversion/include/svn_subst.h (svn_subst_detranslate_string): Add
  parameter 'for_output'.

* subversion/libsvn_subr/utf_impl.h: New.
* subversion/libsvn_subr/utf.c: Include utf_impl.h.
  (svn_utf__cstring_from_utf8_fuzzy): New.

* subversion/libsvn_subr/subst.c (svn_subst_detranslate_string): New parameter
  'for_output' determines if we want the result in output or native encoding.
  Translate the string while it's still in UTF-8, and convert it afterwards.

* subversion/libsvn_subr/cmdline.c (svn_cmdline_init): Don't try to set the
  console output encoding on Windows platforms.
  (svn_cmdline_cstring_from_utf8, svn_cmdline_cstring_from_utf8_fuzzy,
   svn_cmdline_cstring_to_utf8): New. Convert to/from the output/input
  encoding.

* subversion/libsvn_subr/error.c: Convert error messages to output encoding,
  and use fuzzy conversion if precise conversion fails.

* subversion/libsvn_subr/opt.c,
  subversion/clients/cmdline/notify.c,
  subversion/clients/cmdline/info-cmd.c,
  subversion/clients/cmdline/log-cmd.c,
  subversion/clients/cmdline/ls-cmd.c,
  subversion/clients/cmdline/prompt.c,
  subversion/clients/cmdline/props.c,
  subversion/clients/cmdline/propdel-cmd.c,
  subversion/clients/cmdline/propedit-cmd.c,
  subversion/clients/cmdline/propget-cmd.c,
  subversion/clients/cmdline/proplist-cmd.c,
  subversion/clients/cmdline/propset-cmd.c,
  subversion/clients/cmdline/status.c,
  subversion/clients/cmdline/main.c,
  subversion/svnadmin/main.c,
  subversion/svndumpfilter/main.c,
  subversion/svnlook/main.c,
  subversion/svnserve/main.c,
  subversion/svnversion/main.c,
  subversion/tests/libsvn_subr/target-test.c: Use svn_cmdline functions to
  convert strings from/to the console encoding.

* subversion/clients/cmdline/status.c (print_status): Convert the author
  name to the output encoding.
  (svn_cl__print_status): Convert the path to local style while it's
  still in UTF-8.
* subversion/svnadmin/main.c (list_dblogs). Likewise.
* subversion/svnlook/main.c (do_date): Don't convert the date prop to
  local style in get_property, we do that here later on.


Revision 846365 - (view) (download) (annotate) - [select for diffs]
Modified Wed Jun 18 20:23:23 2003 UTC (21 years, 1 month ago) by philip
File length: 3973 byte(s)
Diff to previous 845383 (colored)
* subversion/libsvn_subr/cmdline.c (svn_cmdline_init): Produce a more
  verbose error message when setting the locale fails.


Revision 845383 - (view) (download) (annotate) - [select for diffs]
Modified Thu Mar 13 18:56:26 2003 UTC (21 years, 4 months ago) by brane
File length: 3337 byte(s)
Diff to previous 845176 (colored)
Fix issue 1186.

* subversion/libsvn_subr/cmdline.c (svn_cmdline_init): Reverse condition
in Windows version check.


Revision 845176 - (view) (download) (annotate) - [select for diffs]
Modified Tue Feb 25 20:51:15 2003 UTC (21 years, 5 months ago) by brane
File length: 3337 byte(s)
Diff to previous 844898 (colored)
This is a chicken-wire-and-spit fix for the 0.18 breakage on Win9x/Me
due to the SetConsole(Output)CP functions not being supported on those
platforms.

* subversion/libsvn_subr/cmdline.c (svn_cmdline_init): Don't try to set
the console codepage if we're running on a more-than-usually stupid
version of Windows.


Revision 844898 - (view) (download) (annotate) - [select for diffs]
Added Tue Feb 11 00:00:30 2003 UTC (21 years, 5 months ago) by kfogel
File length: 3000 byte(s)
Replace an unfamiliar mess with a familiar one:

* subversion/clients/init_cmdline.h: Removed.

* subversion/libsvn_subr/cmdline.c: New file.
  
* subversion/include/svn_pools.h
  (svn_cmdline_init): New prototype, here for lack of a better place.
    See also comment about possible move to APR.

* subversion/svnlook/main.c,
* subversion/svnadmin/main.c,
* subversion/svnversion/main.c,
* subversion/svnserve/main.c,
* subversion/tests/libsvn_subr/target-test.c,
* subversion/clients/cmdline/main.c: Don't include init_cmdline.h.
  (main): Call svn_cmdline_init instead of init_cmdline.


This form allows you to request diffs between any two revisions of this file. For each of the two "sides" of the diff, enter a numeric revision.


infrastructure at apache.org
ViewVC Help
Powered by ViewVC 1.1.26