Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Websockets Next: Kotlin Coroutines Support #40325

Closed
mschorsch opened this issue Apr 27, 2024 · 6 comments · Fixed by #41760
Closed

Websockets Next: Kotlin Coroutines Support #40325

mschorsch opened this issue Apr 27, 2024 · 6 comments · Fixed by #41760
Labels
area/kotlin kind/enhancement New feature or request
Milestone
3.13.0.CR1

Comments

@mschorsch
Copy link

Description

Kotlin coroutines should be supported out-of-the-box, this means suspend functions and Kotlin Flow as return type.

see also: #38473 (comment)

In the "old" websocket Implementation this is a long standing issue (#29929 (comment))

Implementation ideas

No response
@mschorsch mschorsch added the kind/enhancement New feature or request label Apr 27, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 27, 2024

/cc @geoand (kotlin)
@Ladicek
Copy link
Contributor

Ladicek commented Jul 2, 2024

I don't think we support Flow anywhere, and there's a simple extension function for Flow to convert to Multi (see https://smallrye.io/smallrye-mutiny/latest/guides/kotlin/). This is available out of the box when you use quarkus-kotlin.

I'm reducing the scope of this request to support of suspend functions, unless someone shows me where do we support Flow.
@mschorsch
Copy link
Author

mschorsch commented Jul 2, 2024 •
edited
Loading

@Ladicek Resteasy Reactive has Flow support and we use it in many of our services.
@mschorsch
Copy link
Author

Flow support was implemented in #18222 long time ago.
@Ladicek
Copy link
Contributor

Ladicek commented Jul 2, 2024

OK, I see. Well, I'll see how that goes.
@mschorsch
Copy link
Author

mschorsch commented Jul 2, 2024 •
edited
Loading

But as always, i'm happy that you takes the time to improve the Kotlin support in Quarkus.
@Ladicek Ladicek mentioned this issue Jul 8, 2024
Merged
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kotlin kind/enhancement New feature or request
2 participants
@Ladicek @mschorsch