Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@nivo/core's DotsItemSymbolProps is defined as
DotsItemSymbolProps
export interface DotsItemSymbolProps { size: number color: string borderWidth: number borderColor: string }
Conversely, @nivo/line's PointSymbolProps is defined as
PointSymbolProps
export interface PointSymbolProps { borderColor: string borderWidth: number color: string datum: Datum size: number }
@nivo/line's <Points> passes pointSymbol in to DotsItem as symbol. That works because <DotsItem> actually passes datum even though it's not declared.
<Points>
pointSymbol
DotsItem
symbol
<DotsItem>
datum
This makes it hard to implement a custom <Points> layer since -- according to the types -- those two are incompatible.
That's incompatible with
The text was updated successfully, but these errors were encountered:
@nivo/core's
DotsItemSymbolProps
is defined asConversely, @nivo/line's
PointSymbolProps
is defined as@nivo/line's
<Points>
passespointSymbol
in toDotsItem
assymbol
. That works because<DotsItem>
actually passesdatum
even though it's not declared.This makes it hard to implement a custom
<Points>
layer since -- according to the types -- those two are incompatible.That's incompatible with
The text was updated successfully, but these errors were encountered: