planner: fix index out of range in constructIndexJoinInnerSideTask #54534

joechenrh · 2024-07-10T03:45:09Z

What problem does this PR solve?

Issue Number: close #54535

Problem Summary:

When set system variable tidb_enable_inl_join_inner_multi_pattern to ON, the following SQL will get an error.

set GLOBAL tidb_enable_inl_join_inner_multi_pattern='ON';
create table ta(a1 int, a2 int, a3 int, index idx_a(a1));
create table tb(b1 int, b2 int, b3 int, index idx_b(b1));
explain SELECT /*+ inl_join(tmp) */ * FROM ta, (SELECT b1, COUNT(b3) AS cnt FROM tb GROUP BY b1, b2) as tmp where ta.a1 = tmp.b1;

ERROR 1105 (HY000): runtime error: index out of range [1] with length 1

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ti-chi-bot · 2024-07-10T03:45:16Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fixdb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

pkg/planner/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-07-10T03:45:18Z

Welcome @joechenrh!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to pingcap/tidb. 😃

ti-chi-bot · 2024-07-10T03:45:19Z

Hi @joechenrh. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2024-07-10T03:45:30Z

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hawkingrei · 2024-07-10T03:47:53Z

/ok-to-test

codecov · 2024-07-10T04:05:35Z

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.5074%. Comparing base (cf4bb51) to head (9e369c9).
Report is 1 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #54534        +/-   ##
================================================
- Coverage   74.7249%   70.5074%   -4.2176%     
================================================
  Files          1558       1559         +1     
  Lines        363817     435869     +72052     
================================================
+ Hits         271862     307320     +35458     
- Misses        72284     108403     +36119     
- Partials      19671      20146       +475

Flag	Coverage Δ
integration	`49.3923% <85.7142%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`55.1391% <ø> (-0.0503%)`	⬇️
parser	`∅ <ø> (∅)`
br	`48.4372% <ø> (+0.7107%)`	⬆️

hawkingrei · 2024-07-10T06:41:08Z

pkg/planner/core/exhaust_physical_plans.go

@@ -1455,12 +1455,13 @@ func (p *LogicalJoin) constructIndexJoinInnerSideTask(dsCopTask *CopTask, ds *Da
 		ds.TableInfo.GetPartitionInfo() == nil {
 		if len(path.IdxCols) < len(groupByCols) {
 			preferStream = false


Please add the test cases for it.

You may refer to the implementation in pkg/planner/core/issuetest/planner_issue_test.go.

joechenrh · 2024-07-11T02:26:00Z

/retest

hawkingrei · 2024-07-12T09:22:00Z

pkg/planner/core/issuetest/planner_issue_test.go

+		}
+		p = p.(base.PhysicalPlan).Children()[0]
+	}
+	require.True(t, ok)


You can use tk.MustQuery("explain xxx") to check whether the planner is right.

winoros

Just align with other test case name

winoros · 2024-07-15T01:45:51Z

pkg/planner/core/issuetest/planner_issue_test.go

@@ -86,3 +86,33 @@ func Test53726(t *testing.T) {
 			"  └─TableReader_11 2.00 root  data:TableFullScan_10",
 			"    └─TableFullScan_10 2.00 cop[tikv] table:t7 keep order:false"))
 }
+
+func Test54535(t *testing.T) {


Suggested change

func Test54535(t *testing.T) {

func TestIssue54535(t *testing.T) {

AilinKid · 2024-07-16T09:36:53Z

/retest-required

hawkingrei · 2024-07-22T03:19:55Z

@joechenrh Please sync the code with master.

joechenrh · 2024-07-22T09:22:13Z

/retest-required

ti-chi-bot · 2024-07-25T11:24:46Z

@joechenrh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
idc-jenkins-ci-tidb/unit-test	`9e369c9`	link	true	`/test unit-test`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none labels Jul 10, 2024

ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels Jul 10, 2024

ti-chi-bot bot added the sig/planner SIG: Planner label Jul 10, 2024

ti-chi-bot bot added ok-to-test and removed needs-ok-to-test labels Jul 10, 2024

AilinKid requested review from AilinKid and elsa0520 July 10, 2024 04:11

ti-chi-bot bot added do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Jul 10, 2024

hawkingrei reviewed Jul 10, 2024

View reviewed changes

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 11, 2024

hawkingrei reviewed Jul 12, 2024

View reviewed changes

winoros reviewed Jul 15, 2024

View reviewed changes

ti-chi-bot bot removed the do-not-merge/needs-triage-completed label Jul 15, 2024

joechenrh force-pushed the inl-join branch from 06d028b to 1d68a85 Compare July 22, 2024 03:24

joechenrh added 2 commits July 25, 2024 19:02

planner: fix index out of range in constructIndexJoinInnerSideTask

0c0bf30

Add planner issue test

8085e40

joechenrh added 3 commits July 25, 2024 19:02

Change test name

fc3cad9

Using testkit to check physical plan

1523cfb

Update bazel file

9e369c9

joechenrh force-pushed the inl-join branch from 1d68a85 to 9e369c9 Compare July 25, 2024 11:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

planner: fix index out of range in constructIndexJoinInnerSideTask #54534

planner: fix index out of range in constructIndexJoinInnerSideTask #54534

joechenrh commented Jul 10, 2024 •

edited

Loading

ti-chi-bot bot commented Jul 10, 2024

ti-chi-bot bot commented Jul 10, 2024

ti-chi-bot bot commented Jul 10, 2024

tiprow bot commented Jul 10, 2024

hawkingrei commented Jul 10, 2024

codecov bot commented Jul 10, 2024 •

edited

Loading

hawkingrei Jul 10, 2024

hawkingrei Jul 10, 2024

joechenrh commented Jul 11, 2024

hawkingrei Jul 12, 2024

winoros left a comment

winoros Jul 15, 2024

AilinKid commented Jul 16, 2024

hawkingrei commented Jul 22, 2024

joechenrh commented Jul 22, 2024

ti-chi-bot bot commented Jul 25, 2024

	func Test54535(t *testing.T) {
	func TestIssue54535(t *testing.T) {

planner: fix index out of range in constructIndexJoinInnerSideTask #54534

Are you sure you want to change the base?

planner: fix index out of range in constructIndexJoinInnerSideTask #54534

Conversation

joechenrh commented Jul 10, 2024 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Jul 10, 2024

ti-chi-bot bot commented Jul 10, 2024

ti-chi-bot bot commented Jul 10, 2024

tiprow bot commented Jul 10, 2024

hawkingrei commented Jul 10, 2024

codecov bot commented Jul 10, 2024 • edited Loading

Codecov Report

hawkingrei Jul 10, 2024

Choose a reason for hiding this comment

hawkingrei Jul 10, 2024

Choose a reason for hiding this comment

joechenrh commented Jul 11, 2024

hawkingrei Jul 12, 2024

Choose a reason for hiding this comment

winoros left a comment

Choose a reason for hiding this comment

winoros Jul 15, 2024

Choose a reason for hiding this comment

AilinKid commented Jul 16, 2024

hawkingrei commented Jul 22, 2024

joechenrh commented Jul 22, 2024

ti-chi-bot bot commented Jul 25, 2024

joechenrh commented Jul 10, 2024 •

edited

Loading

codecov bot commented Jul 10, 2024 •

edited

Loading