Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planer: fix invalid pointer caused by a recursive CTE query #54450

Merged
merged 8 commits into from
Jul 17, 2024
Merged

planer: fix invalid pointer caused by a recursive CTE query #54450

merged 8 commits into from
Jul 17, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jul 4, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #54449

Problem Summary:

What changed and how does it work?

in the FindBestTask, we should return base.InvalidTask when it doesn't meet requirement. but now it returns nil. it is the root causion.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed do-not-merge/needs-tests-checked release-note-none sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 4, 2024
@hawkingrei hawkingrei marked this pull request as draft July 4, 2024 09:47
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 4, 2024
@hawkingrei hawkingrei marked this pull request as ready for review July 4, 2024 10:42
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 4, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.1067%. Comparing base (9f1d9e6) to head (5f5fa86).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #54450         +/-   ##
=================================================
- Coverage   74.8032%   55.1067%   -19.6966%     
=================================================
  Files          1551       1671        +120     
  Lines        362765     610036     +247271     
=================================================
+ Hits         271360     336171      +64811     
- Misses        71878     251355     +179477     
- Partials      19527      22510       +2983
Flag Coverage Δ
integration 34.8835% <0.0000%> (?)
unit 71.7046% <100.0000%> (-2.0302%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (-2.2339%) ⬇️
parser ∅ <ø> (∅)
br 46.1304% <ø> (-1.5418%) ⬇️
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 4, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 16, 2024
@hawkingrei
planer: fix invalid pointer caused by a recursive CTE query
839dc05 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
u
a6ae62f 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
reove debug log
566d085 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 17, 2024
@hawkingrei
reove debug log
902aef7 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
reove debug log
e0379e5 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
reove debug log
c44eb66 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
reove debug log
816939b 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
reove debug log
5f5fa86 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-17 02:11:39.877100461 +0000 UTC m=+406321.868041929: ☑️ agreed by winoros.
  • 2024-07-17 03:35:40.854575107 +0000 UTC m=+411362.845516640: ☑️ agreed by qw4990.
@ti-chi-bot ti-chi-bot bot merged commit 156f23a into pingcap:master Jul 17, 2024
23 checks passed
@hawkingrei hawkingrei deleted the 54449 branch July 17, 2024 07:09
@hawkingrei
Copy link
Member Author

/cherrypick release-8.1
/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-6.5: #54674.

In response to this:

/cherrypick release-8.1
/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 17, 2024
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#54450
f946a17 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 17, 2024
Open
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 17, 2024
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#54450
03461dc 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 17, 2024
Open
13 tasks
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.1: #54675.

In response to this:

/cherrypick release-8.1
/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 17, 2024
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#54450
dad57ce 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 17, 2024
Merged
13 tasks
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #54676.

In response to this:

/cherrypick release-8.1
/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.1: #54677.

In response to this:

/cherrypick release-8.1
/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 17, 2024
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#54450
3f5ab5f 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 17, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jul 17, 2024
@ti-chi-bot
planner: fix invalid pointer caused by a recursive CTE query (#54450) (…
d6edb68 
…#54676)

close #54449
ti-chi-bot bot pushed a commit that referenced this pull request Jul 22, 2024
@ti-chi-bot
planer: fix invalid pointer caused by a recursive CTE query (#54450) (#…
df2c19d 
…54677)

close #54449
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
4 participants
@hawkingrei @ti-chi-bot @qw4990 @winoros