Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat logs link produces something not human-readable #5952

Closed
1 task done
JonathanLennox opened this issue Jul 10, 2023 · 5 comments · Fixed by #7466
Closed
1 task done

Chat logs link produces something not human-readable #5952

JonathanLennox opened this issue Jul 10, 2023 · 5 comments · Fixed by #7466
Labels
accepted bug Something isn't working component: group/ component: meeting/ contrib-medium Medium dev difficulty for contribution medium

Comments

@JonathanLennox
Copy link

Describe the issue

When I click on the "chat logs" link for a recent (post-Zulip) meeting on the "past meetings" page, I get an unformatted JSON of the chat messages sent in that meeting, rather than something human-readable.

E.g. I go to https://datatracker.ietf.org/wg/masque/meetings/, and click on the "chat logs for masque" in the IETF 116 row, going to https://datatracker.ietf.org/meeting/116/materials/chatlog-116-masque-202303290930-00 -- I get a JSON blob that starts

[{"author": "Benjamin Schwartz", "text": "<p>Does this require using Connection IDs in a situation where they would normally be zero-length?</p>", "time": "2023-03-29T00:36:08Z"}, {"author": "Alex Chernyakhovsky", "text": "<p>Where would  a connection id be 0-length?</p>", "time": "2023-03-29T00:36:43Z"},

This should be formatted in some human-readable way.

Code of Conduct

@JonathanLennox JonathanLennox added the bug Something isn't working label Jul 10, 2023
@rjsparks
Copy link
Member

It would be better for the button to link to https://datatracker.ietf.org/doc/chatlog-116-masque-202303290930/ anyhow.

Whether the materials view should render the document, rather than show the raw source, can be debated - the raw source needs to be reachable. This should be applied across all materials for a session (it should be easy to get to the raw markdown for agendas uploaded in markdown for example.

@2115e

This comment was marked as spam.

@dhruvdhody
Copy link

Recently noted again in LSR - https://mailarchive.ietf.org/arch/msg/lsr/uMqqBtAa-nZ0CKhG1nGX1RU9Hz8/

The chatlog in the current form is not useful. Could this be prioritized?

@rjsparks
Copy link
Member

Jonathan is pointing to a different issue - what you're looking for is #6645 which has been fixed in #6653 and that fix will be deployed later this week.

@ajeanmahoney
Copy link
Collaborator

On the materials page for a session, there are two links to the chat logs: one links to the JSON, the other to a human-readable page, but the text of these links makes it hard to figure out which to click. The first link looks like it would go to the human-readable version, but it links to the JSON instead:

Chat Log IETF114: rswg: Mon 13:30 (chatlog-114-rswg-202207251330)

Perhaps it could look like this (listing the link to the human-readable version first and putting the link to the JSON format in parens):

Chat Log IETF114: rswg: Mon 13:30 (JSON format)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted bug Something isn't working component: group/ component: meeting/ contrib-medium Medium dev difficulty for contribution medium
5 participants