Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vectorstore): Incorporated review feedback #44

Merged
merged 1 commit into from
Feb 28, 2024
Merged

fix(vectorstore): Incorporated review feedback #44

merged 1 commit into from
Feb 28, 2024

Conversation

PingXie
Copy link
Contributor

@PingXie PingXie commented Feb 28, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@PingXie PingXie requested a review from a team as a code owner February 28, 2024 01:32
@product-auto-label product-auto-label bot added the api: redis Issues related to the googleapis/langchain-google-memorystore-redis-python API. label Feb 28, 2024
tabbyl21
tabbyl21 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@tabbyl21 tabbyl21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Ping!
@averikitsch averikitsch merged commit 95f7842 into main Feb 28, 2024
8 checks passed
@averikitsch averikitsch deleted the quick-start branch February 28, 2024 02:17
@release-please release-please bot mentioned this pull request Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: redis Issues related to the googleapis/langchain-google-memorystore-redis-python API.
3 participants
@PingXie @averikitsch @tabbyl21