feat: add indexing methods #21
Conversation
product-auto-label
bot
added
the
api: cloudsql-postgres
| async def aapply_vector_index( | ||
| self, | ||
| index: BaseIndex, | ||
| name: Optional[str] = None, |
There was a problem hiding this comment.
Should this allow a Vector object as well?
There was a problem hiding this comment.
Can you add more? Since I have this on the vector store I don't think so?
There was a problem hiding this comment.
should be able to do this: (might need to use Union[str, BaseIndex] depends on when the other format was added python version wise)
| name: Optional[str] = None, | |
| name: Optional[str | BaseIndex] = None, |
There was a problem hiding this comment.
We are already requiring a BaseIndex as the index argument, why does name need to support BaseIndex as well?
| async def aapply_vector_index( | ||
| self, | ||
| index: BaseIndex, | ||
| name: Optional[str] = None, |
There was a problem hiding this comment.
should be able to do this: (might need to use Union[str, BaseIndex] depends on when the other format was added python version wise)
| name: Optional[str] = None, | |
| name: Optional[str | BaseIndex] = None, |
| if isinstance(index, ExactNearestNeighbor): | ||
| return None |
There was a problem hiding this comment.
Dumb question -- should we delete an index with the name if it already exists?
There was a problem hiding this comment.
Not dumb! We did talk about this and I agree we should drop
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Instead of #12