Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update required dep to SQLAlchemy[asyncio] #121

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

jackwotherspoon
Copy link
Contributor

This library uses only async SQLAlchemy connection pool engines. Thus, it should be depending on sqlalchemy[asyncio] and not just sqlalchemy.

This will fix required deps on macOS: https://docs.sqlalchemy.org/en/20/orm/extensions/asyncio.html#asyncio-platform-installation-notes-including-apple-m1

Port of googleapis/langchain-google-alloydb-pg-python#116

@jackwotherspoon jackwotherspoon self-assigned this Apr 29, 2024
@jackwotherspoon jackwotherspoon requested review from a team as code owners April 29, 2024 18:27
@product-auto-label product-auto-label bot added the api: cloudsql-postgres Issues related to the googleapis/langchain-google-cloud-sql-pg-python API. label Apr 29, 2024
@jackwotherspoon jackwotherspoon merged commit d480760 into main Apr 29, 2024
10 checks passed
@jackwotherspoon jackwotherspoon deleted the jackwotherspoon-patch-1 branch April 29, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudsql-postgres Issues related to the googleapis/langchain-google-cloud-sql-pg-python API.
2 participants