Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow special characters in table name for vector store delete #100

Merged
merged 2 commits into from
Mar 27, 2024
Merged

fix: allow special characters in table name for vector store delete #100

merged 2 commits into from
Mar 27, 2024

Conversation

jackwotherspoon
Copy link
Contributor

@jackwotherspoon jackwotherspoon commented Mar 27, 2024 •
edited
Loading

Adding basic test for vector store .delete method.

Update: failing test for custom table name discovered that special characters in table name were unable to delete from the vector store.
@jackwotherspoon jackwotherspoon self-assigned this Mar 27, 2024
@jackwotherspoon jackwotherspoon requested a review from a team as a code owner March 27, 2024 14:54
@product-auto-label product-auto-label bot added the api: cloudsql-postgres Issues related to the googleapis/langchain-google-cloud-sql-pg-python API. label Mar 27, 2024
@jackwotherspoon jackwotherspoon changed the title chore: add tests for vector store delete Mar 27, 2024
@jackwotherspoon jackwotherspoon merged commit 7fc1c63 into main Mar 27, 2024
10 checks passed
@jackwotherspoon jackwotherspoon deleted the delete-tests branch March 27, 2024 15:37
@release-please release-please bot mentioned this pull request Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudsql-postgres Issues related to the googleapis/langchain-google-cloud-sql-pg-python API.
2 participants
@jackwotherspoon @averikitsch