Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for partialSuccess flag in entries.write request for oversized log entries #751

Closed
losalex opened this issue Nov 17, 2021 · 1 comment
Closed

Add support for partialSuccess flag in entries.write request for oversized log entries #751

losalex opened this issue Nov 17, 2021 · 1 comment
Assignees
@losalex
Labels
api: logging Issues related to the googleapis/java-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@losalex
Copy link
Contributor

losalex commented Nov 17, 2021

Is your feature request related to a problem? Please describe.
Today some requests might contain oversized log entries which cause entire write request to be dropped instead just of oversized log entries to be dropped (see log-limits for more information).
Describe the solution you'd like
The solution for this problem is to add partialSuccess flag as described in request-body.
Describe alternatives you've considered
Custom logic to truncate oversized entries could be implemented, but unfortunately truncating JSON structured log entries is complex and building generic solution for reduction JSON data is out of scope.
@losalex losalex added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Nov 17, 2021
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Nov 17, 2021
@minherz minherz assigned losalex and unassigned simonz130 Feb 10, 2022
@losalex
Copy link
Contributor Author

losalex commented Jun 27, 2022

Fixed by 979
@losalex losalex closed this as completed Jun 27, 2022
@losalex losalex mentioned this issue Jun 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
2 participants
@simonz130 @losalex