Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript types missing when upgrading from 10.2 to 10.3 #8344

Closed
shaunpersad opened this issue Jun 30, 2024 · 3 comments
Closed

Typescript types missing when upgrading from 10.2 to 10.3 #8344

shaunpersad opened this issue Jun 30, 2024 · 3 comments

Comments

@shaunpersad
Copy link

shaunpersad commented Jun 30, 2024

Operating System

All

Browser Version

All

Firebase SDK Version

10.3

Firebase SDK Product:

Auth

Describe your project's tooling

React app with Vite inside a monorepo

Describe the problem

I recently had to upgrade our firebase SDK from 9 to 10 and discovered the Typescript types have completely gone missing. I was able to test out exact versions of the 10.x SDK and saw that types were correctly found up until version 10.3.0. Auth is the only part of the SDK we use so I did not test out the other products to see if they also have the same issue.

Steps and code to reproduce issue

npm install --save-exact firebase@10.2 => autocomplete from types are available
npm install --save-exact firebase@10.3 => autocomplete from types are not available

@shaunpersad shaunpersad added new A new issue that hasn't be categoirzed as question, bug or feature request question labels Jun 30, 2024
@jbalidiong jbalidiong added api: core needs-attention and removed new A new issue that hasn't be categoirzed as question, bug or feature request labels Jul 1, 2024
@hsubox76
Copy link
Contributor

hsubox76 commented Jul 2, 2024

That's really odd, the only change in Auth I see between 10.2 and 10.3 is a change for React Native users: #7570

Are you using React Native? If so, check out this comment (and the surrounding issue) and see if it's related to what you're experiencing: #7584 (comment) In this issue, it only affects the VSCode editor autocomplete. It doesn't affect the actual build. Is that what you're seeing?

If you're not using React Native: Can you provide a minimal repro? I'd like to find out which path your project follows to try to find the typings. Ideally I would like to see the full structure and build tooling of your project (vite config, monorepo setup, etc), but I don't need to see any of your code except maybe a single line where you try to import types.

@google-oss-bot
Copy link
Contributor

Hey @shaunpersad. We need more information to resolve this issue but there hasn't been an update in 5 weekdays. I'm marking the issue as stale and if there are no new updates in the next 5 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

@google-oss-bot
Copy link
Contributor

Since there haven't been any recent updates here, I am going to close this issue.

@shaunpersad if you're still experiencing this problem and want to continue the discussion just leave a comment here and we are happy to re-open this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment