Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about OpenDAL path dependence #4

Open
Xuanwo opened this issue Apr 9, 2024 · 1 comment
Open

Question about OpenDAL path dependence #4

Xuanwo opened this issue Apr 9, 2024 · 1 comment

Comments

@Xuanwo
Copy link

Xuanwo commented Apr 9, 2024

Hi, @waynexia, this project is so cool! I'm so happy that opendal's work on object_store integration and wasm target paid back.

However, I noticed that opendal is path dependence:

opendal = { version = "0.45.0", path = "../opendal/core", default-features = false, features = [
    "services-s3",
    "services-http",
] }
object_store_opendal = { path = "../opendal/integrations/object_store", default-features = false }

Would you like to list the changes you made in opendal? I'm happy to get them upstream and released.

(Maybe @WenyXu and @tisonkun also interested in this issue?)

@waynexia
Copy link
Collaborator

waynexia commented Apr 9, 2024

Ahh, those are some debugging code in development. The content has not changed.

But I do have one change want to include in the upstream, which makes it easier to use in not !Send codebase like DF.

Cross reference apache/opendal#4437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants