You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In my understanding, we have no way to derive number of values from the parent column.
however we can retrieve number of values from the stripe metadata, this requires a refactor.
What's wrong?
encounter panic when reading a column containing float values under array or map structures, such as:
array<float>
array<tuple<float, int>>
How to reproduce?
Add the following code to
tests/basic/data/write.py
:Run the test against it like nested_array.orc
Reason
FloatIter uses number of rows instead of number of leaf values.
Refer to the code here: array_decoder/mod.rs
Quick Fix
FloatIter do not have to guard against number of values. It can simply read until the end of bytes in memory, similar to how integers are handled.
pr: #112
Some questions about Column::number_of_rows
Is the Column::number_of_rows intended to represent number_of_values? If so, this code seems incorrect:
In my understanding, we have no way to derive number of values from the parent column.
however we can retrieve number of values from the stripe metadata, this requires a refactor.
Here’s an ugly but workable fix: Commit
The text was updated successfully, but these errors were encountered: