Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo check --all-targets failed for stripe::Stripe is private #106

Closed
Xuanwo opened this issue Jul 1, 2024 · 2 comments · Fixed by #108
Closed

Cargo check --all-targets failed for stripe::Stripe is private #106

Xuanwo opened this issue Jul 1, 2024 · 2 comments · Fixed by #108

Comments

@Xuanwo
Copy link
Collaborator

Xuanwo commented Jul 1, 2024

:) cargo c
    Checking orc-rust v0.3.0 (/home/xuanwo/Code/datafusion-contrib/datafusion-orc)
error[E0603]: struct `Stripe` is private
  --> src/bin/orc-metadata.rs:4:57
   |
4  | use orc_rust::{reader::metadata::read_metadata, stripe::Stripe};
   |                                                         ^^^^^^ private struct
   |
note: the struct `Stripe` is defined here
  --> /home/xuanwo/Code/datafusion-contrib/datafusion-orc/src/stripe.rs:91:1
   |
91 | pub(crate) struct Stripe {
   | ^^^^^^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0603`.
error: could not compile `orc-rust` (bin "orc-metadata" test) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
error: could not compile `orc-rust` (bin "orc-metadata") due to 1 previous error

Should we export it? The bin orc-metadata failed to build for this.

@WenyXu
Copy link
Collaborator

WenyXu commented Jul 1, 2024

Yes, we should👀, would you like to give a fix☺️

@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Jul 1, 2024

Yes, we should👀, would you like to give a fix☺️

Yep, let me get it fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants