Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement list_dir #41

Open
matthewmturner opened this issue Feb 9, 2022 · 2 comments
Open

Implement list_dir #41

matthewmturner opened this issue Feb 9, 2022 · 2 comments

Comments

@matthewmturner
Copy link
Collaborator

No description provided.

@seddonm1
Copy link
Collaborator

seddonm1 commented Feb 9, 2022

I think leave this until we can see what list_dir is actually for. Currently the implementation is todo: https://github.com/apache/arrow-datafusion/blob/master/datafusion/src/datasource/object_store/local.rs#L45

@matthewmturner
Copy link
Collaborator Author

I was thinking of doing it based on the definition in the Trait:

/// Returns all the files in `prefix` if the `prefix` is already a leaf dir,
/// or all paths between the `prefix` and the first occurrence of the `delimiter` if it is provided.
async fn list_dir(
        &self,
        prefix: &str,
        delimiter: Option<String>,
) -> Result<ListEntryStream>;

But def ok holding off if you think more info needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants