Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #8372] Add more test coverage for AdminBrokerProcessor #8373

Merged
merged 3 commits into from
Jul 17, 2024
Merged

[ISSUE #8372] Add more test coverage for AdminBrokerProcessor #8373

merged 3 commits into from
Jul 17, 2024

Conversation

TanXiang7o
Copy link
Contributor

fix #8372
before:
0b7e000111b629899685fd89c2214385
after:
b116a66ebe011ccc18f1f9dddf28b685
@TanXiang7o TanXiang7o changed the title [ISSUE #8372] Add more test coverage for broker processor Jul 5, 2024
@RongtongJin
Copy link
Contributor

LGTM
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.39%. Comparing base (77f6415) to head (fb19731).
Report is 5 commits behind head on develop.

Files Patch % Lines
...ocketmq/broker/processor/AdminBrokerProcessor.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #8373      +/-   ##
=============================================
+ Coverage      44.03%   44.39%   +0.36%     
- Complexity     10683    10764      +81     
=============================================
  Files           1274     1274              
  Lines          88939    88939              
  Branches       11432    11432              
=============================================
+ Hits           39162    39486     +324     
+ Misses         44820    44471     -349     
- Partials        4957     4982      +25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
@RongtongJin RongtongJin merged commit 2d1e314 into apache:develop Jul 17, 2024
9 of 10 checks passed
@TanXiang7o TanXiang7o deleted the add-more-test-coverage-for-broker-processor branch July 18, 2024 04:08
@ShannonDing ShannonDing added the soc Summer of Code, hosted by Google, Alibaba, Chinese Academy of Sciences and so on label Jul 22, 2024
@ShannonDing
Copy link
Member

link #8262
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
soc Summer of Code, hosted by Google, Alibaba, Chinese Academy of Sciences and so on
4 participants
@TanXiang7o @RongtongJin @codecov-commenter @ShannonDing