[ISSUE #8334] fix: irreducible reference count of mapped file caused by held tiered storage's dispatch #8335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8335 +/- ##
=============================================
+ Coverage 43.21% 43.86% +0.65%
- Complexity 10526 10633 +107
=============================================
Files 1274 1274
Lines 88940 88945 +5
Branches 11434 11435 +1
=============================================
+ Hits 38433 39017 +584
+ Misses 45804 45001 -803
- Partials 4703 4927 +224 ☔ View full report in Codecov by Sentry. |
bxfjb
force-pushed
the
fix-irreducible-ref
branch
from
371c81e
to
d0f7b8c
Compare
cserwen
previously approved these changes
Jun 27, 2024
lizhimins
requested changes
Jul 3, 2024
| break; | ||
| } | ||
| flatFile.addMessage(message); |
There was a problem hiding this comment.
227 行，append CommitLog 的时候会有 this.bufferResultList.add(message); 这里是重复了吗？
正常会在 MessageStoreDispatcherImpl#commitAsync 这里释放引用
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #8334
Brief Description
How Did You Test This Change?