-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DSIP-53] Suggest add process lineage parsing for dependent task #16288
Conversation
...ler-tools/src/main/java/org/apache/dolphinscheduler/tools/lineage/MigrateLineageService.java
Fixed
Show fixed
Hide fixed
Map<String, Object> result = | ||
workFlowLineageService.queryDownstreamDependentTasks(workFlowCode, taskCode); | ||
return returnDataList(result); | ||
public Result<Map<String, Object>> queryDependentTasks(@Parameter(hidden = true) @RequestAttribute(value = Constants.SESSION_USER) User loginUser, |
Check notice
Code scanning / CodeQL
Useless parameter Note
@RequestParam(value = "processDefinitionCode", required = true) long processDefinitionCode, | ||
@RequestParam(value = "taskCode", required = true) long taskCode) { | ||
Result result = new Result(); | ||
public Result<Map<String, Object>> verifyTaskCanDelete(@Parameter(hidden = true) @RequestAttribute(value = Constants.SESSION_USER) User loginUser, |
Check notice
Code scanning / CodeQL
Useless parameter Note
workFlowName = ParameterUtils.handleEscapes(workFlowName); | ||
List<WorkFlowLineage> workFlowLineages = | ||
workFlowLineageService.queryWorkFlowLineageByName(projectCode, workFlowName); | ||
public Result<List<WorkFlowRelationDetail>> queryWorkFlowLineageByName(@Parameter(hidden = true) @RequestAttribute(value = SESSION_USER) User loginUser, |
Check notice
Code scanning / CodeQL
Useless parameter Note
...pi/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessLineageServiceImpl.java
Fixed
Show fixed
Hide fixed
...src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
Fixed
Show fixed
Hide fixed
...uler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessDefinitionService.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
Show resolved
Hide resolved
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/ProcessLineage.java
Outdated
Show resolved
Hide resolved
...scheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ProcessLineageMapper.java
Outdated
Show resolved
Hide resolved
...duler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessLineageMapper.xml
Outdated
Show resolved
Hide resolved
...duler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessLineageMapper.xml
Outdated
Show resolved
Hide resolved
dolphinscheduler-dao/src/main/resources/sql/upgrade/3.3.0_schema/mysql/dolphinscheduler_ddl.sql
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
Outdated
Show resolved
Hide resolved
...inscheduler-common/src/main/java/org/apache/dolphinscheduler/common/constants/Constants.java
Outdated
Show resolved
Hide resolved
...scheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ProcessLineageMapper.java
Outdated
Show resolved
Hide resolved
dolphinscheduler-dao/src/main/resources/sql/upgrade/3.3.0_schema/mysql/dolphinscheduler_ddl.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
if (dependentParameters != null) { | ||
List<DependentTaskModel> dependTaskList = | ||
dependentParameters.getDependence().getDependTaskList(); | ||
if (!CollectionUtils.isEmpty(dependTaskList)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (!CollectionUtils.isEmpty(dependTaskList)) { | |
if (CollectionUtils.isNotEmpty(dependTaskList)) { | |
return; | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
*/ | ||
|
||
DROP TABLE IF EXISTS `t_ds_process_task_lineage`; | ||
CREATE TABLE `t_ds_process_task_lineage` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CREATE TABLE `t_ds_process_task_lineage` | |
CREATE TABLE `t_ds_workflow_task_lineage` |
|
Purpose of the pull request
close #16255
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md