Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][task-java/task-spark] Task-Java and Task-Spark add Convert Parameter Placeholders for args #16250

Open
3 tasks done
lanxing2 opened this issue Jul 1, 2024 · 3 comments
Assignees
Labels
improvement make more easy to user or prompt friendly

Comments

@lanxing2
Copy link
Contributor

lanxing2 commented Jul 1, 2024

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Currently, for task-java
ParameterUtils.convertParameterPlaceholders will replace placeholder for the Java Code if Java Task run in the Java Mode.
However if run the Java Task in Jar Mode, I cannot pass Parameters to the task, because in the mainArgs and jvmArgs do not have ParameterUtils.convertParameterPlaceholders to replace the placeholders with parameter value.
If we enable placeholder replacement for args, JavaTask in Jar Mode can get the value of Parameters in args.
Similiarily, for task-spark
ParameterUtils.convertParameterPlaceholders will replace placeholder for the SQL Code if Java Task run in the SQLMode.
However if run the Spark Task in other Mode, cannot pass the parameters to the task, because mainArgs and otherArgs do not have ParameterUtils.convertParameterPlaceholders to replace the placeholders with parameter value.
If we enable placeholder replacement for args, SparkTask in Mode other than SQL can get the value of Parameters in args.
I purpose this Improvement because in my team, we save some common data such in project parameters.
And use these parameters in different processes and tasks, then I notice JavaTask in Jar Mode and Spark Task not in SQL Mode cannot use these parameters.
I actually add placeholder replacement for Java Task in Jar Mode in our teams' cluster.
Hope the core member agree with this purposal, I can submit PR for this feature/improvement.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@lanxing2 lanxing2 added improvement make more easy to user or prompt friendly Waiting for reply Waiting for reply labels Jul 1, 2024
1 similar comment
@SbloodyS SbloodyS removed the Waiting for reply Waiting for reply label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement make more easy to user or prompt friendly
2 participants