-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
firebase-tools dependency #3479
Comments
This issue does not seem to follow the issue template. Make sure you provide all the required information. |
Fixed |
Good find, we'll get that patched up. I should try to get it so we don't have two package.json files, if i can't achieve that without a big refactor I'll add unit tests to make sure the deps match. |
I'm a little bit confused on what I should do to install Angular Fire being that this makes it fail. |
The easiest fix would be not to have firebase-tools in your package.json, rather use a globally installed firebase-tools or use NPX. We generally recommend you don't have firebase-tools in your package.json, since it's a very large dependency & is shrinkwrapped, increasing the likelihood of a version conflict. |
yarn does not have global any more. If I use dlx, it seems to me that yarn would be downloading and binding the firebase-tools afresh everytime, taking quite a while to execute. |
Why do you have firebase-tools as peerDependencies? Especially with a fixed version? I have ng16 and have to use v16, but I can't use latest firebase-tools in my repo (which is 13 at the moment). |
@egorkel-altexsoft I need to issue firebase commands, and I didn't want install firebase-tools as global (and now yarn does not have global at all). Ins't that what devdep means? They are tools I need for the development cycle. |
Ok, what should I do if I have to use version 16 and need the latest fb-tools? |
Ignore the peer dependency. As raised in this issue, the firebase-tools have dependency on both ^12 and ^13. |
Version 16 has only one fb tools version ^12. And I can't ignore peer dependency in my CI. When I run |
Please read the issue I raised. "dependencies": {
"firebase-tools": "^13.0.0"
}, I raised the issue because If your CI cannot accept peer dependency conflict, then you really need to use |
Version info
Angular: 17.0.7
Firebase: 10.7.1
AngularFire: 17.0.0
Other (e.g. Ionic/Cordova, Node, browser, operating system):
node: 18.18.0
OS: windows 11
How to reproduce these conditions
Failing test unit, Stackblitz demonstrating the problem
any repo
Steps to set up and reproduce
yarn
Sample data and security rules
any
Debug output
** Errors in the JavaScript console **
none
** Output from
firebase.database().enableLogging(true);
**none
** Screenshots **
N/A
Expected behavior
successful compilation
Actual behavior
https://github.com/angular/angularfire/blob/master/src/package.json
says:but
https://github.com/angular/angularfire/blob/master/package.json
saysThe text was updated successfully, but these errors were encountered: