Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Lambda segfaults in Clang #2035

Closed
FireBurn opened this issue Jun 26, 2024 · 11 comments
Closed

[Bug]: Lambda segfaults in Clang #2035

FireBurn opened this issue Jun 26, 2024 · 11 comments
Assignees
Labels

Comments

@FireBurn
Copy link

Description

This bug has caused segfaults compiling Android projects using lambdas and affects the whole 18.1 series

I've got a version of the patch that applies cleanly to 18.1.8 https://github.com/FireBurn/PortageStuff/blob/master/patches/sys-devel/clang/0001-Tweak-tryCaptureVariable-for-unevaluated-lambdas-932.patch

Upstream bug

llvm/llvm-project#67260

Commit to cherry-pick

vedantparanjape-amd/llvm-project@251b29d

Affected versions

r27

Canary version

No response

Host OS

Linux

Host OS version

Gentoo

Affected ABIs

arm64-v8a, x86_64

@DanAlbert
Copy link
Member

Thanks. We'll check the test case in the PR to see if this is a regression from r26. If not, it'll be fixed in r28 for sure, but it'd probably wait for r27b (we'll see though, we're already respinning for a regression fix, so might be able to pick this up too).

@pirama-arumuga-nainar
Copy link
Collaborator

llvm/llvm-project#67260 says this regressed due to an LLVM change in september so it is likely a regression in r27. Will try to cherry-pick the fix.

@DanAlbert
Copy link
Member

Ah, thanks. I'd skimmed it but missed that bit.

@FireBurn
Copy link
Author

Thanks

@pirama-arumuga-nainar
Copy link
Collaborator

Picked in: https://android-review.googlesource.com/c/toolchain/llvm_android/+/3148958

That's a different cherry-pick. The fix for this bug hasn't been cherry-picked yet.

@FireBurn
Copy link
Author

FireBurn commented Jul 3, 2024

Is there anything I need to do with this?

@pirama-arumuga-nainar
Copy link
Collaborator

Picked in: https://android-review.googlesource.com/c/toolchain/llvm_android/+/3148958

That's a different cherry-pick. The fix for this bug hasn't been cherry-picked yet.

Actually @appujee is correct. The same fix is cherry-picked as part of #2023. The fix will be included as part of r27 to be released later this month.

@DanAlbert
Copy link
Member

Is there anything I need to do with this?

No, you're just waiting for the release to be ready. Can subscribe to https://groups.google.com/g/android-ndk-announce or the releases on this github project if you want to be notified.

@DanAlbert DanAlbert added this to Awaiting triage in LLVM via automation Jul 9, 2024
@DanAlbert DanAlbert moved this from Awaiting triage to Awaiting prebuilt drop in LLVM Jul 9, 2024
@DanAlbert
Copy link
Member

Closing as a duplicate of #2023. I don't think it's strictly a dup, but the same upstream change fixed several related bugs (in any case, the fix has been cherry-picked and will be in r27 Very Soon TM).

@DanAlbert DanAlbert closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2024
@DanAlbert DanAlbert removed this from Awaiting prebuilt drop in LLVM Jul 10, 2024
@FireBurn
Copy link
Author

Thanks that it all fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants