Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] use libandroid_support for all pre-21 builds? #1651

Closed
DanAlbert opened this issue Jan 10, 2022 · 1 comment
Closed

[FR] use libandroid_support for all pre-21 builds? #1651

DanAlbert opened this issue Jan 10, 2022 · 1 comment

Comments

@DanAlbert
Copy link
Member

libandroid_support is currently coupled to libc++, but the headers are used unconditionally. This means that decls for things in libandroid_support are always present, so in the rare cases where libc++ isn't used (C only, or C++ builds that explicitly don't use the stdlib), using the functions that are provided by libandroid_support leads to degraded diagnostics (an undefined reference when linking instead of a "that API was added in $API_LEVEL" message).

Since the headers are there anyway, it might be good to always use libandroid_support rather than only when libc++ is used. It'd let us clean up a lot and reduce C vs C++ behavior differences.

@DanAlbert
Copy link
Member Author

No such thing any more. No longer needed.

@DanAlbert DanAlbert closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant