Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ndk-build doesn't report failure for missing dependent module definitions #208

Closed
DanAlbert opened this issue Sep 27, 2016 · 1 comment
Closed

ndk-build doesn't report failure for missing dependent module definitions #208

DanAlbert opened this issue Sep 27, 2016 · 1 comment
Assignees
@DanAlbert
Milestone
r14

Comments

@DanAlbert
Copy link
Member 

include $(CLEAR_VARS)
LOCAL_MODULE := foo
LOCAL_SRC_FILES := foo.cpp
LOCAL_STATIC_LIBRARIES := never-defined
include $(BUILD_SHARED_LIBRARY)

ndk-build will not produce an error even though the above module depends on a module that was never defined.
@DanAlbert DanAlbert added this to the r14 milestone Sep 27, 2016
@DanAlbert DanAlbert self-assigned this Sep 27, 2016
@DanAlbert
Copy link
Member Author

Fix up for review: https://android-review.googlesource.com/#/c/280431/
jmakovicka added a commit to jmakovicka/OsmAnd-core that referenced this issue Dec 13, 2016
@jmakovicka
Remove non-existent LOCAL_SHARED_LIBRARIES
de7118d 
Fixes build with NDK 14

android/ndk#208
@jmakovicka jmakovicka mentioned this issue Dec 13, 2016
Merged
miodragdinic pushed a commit to MIPS/ndk that referenced this issue Apr 17, 2018
@DanAlbert
Add support for exporting library dependencies.
a2244bc 
We supported `LOCAL_EXPORT_LDLIBS`, but not
`LOCAL_EXPORT_SHARED_LIBRARIES` or `LOCAL_EXPORT_STATIC_LIBRARIES`.

We need this feature to make ndk-build use libunwind with libc++ for
only arm32. This hasn't been a problem thus far because ndk-build
currently doesn't so much as warn about missing dependencies
(android/ndk#208).

Test: ./run_tests.py --filter export-libs
Bug: None
Change-Id: Ib6b326779115cc9f60cc8018a38cb57074f7618b
miodragdinic pushed a commit to MIPS/ndk that referenced this issue Apr 17, 2018
@DanAlbert
Fail if a module has missing dependencies.
860ca72 
    include $(CLEAR_VARS)
    LOCAL_MODULE := foo
    LOCAL_SRC_FILES := foo.cpp
    LOCAL_STATIC_LIBRARIES := never-defined
    include $(BUILD_SHARED_LIBRARY)

In the above example, the build would succeed even though it had
missing dependencies. This seems to have always been the behavior (I
checked back to r10e), so there's a good chance that there are builds
out there that depend on this behavior.

By default we will now abort in this situation because this is so
completely broken. A user may define `APP_ALLOW_MISSING_DEPS` to
"false" in their Application.mk or on the command line to revert to
the old, broken behavior.

Test: ./run_tests.py --filter APP_ALLOW_MISSING_DEPS
Bug: android/ndk#208
Change-Id: Ie77ad18a7e8000ef468c79f8e89aa2e5ae1788dd
miodragdinic pushed a commit to MIPS/ndk that referenced this issue Apr 17, 2018
@DanAlbert
Add a negative test case for missing dependencies.
a2a4402 
Test: ./run_tests.py --filter fails-missing-deps
Bug: android/ndk#208
Change-Id: I5f8ace6bc468e07440c86d3113dec31fcaaf53a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@DanAlbert