Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README slightly out of date #1536

Open
alexcfaber opened this issue Jan 5, 2020 · 3 comments
Open

README slightly out of date #1536

alexcfaber opened this issue Jan 5, 2020 · 3 comments

Comments

@alexcfaber
Copy link
Contributor

Just tried to checkout the project to contribute and I ran in to a few issues in building the project locally for iOS and Mac which I would like to address in a PR.

  1. The build instructions in ReadMe.md seem out of date and only target Mac building
  2. PROVISIONING_PROFILE_SPECIFIER is intentionally left blank. I should have known that; but silly me managed to do this wrong a few times.
  3. The XCConfig directory includes multiple xcconfigs which contain the same instructions as in the Readme. But every single one seems to be written against a different state of the process.
    e.g. The Readme is missing iOS development and NetNewsWire_iOSapp_target is referring to BUNDLE_ROOT instead of ORGANIZATION_IDENTIFIER.

Solution would be updating Readme and comments, although I can imagine wanted to centralise this as well.

@brentsimmons brentsimmons added this to the iOS 5.0 Alpha milestone Jan 5, 2020
@vincode-io
Copy link
Member

I assume you want this work done on master and not ios-candidate?

@brentsimmons
Copy link
Collaborator

Yes. On master.

@brentsimmons brentsimmons removed this from the iOS 5.0 Alpha milestone Jan 22, 2020
@brentsimmons
Copy link
Collaborator

Removed from the milestone. It is work that needs to be done, but it doesn’t need to be done in order to ship 5.0 for iOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants