Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Settings UI #920

Closed
5 of 18 tasks
Tracked by #1182
Al12rs opened this issue Feb 7, 2024 · 2 comments
Closed
5 of 18 tasks
Tracked by #1182

Implement Settings UI #920

Al12rs opened this issue Feb 7, 2024 · 2 comments
Assignees
Labels
Design UI/UX This is related to the UI. Epic: Settings

Comments

@Al12rs
Copy link
Contributor

Al12rs commented Feb 7, 2024

Needs #396

Details are in #396 as well.

Design

https://www.figma.com/file/rR0I4C46je8VwwqCdrpc5U/%F0%9F%93%B1%E2%9A%99%EF%B8%8F-Settings-page?type=design&node-id=155%3A4907&mode=design&t=y96yEjSE4IjI3YSh-1

Demo

settings-demo.mp4

Does not include search in the sidebar for the first iteration.

Implementation Breakdown:

Settings to bring into UI:

  • Language setting: Dropdown of strings
  • Telemetry enable (bool toggle)
  • Diagnostic setting minimum severity (enum)

Backend:

Frontend:

Design:

Simple version:

  • Add Dialog for when you press Save and we require a restart (we can't restart for now, ask user to do it)

For full version:

  • Design how to describe each option for multi choice settings (combobox)
  • Highlight modified settings in the ui (settings that no longer have the default value)
  • Add button to reset to default value in case of modified

For later:

  • Settings UI - Add Dialog for Cancel button (You have unsaved changes)
  • Settings UI - Add Dialog for Cancel button in case of required restart (You have unsaved changes with restart)
  • Add sections
  • Filter search
  • Implement automatic restart of the App
    • Restart with our multi window approach might be a pain to implement
    • Add confirm dialog before restarting
@Al12rs
Copy link
Contributor Author

Al12rs commented Apr 17, 2024

Copied from the issue body:

Missing from design:

We need Design for displaying settings with a Warning, such as Experimental or Not Recommended.

This came up in the context of offering an option to not Backup the game files when managing the game for the first time, which exposes the users to potential issues if the game updates, since we don't have the backups of the old files if the user wants to rollback.

@erri120
Copy link
Member

erri120 commented Apr 29, 2024

Done with #1248, other issues moved to epic #1182.

@erri120 erri120 closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design UI/UX This is related to the UI. Epic: Settings
3 participants