This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
feat: read version from package.json #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KovacZan your branch is |
* feat(PTP-555-2): Updated ERC721 Mintable with Error logger. Constants file added. * Tests updated with error logger. * feat: Updated role names.
|
@KovacZan sorry for the delay, i'll like to approve and merge your PR, but you still have a failed test , please run |
Hello @salimtb, I think the problem is with github actions not picking env variables required to run tests (maybe because I am outside collaborator). I have made PR to our fork protokol#1 |
salimtb
approved these changes
Sep 6, 2022
efecarranza
approved these changes
Sep 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
We were checking Infura API and came across Infura NFT SDK, we looked into it and found a comment :)
And I said let's do a PR for this, they might miss this comment out.
The current dynamic version adding is done via reading the package.json file.
Probably better way of doing it would be thought env https://docs.npmjs.com/cli/v6/using-npm/scripts#packagejson-vars
Let us know what you think and we can try to help!