Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

feat(PTP-558): add warning message when URI are not links #76

Merged
merged 4 commits into from
Jul 18, 2022
Merged

feat(PTP-558): add warning message when URI are not links #76

merged 4 commits into from
Jul 18, 2022

Conversation

kalote
Copy link
Contributor

@kalote kalote commented Jul 15, 2022

  • new function "isURI()" in utils
  • implementation in ERC721Mintable.js class
danielpavelicconsensys
danielpavelicconsensys approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@danielpavelicconsensys danielpavelicconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding messages into dedicated file or errorMessages.js so all msgs are at one place.
@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication
@kalote kalote merged commit bedd079 into main Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants
@kalote @salimtb @danielpavelicconsensys