Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

bugfix(PTP-482): Additional check on RPCURL added. #49

Merged
merged 3 commits into from
Jun 13, 2022
Merged

bugfix(PTP-482): Additional check on RPCURL added. #49

merged 3 commits into from
Jun 13, 2022

Conversation

danielpavelicconsensys
Copy link
Contributor

Added one additional check on RPCURL -> Auth, when RPCURL param is not passed it throws 'undefined'.
salimtb
salimtb reviewed Jun 10, 2022
View reviewed changes
src/lib/Auth/Auth.js Outdated Show resolved Hide resolved
@salimtb
Copy link
Collaborator

salimtb commented Jun 10, 2022

you have to add an integration test as well for this defect
kalote
kalote suggested changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@kalote kalote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use ternary operator to avoid "if" statement + move the check down, when this.#projectId is defined
@sonarcloud
Copy link

sonarcloud bot commented Jun 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication
@danielpavelicconsensys danielpavelicconsensys merged commit 49acf59 into main Jun 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants
@danielpavelicconsensys @salimtb @kalote