Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

feat(PTP-521): build pkg for registry use #44

Merged
merged 1 commit into from
Jun 8, 2022
Merged

feat(PTP-521): build pkg for registry use #44

merged 1 commit into from
Jun 8, 2022

Conversation

salimtb
Copy link
Collaborator

@salimtb salimtb commented Jun 8, 2022

This PR is in order to be able to integrate our sdk with a react app, in the last version of react we use webpack 5, which generates a conflict with the module core of nodeJS ( ex: 'fs' and 'url').
React does not support also the private properties which begins with a #, therefore it was necessary to transpiler all that in Babel, and here the result

@salimtb salimtb force-pushed the feat/ptp-521 branch 14 times, most recently from 352b556 to 529641c Compare June 8, 2022 20:32
@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2022

Copy link
Contributor

@kalote kalote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good, except the btoa / buffer stuff. Is it done on purpose or just a relica of a previous version?

src/lib/Auth/Auth.js Show resolved Hide resolved
@kalote kalote merged commit 2a49121 into main Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants