This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
feat(PTP-490): object parameters in all methods / JSDoc / standardized parameter name #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion of parameter name
MqllR
reviewed
Jun 3, 2022
| const expectedContractMetadata = { name: 'testContract', symbol: 'TST', tokenType: 'ERC721' }; | ||
| expect(contractMetadata).toStrictEqual(expectedContractMetadata); | ||
| }); | ||
| }); | ||
|
|
||
| describe('As an account I should be able to get the list of NFTs by address', () => { | ||
| it('should return list of NFTs by address', async () => { | ||
| const nfts = await sdk.getNFTs(process.env.WALLET_PUBLIC_ADDRESS); | ||
| const nfts = await sdk.getNFTs({ publicAddress: process.env.WALLET_PUBLIC_ADDRESS }); |
There was a problem hiding this comment.
We should adapt the environment variable as well :)
There was a problem hiding this comment.
not mandatory as it doesn't affects user experience
VGau
reviewed
Jun 3, 2022
.gitignore
Outdated
| storage | ||
| .DS_STORE |
There was a problem hiding this comment.
Can you ignore .vscode folder too ?
There was a problem hiding this comment.
.idea too , i use webstorm :p
salimtb
approved these changes
Jun 3, 2022
|
Kudos, SonarCloud Quality Gate passed! |
VGau
approved these changes
Jun 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.