Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

feat(PTP-463): approve transfer #40

Merged
merged 1 commit into from
Jun 3, 2022
Merged

feat(PTP-463): approve transfer #40

merged 1 commit into from
Jun 3, 2022

Conversation

salimtb
Copy link
Collaborator

@salimtb salimtb commented Jun 3, 2022

No description provided.

kalote
kalote suggested changes Jun 3, 2022
View reviewed changes
lib/ContractTemplates/ERC721Mintable/ERC721Mintable.js Outdated Show resolved Hide resolved
lib/ContractTemplates/ERC721Mintable/ERC721Mintable.js Outdated Show resolved Hide resolved
lib/ContractTemplates/ERC721Mintable/ERC721Mintable.js Outdated Show resolved Hide resolved
integration-test/writeContract.test.js Outdated Show resolved Hide resolved
@salimtb salimtb force-pushed the PTP-463 branch 2 times, most recently from 2e9cf54 to 52ee1b5 Compare June 3, 2022 12:43
kalote
kalote suggested changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@kalote kalote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change type of JSDoc parameters + add some comment on the integration test +
@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2022

Please retry analysis of this Pull-Request directly on SonarCloud.
@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.7% 94.7% Coverage
0.0% 0.0% Duplication
@kalote kalote merged commit dba8b7a into main Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
4 participants
@salimtb @kalote @efecarranza @VGau