Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

feat(PTP-469): add setApprovalForAll #37

Merged
merged 2 commits into from
Jun 2, 2022
Merged

feat(PTP-469): add setApprovalForAll #37

merged 2 commits into from
Jun 2, 2022

Conversation

VGau
Copy link
Collaborator

@VGau VGau commented Jun 1, 2022

No description provided.

kalote
kalote reviewed Jun 2, 2022
View reviewed changes
test/ERC721Mintable.test.js Outdated Show resolved Hide resolved
kalote
kalote suggested changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@kalote kalote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additional check + force boolean + test description
@VGau VGau force-pushed the feat/PTP-469 branch 5 times, most recently from b63ed84 to ad72fde Compare June 2, 2022 14:46
@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.3% 92.3% Coverage
0.0% 0.0% Duplication
@kalote kalote merged commit 01ee2f0 into main Jun 2, 2022
salimtb
salimtb reviewed Jun 2, 2022
View reviewed changes
integration-test/writeContract.test.js
tokenId: 0,
});
console.log(tx);
const receipt = await tx.wait();
console.log(receipt);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove console.log
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be removed in Johann PR :)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
4 participants
@VGau @kalote @salimtb @danielpavelicconsensys