Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Feat/ptp 425 #34

Merged
merged 23 commits into from
Jun 3, 2022
Merged

Feat/ptp 425 #34

merged 23 commits into from
Jun 3, 2022

Conversation

danielpavelicconsensys
Copy link
Contributor

No description provided.

@Consensys Consensys deleted a comment from sonarcloud bot Jun 1, 2022
kalote
kalote suggested changes Jun 1, 2022
View reviewed changes
lib/ContractTemplates/ERC721Mintable/ERC721Mintable.js Outdated Show resolved Hide resolved
lib/ContractTemplates/ERC721Mintable/ERC721Mintable.js Outdated Show resolved Hide resolved
lib/ContractTemplates/ERC721Mintable/ERC721Mintable.js Show resolved Hide resolved
lib/ContractTemplates/ERC721Mintable/ERC721Mintable.js Outdated Show resolved Hide resolved
lib/ContractTemplates/ERC721Mintable/ERC721Mintable.js Outdated Show resolved Hide resolved
lib/ContractTemplates/ERC721Mintable/ERC721Mintable.js Outdated Show resolved Hide resolved
lib/ContractTemplates/ERC721Mintable/ERC721Mintable.js Outdated Show resolved Hide resolved
lib/SDK/sdk.js Outdated Show resolved Hide resolved
kalote
kalote reviewed Jun 1, 2022
View reviewed changes
e2e/keys.json Outdated Show resolved Hide resolved
@danielpavelicconsensys danielpavelicconsensys force-pushed the feat/PTP-425 branch 5 times, most recently from fbb7957 to 9a5397e Compare June 3, 2022 09:19
VGau
VGau suggested changes Jun 3, 2022
View reviewed changes
e2e/keys.json Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
lib/SDK/sdk.js Outdated Show resolved Hide resolved
@danielpavelicconsensys danielpavelicconsensys force-pushed the feat/PTP-425 branch 2 times, most recently from 48f2d5f to 22993b9 Compare June 3, 2022 10:04
VGau
VGau reviewed Jun 3, 2022
View reviewed changes
keys.json Outdated Show resolved Hide resolved
kalote
kalote suggested changes Jun 3, 2022
View reviewed changes
keys.json Outdated Show resolved Hide resolved
integration-test/writeContract.test.js Outdated Show resolved Hide resolved
lib/ContractTemplates/ERC721Mintable/ERC721Mintable.js Outdated Show resolved Hide resolved
lib/ContractTemplates/ERC721Mintable/ERC721Mintable.js Outdated Show resolved Hide resolved
lib/ContractTemplates/ERC721Mintable/ERC721Mintable.js Outdated Show resolved Hide resolved
lib/ContractTemplates/ERC721Mintable/ERC721Mintable.js Show resolved Hide resolved
lib/ContractTemplates/ERC721Mintable/ERC721Mintable.js Outdated Show resolved Hide resolved
lib/SDK/sdk.js Outdated Show resolved Hide resolved
test/ERC721Mintable.test.js Outdated Show resolved Hide resolved
test/SDK.test.js Outdated Show resolved Hide resolved
@danielpavelicconsensys danielpavelicconsensys force-pushed the feat/PTP-425 branch 2 times, most recently from 1108dcd to a8ab55a Compare June 3, 2022 11:22
@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

83.3% 83.3% Coverage
0.0% 0.0% Duplication
kalote
kalote reviewed Jun 3, 2022
View reviewed changes
lib/SDK/sdk.js Outdated Show resolved Hide resolved
kalote
kalote reviewed Jun 3, 2022
View reviewed changes
lib/SDK/sdk.js Outdated Show resolved Hide resolved
kalote
kalote suggested changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@kalote kalote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove getRoyalties() at SDK level (and the associated test) + remove constant.js (only 1 var, so not needed)
@danielpavelicconsensys
feat(PTP-425): Tests added.
817ad17
@danielpavelicconsensys
feat(PTP-425): Set royalties finished.
c003330
@danielpavelicconsensys
feat(PTP-425): Method setRoyalty implementation in progress.
c770097
@danielpavelicconsensys
feat(PTP-425): Unit tests added. In progress.
2244429
@danielpavelicconsensys
feat(PTP-425): Get royalties in progress.
18865a2
@danielpavelicconsensys
feat(PTP-425): Tests added.
49b39ed
@danielpavelicconsensys
feat(PTP-425): Set royalties finished.
02ab52e
@danielpavelicconsensys
feat(PTP-425): Added unit tests for getRoyalties.
54dd79d
@danielpavelicconsensys
feat(PTP-425): Method setRoyalty implementation in progress.
8e8ade5
@danielpavelicconsensys
feat(PTP-425): Unit tests added. In progress.
8295beb
@danielpavelicconsensys
feat(PTP-425): Get/Set Royalties in progress.
cb5b273
@danielpavelicconsensys
feat(PTP-425): Tests added.
0a07420
@danielpavelicconsensys
feat(PTP-425): Set royalties finished.
23b3f53
@danielpavelicconsensys
feat(PTP-425): Added unit tests for getRoyalties.
f1afea0
@danielpavelicconsensys
feat(PTP-425): PR recommended improvements added.
7c84936
@danielpavelicconsensys
feat(PTP-425): PR recommended improvements added.
5170228
@danielpavelicconsensys
feat(PTP-425): Added additional unit tests to increase coverage.
e2ffa1c
@danielpavelicconsensys
Added gasLimit as constant
bbef22c
kalote
kalote suggested changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@kalote kalote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final comment on the throw error
@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.4% 86.4% Coverage
0.0% 0.0% Duplication
@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.4% 86.4% Coverage
0.0% 0.0% Duplication
@kalote kalote merged commit 15beb05 into main Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
5 participants
@danielpavelicconsensys @kalote @efecarranza @salimtb @VGau