Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

fix: add try/catch + remove openHandles in test + refactor usage.js #28

Merged
merged 9 commits into from
May 31, 2022
Merged

fix: add try/catch + remove openHandles in test + refactor usage.js #28

merged 9 commits into from
May 31, 2022

Conversation

kalote
Copy link
Contributor

@kalote kalote commented May 27, 2022

  • add try / catch in ERC721Mintable class
  • contractAddress public in ERC721Mintable class
  • mint fn returns the ethers.tx in ERC721Mintable class
  • fixed openHandles when running e2e/readContract.test.js
  • usage.js refactored
@kalote
Copy link
Contributor Author

kalote commented May 27, 2022

Ganache added for E2E tests instead of deploying on rinkeby
@kalote
Copy link
Contributor Author

kalote commented May 31, 2022

2 approvers and I fixed @efecarranza comments so i will merge.
@sonarcloud
Copy link

sonarcloud bot commented May 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

89.4% 89.4% Coverage
0.0% 0.0% Duplication
@kalote kalote merged commit 56049ad into main May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
4 participants
@kalote @efecarranza @salimtb @VGau