This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Feat/ptp 423 #27
Merged
Feat/ptp 423 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efecarranza
reviewed
May 25, 2022
efecarranza
previously approved these changes
May 26, 2022
| import Sdk from './lib/SDK/sdk'; | ||
| import Auth from './lib/Auth/Auth'; | ||
| import { TEMPLATES } from './lib/NFT/constants'; | ||
| import Sdk from './lib/SDK/sdk.js'; |
There was a problem hiding this comment.
as we using .js or not?
There was a problem hiding this comment.
.js for module type and avoid ERR_MODULE_NOT_FOUND error (see: https://stackoverflow.com/a/68783000/7526335)
efecarranza
previously approved these changes
May 26, 2022
…t on params in sdk.deploy
|
Kudos, SonarCloud Quality Gate passed! |
efecarranza
approved these changes
May 26, 2022
danielpavelicconsensys
approved these changes
May 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 new functions: