Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Ptp 404 tech create sdk write implementation #24

Merged
merged 1 commit into from
May 25, 2022

Conversation

danielpavelicconsensys
Copy link
Contributor

No description provided.

@salimtb salimtb force-pushed the PTP-404-tech-create-sdk-write-implementation branch 2 times, most recently from 0c16194 to 7a9afb3 Compare May 24, 2022 14:48
@efecarranza efecarranza self-requested a review May 24, 2022 14:49
@salimtb salimtb force-pushed the PTP-404-tech-create-sdk-write-implementation branch from 7a9afb3 to 458ba8a Compare May 24, 2022 14:53
.eslintrc.json Outdated Show resolved Hide resolved
@salimtb salimtb force-pushed the PTP-404-tech-create-sdk-write-implementation branch 3 times, most recently from b62f061 to 987558b Compare May 24, 2022 15:09
lib/NFT/constants.js Outdated Show resolved Hide resolved
@danielpavelicconsensys danielpavelicconsensys force-pushed the PTP-404-tech-create-sdk-write-implementation branch from 987558b to 606e358 Compare May 24, 2022 15:42
Copy link
Contributor

@kalote kalote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the .DS_Store (add in .gitignore)

lib/SDK/index.js Outdated Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
Copy link
Contributor

@efecarranza efecarranza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

lib/ContractTemplates/nftContractUnlimited.js Outdated Show resolved Hide resolved
lib/ContractTemplates/nftContractUnlimited.js Outdated Show resolved Hide resolved
lib/ContractTemplates/nftContractUnlimited.js Outdated Show resolved Hide resolved
lib/NFT/SDK.js Outdated Show resolved Hide resolved
lib/NFT/constants.js Outdated Show resolved Hide resolved
lib/NFT/constants.js Outdated Show resolved Hide resolved
lib/NFT/contractFactory.js Outdated Show resolved Hide resolved
lib/SDK/index.js Outdated Show resolved Hide resolved
lib/SDK/index.js Outdated Show resolved Hide resolved
lib/SDK/index.js Outdated Show resolved Hide resolved
@efecarranza
Copy link
Contributor

efecarranza commented May 24, 2022

PS: i think we need a subfolder for everything contracts.
Also, for ERC20 related endpoints, which are not NFTs, we probably want an "Assets" module

@salimtb salimtb force-pushed the PTP-404-tech-create-sdk-write-implementation branch 8 times, most recently from 5b70e83 to 6846b25 Compare May 25, 2022 08:29
@danielpavelicconsensys danielpavelicconsensys force-pushed the PTP-404-tech-create-sdk-write-implementation branch from ae5b651 to 511a97d Compare May 25, 2022 12:51
@sonarcloud
Copy link

sonarcloud bot commented May 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@danielpavelicconsensys danielpavelicconsensys force-pushed the PTP-404-tech-create-sdk-write-implementation branch 2 times, most recently from b2f4542 to e1dd5c9 Compare May 25, 2022 12:56
Copy link
Contributor

@efecarranza efecarranza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, really excited to build a truffle box once this is merged!
Just some last things around the implemenation of deploy

lib/ContractTemplates/ERC721Mintable/ERC721Mintable.js Outdated Show resolved Hide resolved
lib/ContractTemplates/ERC721Mintable/ERC721Mintable.js Outdated Show resolved Hide resolved
lib/SDK/sdk.js Outdated Show resolved Hide resolved
usage.js Outdated Show resolved Hide resolved
lib/SDK/sdk.js Outdated Show resolved Hide resolved
lib/SDK/sdk.js Outdated Show resolved Hide resolved
@salimtb salimtb force-pushed the PTP-404-tech-create-sdk-write-implementation branch 4 times, most recently from b3675ac to b555d64 Compare May 25, 2022 15:53
kalote
kalote previously approved these changes May 25, 2022
@salimtb salimtb force-pushed the PTP-404-tech-create-sdk-write-implementation branch from b555d64 to b4433e2 Compare May 25, 2022 16:10
@salimtb salimtb force-pushed the PTP-404-tech-create-sdk-write-implementation branch from b4433e2 to 51bb3fb Compare May 25, 2022 16:13
@efecarranza efecarranza merged commit ac26fad into main May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
5 participants