Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] tab links on statististical* consulting page don't work #722

Open
felliott opened this issue Aug 2, 2016 · 7 comments
Open

[bug] tab links on statististical* consulting page don't work #722

felliott opened this issue Aug 2, 2016 · 7 comments

Comments

@felliott
Copy link
Member

felliott commented Aug 2, 2016

Issue

Go to https://cos.io/stats_consulting/. Give the page a few seconds to load all of its assets. Click on "Statistical and Methodological Consulting" under the "We offer free" header.

I'd expect to be taken to the Statistical Consulting tab, but nothing happens. Clicking directly on the tab works as expected.

screen shot 2016-08-02 at 4 55 56 pm

Symptoms

When loading the page with an anchor, two assets don't load:

screen shot 2016-08-02 at 4 58 20 pm

  • I declare this the new official spelling of "statistical".
@saradbowman
Copy link
Contributor

Hey @csoderberg @aprilcs @jolene-esposito: can one of you help with a fix for this? Thanks!

@jolene-esposito
Copy link

I think it's going to be a bigger fix than we anticipate since it has something to do with the tabs. The quickest fix right now is to just unlink them and let people navigate the page using just the tabs.

@aprilcs
Copy link
Contributor

aprilcs commented Aug 3, 2016

I am happy to help in anyway I can, but the tabs were working on the staged version Courtney made, so I don't have the expertise to know why they don't work live. If Jolene's suggestion works in the meantime, let's do that to start.

@felliott
Copy link
Member Author

felliott commented Aug 3, 2016

I took a quick peek, and I think the paths to the JS at the bottom of the mako file are wrong. I'll submit a quick PR.

@felliott
Copy link
Member Author

felliott commented Aug 3, 2016

PR: #723

This will fix the 404s, which might fix this issue.

@csoderberg
Copy link
Contributor

If the above PR doesn't fix it, then I think I know what the problem is. For the links, I put the url for each tab, but instead I should have used something like this:

Statistical Consulting

so that the page automatically switches to the tab, rather than having to refresh the page to get it to move to the new tab, which is what is happening now.

@jolene-esposito
Copy link

Thanks for looking into this Fitz! I looked, but couldn't find the problem. But, I also don't know that much about the codebase. haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants