Early Review of draft-ietf-mpls-msd-yang-04
review-ietf-mpls-msd-yang-04-rtgdir-early-hares-2024-01-22-00

Routing Directorate report on draft-ietf-mpls-msd-yang-04.txt 
Status: Has one small technical issue that needs checking + 1 editorial nit 

Caveat: I am not a Yang doctor, I am counting on Yang doctor's review from Jan Lindblad: 

Yang Doctor Review Initial link: 
https://mailarchive.ietf.org/arch/msg/yang-doctors/PUx5grv1ch3L93cBmwKS_iFB3_w/

Yang Doctor's comments resolved on -04.txt  
https://mailarchive.ietf.org/arch/msg/yang-doctors/9TlCawy9EyQ69Ap4n0LcFeown8A/


Content: two small and focused modules. 
1) iana-msd-types
2) ietf-mpls-msd 

One small technical issue in  module ietf-mpls-msd: 

     identity msd-mpls {
       base msd-base-mpls;
       description
         "Base MPLS Imposition MSD.";
       reference
         "RFC 8491: Signaling Maximum SID Depth (MSD) using IS-IS.
          RFC 8476: Signaling Maximum SID Depth (MSD) using OSPF.";
     }


Question: 
Why does this only specify [RFC8476] (OSPF) and [RFC8491] (ISIS)  
and leave out PCE MSD [RFC8664] and BGP [RFC8814]. 
Is there some assumption that PCE and BGP will not set maximum 
MSD depth for MPLS? 

 
Editorial, Abstract: suggestion to combine last two 


Old Text: / 
   YANG [RFC7950] is a data definition language used to define the
   contents of a conceptual data store that allows networked devices to
   be managed using NETCONF [RFC6241] or RESTCONF [RFC8040].

   There are two YANG modules defined in this document.  Module iana-
   msd-types defines the identities for Maximum SID Depth (MSD) Types as
   the IANA the IGP MSD-Types registry.  This document also defines
   module ietf-mpls-msd augmenting the IETF MPLS YANG model [RFC8960],
   which itself augments [RFC8349], to provide operational state for
   various MSDs[RFC8662].  The module augments the base MPLS model with
   a list of various types of node MSDs, as well as various types of
   MSDs on links.

   The augmentation defined in this document requires support for the
   MPLS base model[RFC8960] which defines basic MPLS configuration and
   state.

   The YANG modules in this document conform to the Network Management
   Datastore Architecture (NMDA) [RFC8342].
/

New text: / 
   YANG [RFC7950] is a data definition language used to define the
   contents of a conceptual data store that allows networked devices to
   be managed using NETCONF [RFC6241] or RESTCONF [RFC8040].


   There are two YANG modules defined in this document.  Module iana-
   msd-types defines the identities for Maximum SID Depth (MSD) Types as
   the IANA the IGP MSD-Types registry.  This document also defines
   module ietf-mpls-msd augmenting the IETF MPLS YANG model [RFC8960],
   which itself augments [RFC8349], to provide operational state for
   various MSDs[RFC8662].  The module augments the base MPLS model with
   a list of various types of node MSDs, as well as various types of
   MSDs on links.

   The augmentation defined in this document requires support for the
   MPLS base model[RFC8960] which defines basic MPLS configuration and
   state. The YANG modules in this document conform to the Network Management
   Datastore Architecture (NMDA) [RFC8342].
   
 /